* drivers/net: tulip_remove_one needs to call pci_disable_device()
@ 2014-02-14 14:32 Sebastian Andrzej Siewior
2014-02-17 5:19 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2014-02-14 14:32 UTC (permalink / raw)
To: Grant Grundler
Cc: netdev, David S. Miller, Ingo Molnar, Thomas Gleixner,
Sebastian Andrzej Siewior
From: Ingo Molnar <mingo@elte.hu>
Otherwise the device is not completely shut down.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
The patch is from "Date: Fri, 3 Jul 2009 08:30:18 -0500" and has been
in -RT since. Now that I stumbled upon it and didn't notice anything -RT
specific, here it comes.
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index add05f1..1642de7 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
pci_iounmap(pdev, tp->base_addr);
free_netdev (dev);
pci_release_regions (pdev);
+ pci_disable_device(pdev);
/* pci_power_off (pdev, -1); */
}
--
1.9.0.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: drivers/net: tulip_remove_one needs to call pci_disable_device()
2014-02-14 14:32 drivers/net: tulip_remove_one needs to call pci_disable_device() Sebastian Andrzej Siewior
@ 2014-02-17 5:19 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-02-17 5:19 UTC (permalink / raw)
To: bigeasy; +Cc: grundler, netdev, mingo, tglx
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Fri, 14 Feb 2014 15:32:20 +0100
> From: Ingo Molnar <mingo@elte.hu>
>
> Otherwise the device is not completely shut down.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Looks good, applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-17 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14 14:32 drivers/net: tulip_remove_one needs to call pci_disable_device() Sebastian Andrzej Siewior
2014-02-17 5:19 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.