* [PATCH] watchdog: intel_scu_watchdog: Remove unused variable
@ 2014-02-15 9:22 Alexander Shiyan
2014-02-15 17:46 ` Guenter Roeck
2014-02-24 19:58 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Shiyan @ 2014-02-15 9:22 UTC (permalink / raw)
To: linux-watchdog; +Cc: Wim Van Sebroeck, Alexander Shiyan
Variable "hw_pre_value" is not used anywhere in the
function intel_scu_set_heartbeat().
This patch removes this variable.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/watchdog/intel_scu_watchdog.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/watchdog/intel_scu_watchdog.c b/drivers/watchdog/intel_scu_watchdog.c
index e13e65e..0caab62 100644
--- a/drivers/watchdog/intel_scu_watchdog.c
+++ b/drivers/watchdog/intel_scu_watchdog.c
@@ -211,7 +211,6 @@ static int intel_scu_set_heartbeat(u32 t)
int ipc_ret;
int retry_count;
u32 soft_value;
- u32 hw_pre_value;
u32 hw_value;
watchdog_device.timer_set = t;
@@ -273,8 +272,7 @@ static int intel_scu_set_heartbeat(u32 t)
watchdog_device.timer_load_count_addr);
/* read count value before starting timer */
- hw_pre_value = ioread32(watchdog_device.timer_load_count_addr);
- hw_pre_value = hw_pre_value & 0xFFFF0000;
+ ioread32(watchdog_device.timer_load_count_addr);
/* Start the timer */
iowrite32(0x00000003, watchdog_device.timer_control_addr);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: intel_scu_watchdog: Remove unused variable
2014-02-15 9:22 [PATCH] watchdog: intel_scu_watchdog: Remove unused variable Alexander Shiyan
@ 2014-02-15 17:46 ` Guenter Roeck
2014-02-24 19:58 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-02-15 17:46 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-watchdog, Wim Van Sebroeck
On Sat, Feb 15, 2014 at 01:22:18PM +0400, Alexander Shiyan wrote:
> Variable "hw_pre_value" is not used anywhere in the
> function intel_scu_set_heartbeat().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/intel_scu_watchdog.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/intel_scu_watchdog.c b/drivers/watchdog/intel_scu_watchdog.c
> index e13e65e..0caab62 100644
> --- a/drivers/watchdog/intel_scu_watchdog.c
> +++ b/drivers/watchdog/intel_scu_watchdog.c
> @@ -211,7 +211,6 @@ static int intel_scu_set_heartbeat(u32 t)
> int ipc_ret;
> int retry_count;
> u32 soft_value;
> - u32 hw_pre_value;
> u32 hw_value;
>
> watchdog_device.timer_set = t;
> @@ -273,8 +272,7 @@ static int intel_scu_set_heartbeat(u32 t)
> watchdog_device.timer_load_count_addr);
>
> /* read count value before starting timer */
> - hw_pre_value = ioread32(watchdog_device.timer_load_count_addr);
> - hw_pre_value = hw_pre_value & 0xFFFF0000;
> + ioread32(watchdog_device.timer_load_count_addr);
>
> /* Start the timer */
> iowrite32(0x00000003, watchdog_device.timer_control_addr);
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: intel_scu_watchdog: Remove unused variable
2014-02-15 9:22 [PATCH] watchdog: intel_scu_watchdog: Remove unused variable Alexander Shiyan
2014-02-15 17:46 ` Guenter Roeck
@ 2014-02-24 19:58 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2014-02-24 19:58 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-watchdog
Hi Alexander,
> Variable "hw_pre_value" is not used anywhere in the
> function intel_scu_set_heartbeat().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/watchdog/intel_scu_watchdog.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/intel_scu_watchdog.c b/drivers/watchdog/intel_scu_watchdog.c
> index e13e65e..0caab62 100644
> --- a/drivers/watchdog/intel_scu_watchdog.c
> +++ b/drivers/watchdog/intel_scu_watchdog.c
> @@ -211,7 +211,6 @@ static int intel_scu_set_heartbeat(u32 t)
> int ipc_ret;
> int retry_count;
> u32 soft_value;
> - u32 hw_pre_value;
> u32 hw_value;
>
> watchdog_device.timer_set = t;
> @@ -273,8 +272,7 @@ static int intel_scu_set_heartbeat(u32 t)
> watchdog_device.timer_load_count_addr);
>
> /* read count value before starting timer */
> - hw_pre_value = ioread32(watchdog_device.timer_load_count_addr);
> - hw_pre_value = hw_pre_value & 0xFFFF0000;
> + ioread32(watchdog_device.timer_load_count_addr);
>
> /* Start the timer */
> iowrite32(0x00000003, watchdog_device.timer_control_addr);
> --
> 1.8.3.2
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-24 19:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-15 9:22 [PATCH] watchdog: intel_scu_watchdog: Remove unused variable Alexander Shiyan
2014-02-15 17:46 ` Guenter Roeck
2014-02-24 19:58 ` Wim Van Sebroeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.