* [PATCH] watchdog: sc520_wdt: Remove unused variable
@ 2014-02-15 9:22 Alexander Shiyan
2014-02-15 17:47 ` Guenter Roeck
2014-02-24 19:59 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Shiyan @ 2014-02-15 9:22 UTC (permalink / raw)
To: linux-watchdog; +Cc: Wim Van Sebroeck, Alexander Shiyan
Variable "dummy" is not used anywhere in the function wdt_config().
This patch removes this variable.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/watchdog/sc520_wdt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/watchdog/sc520_wdt.c b/drivers/watchdog/sc520_wdt.c
index f353e18..1cfd3f6 100644
--- a/drivers/watchdog/sc520_wdt.c
+++ b/drivers/watchdog/sc520_wdt.c
@@ -158,12 +158,11 @@ static void wdt_timer_ping(unsigned long data)
static void wdt_config(int writeval)
{
- __u16 dummy;
unsigned long flags;
/* buy some time (ping) */
spin_lock_irqsave(&wdt_spinlock, flags);
- dummy = readw(wdtmrctl); /* ensure write synchronization */
+ readw(wdtmrctl); /* ensure write synchronization */
writew(0xAAAA, wdtmrctl);
writew(0x5555, wdtmrctl);
/* unlock WDT = make WDT configuration register writable one time */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: sc520_wdt: Remove unused variable
2014-02-15 9:22 [PATCH] watchdog: sc520_wdt: Remove unused variable Alexander Shiyan
@ 2014-02-15 17:47 ` Guenter Roeck
2014-02-24 19:59 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-02-15 17:47 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-watchdog, Wim Van Sebroeck
On Sat, Feb 15, 2014 at 01:22:49PM +0400, Alexander Shiyan wrote:
> Variable "dummy" is not used anywhere in the function wdt_config().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sc520_wdt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sc520_wdt.c b/drivers/watchdog/sc520_wdt.c
> index f353e18..1cfd3f6 100644
> --- a/drivers/watchdog/sc520_wdt.c
> +++ b/drivers/watchdog/sc520_wdt.c
> @@ -158,12 +158,11 @@ static void wdt_timer_ping(unsigned long data)
>
> static void wdt_config(int writeval)
> {
> - __u16 dummy;
> unsigned long flags;
>
> /* buy some time (ping) */
> spin_lock_irqsave(&wdt_spinlock, flags);
> - dummy = readw(wdtmrctl); /* ensure write synchronization */
> + readw(wdtmrctl); /* ensure write synchronization */
> writew(0xAAAA, wdtmrctl);
> writew(0x5555, wdtmrctl);
> /* unlock WDT = make WDT configuration register writable one time */
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: sc520_wdt: Remove unused variable
2014-02-15 9:22 [PATCH] watchdog: sc520_wdt: Remove unused variable Alexander Shiyan
2014-02-15 17:47 ` Guenter Roeck
@ 2014-02-24 19:59 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2014-02-24 19:59 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-watchdog
Hi Alexander,
> Variable "dummy" is not used anywhere in the function wdt_config().
> This patch removes this variable.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/watchdog/sc520_wdt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sc520_wdt.c b/drivers/watchdog/sc520_wdt.c
> index f353e18..1cfd3f6 100644
> --- a/drivers/watchdog/sc520_wdt.c
> +++ b/drivers/watchdog/sc520_wdt.c
> @@ -158,12 +158,11 @@ static void wdt_timer_ping(unsigned long data)
>
> static void wdt_config(int writeval)
> {
> - __u16 dummy;
> unsigned long flags;
>
> /* buy some time (ping) */
> spin_lock_irqsave(&wdt_spinlock, flags);
> - dummy = readw(wdtmrctl); /* ensure write synchronization */
> + readw(wdtmrctl); /* ensure write synchronization */
> writew(0xAAAA, wdtmrctl);
> writew(0x5555, wdtmrctl);
> /* unlock WDT = make WDT configuration register writable one time */
> --
> 1.8.3.2
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-24 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-15 9:22 [PATCH] watchdog: sc520_wdt: Remove unused variable Alexander Shiyan
2014-02-15 17:47 ` Guenter Roeck
2014-02-24 19:59 ` Wim Van Sebroeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.