* [B.A.T.M.A.N.] [PATCH] batman-adv: use ether_addr_copy instead of memcpy in multicast code
@ 2014-02-17 22:12 Linus Lüssing
2014-02-18 3:07 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Linus Lüssing @ 2014-02-17 22:12 UTC (permalink / raw)
To: b.a.t.m.a.n
ether_addr_copy is supposed to be slightly more efficient for copying
mac addresses, so let's use it. This makes recent versions of checkpatch
happy, too.
Reported-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
multicast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/multicast.c b/multicast.c
index 00bb30e..e69143b 100644
--- a/multicast.c
+++ b/multicast.c
@@ -45,7 +45,7 @@ static int batadv_mcast_mla_softif_get(struct net_device *dev,
break;
}
- memcpy(&new->addr, &mc_list_entry->addr, ETH_ALEN);
+ ether_addr_copy(&new->addr, &mc_list_entry->addr);
hlist_add_head(&new->list, mcast_list);
ret++;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use ether_addr_copy instead of memcpy in multicast code
2014-02-17 22:12 [B.A.T.M.A.N.] [PATCH] batman-adv: use ether_addr_copy instead of memcpy in multicast code Linus Lüssing
@ 2014-02-18 3:07 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2014-02-18 3:07 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Monday 17 February 2014 23:12:35 Linus Lüssing wrote:
> ether_addr_copy is supposed to be slightly more efficient for copying
> mac addresses, so let's use it. This makes recent versions of checkpatch
> happy, too.
>
> Reported-by: Antonio Quartulli <antonio@meshcoding.com>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> multicast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
We need an introduced by line, so Antonio later knows what patches to squash
before sending them to David.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-18 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-17 22:12 [B.A.T.M.A.N.] [PATCH] batman-adv: use ether_addr_copy instead of memcpy in multicast code Linus Lüssing
2014-02-18 3:07 ` Marek Lindner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.