From: Mike Galbraith <bitbucket@online.de>
To: Lei Wen <adrian.wenl@gmail.com>
Cc: Lei Wen <leiwen@marvell.com>,
Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, preeti.lkml@gmail.com,
daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
xjian@marvell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched: keep quiescent cpu out of idle balance loop
Date: Fri, 21 Feb 2014 10:15:26 +0100 [thread overview]
Message-ID: <1392974126.5451.109.camel@marge.simpson.net> (raw)
In-Reply-To: <1392971691.5451.84.camel@marge.simpson.net>
On Fri, 2014-02-21 at 09:34 +0100, Mike Galbraith wrote:
> I think the construction stuff works fine, and !->sd is the perfect cue
> to tell various things to keep their grubby mitts off of a CPU.
Take idle_balance() for instance.. not much point in dropping rq->lock
just to take it again after doing _nothing_, and we certainly wouldn't
want to go play load balancer for connected CPUs anyway, we might get
something much more important to do RSN.
(that applies to rt in general - go off and play load balancer in the
SCHED_OTHER slums? Surely you jest, elite snobs don't do skut work,
they actually might get their hands dirty;)
Or, at user discretion, telling CPUPRI stuff that no load balancing also
means no rt balancing, i.e. the user assumes responsibility for ALL task
placement, so we don't need to call neutered functions or spend cycles
maintaining data we will have no use for until the user tells us he is
finished with these CPUs.
etc.
-Mike
prev parent reply other threads:[~2014-02-21 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:20 [PATCH] sched: keep quiescent cpu out of idle balance loop Lei Wen
2014-02-19 9:04 ` Peter Zijlstra
2014-02-20 2:42 ` Lei Wen
2014-02-20 8:50 ` Peter Zijlstra
2014-02-20 9:15 ` Lei Wen
2014-02-20 9:17 ` Lei Wen
2014-02-20 12:04 ` Peter Zijlstra
2014-02-20 12:23 ` Peter Zijlstra
2014-02-21 2:23 ` [PATCH v2] " Lei Wen
2014-02-21 5:51 ` Mike Galbraith
2014-02-21 7:28 ` Lei Wen
2014-02-21 8:34 ` Mike Galbraith
2014-02-21 9:15 ` [PATCH v3] " Lei Wen
2014-02-21 9:41 ` Mike Galbraith
2014-02-21 9:15 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392974126.5451.109.camel@marge.simpson.net \
--to=bitbucket@online.de \
--cc=adrian.wenl@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=leiwen@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=preeti.lkml@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=xjian@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.