From: Peter Zijlstra <peterz@infradead.org>
To: Lei Wen <leiwen@marvell.com>
Cc: mingo@redhat.com, preeti.lkml@gmail.com,
daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
xjian@marvell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: keep quiescent cpu out of idle balance loop
Date: Thu, 20 Feb 2014 13:23:13 +0100 [thread overview]
Message-ID: <20140220122311.GO27965@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1392887824-20138-1-git-send-email-leiwen@marvell.com>
On Thu, Feb 20, 2014 at 05:17:04PM +0800, Lei Wen wrote:
> +++ b/kernel/sched/fair.c
> @@ -6883,6 +6883,13 @@ void nohz_balance_enter_idle(int cpu)
> if (!cpu_active(cpu))
> return;
>
> + /*
> + * If this cpu is kept outside of root domain, we don't bother
> + * to ask it for nohz balance.
> + */
> + if (!cpumask_test_cpu(cpu, this_rq()->rd.span))
rd->span
Otherwise the compiler gets upset. Fixed it.
> + return;
> +
> if (test_bit(NOHZ_TICK_STOPPED, nohz_flags(cpu)))
> return;
>
> --
> 1.8.3.2
>
next prev parent reply other threads:[~2014-02-20 12:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:20 [PATCH] sched: keep quiescent cpu out of idle balance loop Lei Wen
2014-02-19 9:04 ` Peter Zijlstra
2014-02-20 2:42 ` Lei Wen
2014-02-20 8:50 ` Peter Zijlstra
2014-02-20 9:15 ` Lei Wen
2014-02-20 9:17 ` Lei Wen
2014-02-20 12:04 ` Peter Zijlstra
2014-02-20 12:23 ` Peter Zijlstra [this message]
2014-02-21 2:23 ` [PATCH v2] " Lei Wen
2014-02-21 5:51 ` Mike Galbraith
2014-02-21 7:28 ` Lei Wen
2014-02-21 8:34 ` Mike Galbraith
2014-02-21 9:15 ` [PATCH v3] " Lei Wen
2014-02-21 9:41 ` Mike Galbraith
2014-02-21 9:15 ` [PATCH v2] " Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220122311.GO27965@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=leiwen@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=preeti.lkml@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=xjian@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.