* [PATCH] ASoC: sta32x: Fix cache sync
@ 2014-02-22 17:27 Lars-Peter Clausen
2014-02-23 1:49 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2014-02-22 17:27 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Johannes Stezenbach, Lars-Peter Clausen, alsa-devel
codec->control_data contains a pointer to the regmap struct of the device, not
to the device private data. Use snd_soc_codec_get_drvdata() instead.
The issue was introduced in commit 29fdf4fbbe ("ASoC: sta32x: Convert to
regmap").
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/sta32x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c
index 42c5b45..ea78c17 100644
--- a/sound/soc/codecs/sta32x.c
+++ b/sound/soc/codecs/sta32x.c
@@ -331,7 +331,7 @@ static int sta32x_sync_coef_shadow(struct snd_soc_codec *codec)
static int sta32x_cache_sync(struct snd_soc_codec *codec)
{
- struct sta32x_priv *sta32x = codec->control_data;
+ struct sta32x_priv *sta32x = snd_soc_codec_get_drvdata(codec);
unsigned int mute;
int rc;
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: sta32x: Fix cache sync
2014-02-22 17:27 [PATCH] ASoC: sta32x: Fix cache sync Lars-Peter Clausen
@ 2014-02-23 1:49 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-02-23 1:49 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Johannes Stezenbach, Liam Girdwood, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 238 bytes --]
On Sat, Feb 22, 2014 at 06:27:17PM +0100, Lars-Peter Clausen wrote:
> codec->control_data contains a pointer to the regmap struct of the device, not
> to the device private data. Use snd_soc_codec_get_drvdata() instead.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-23 2:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-22 17:27 [PATCH] ASoC: sta32x: Fix cache sync Lars-Peter Clausen
2014-02-23 1:49 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.