* [PATCH] ASoC: da732x: Use da732x->regmap instead of codec->control_data
@ 2014-02-22 17:34 Lars-Peter Clausen
2014-02-24 11:21 ` Opensource [Adam Thomson]
2014-02-25 4:34 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2014-02-22 17:34 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Adam Thomson, Lars-Peter Clausen, Michal Hajduk, alsa-devel
With the ongoing component-ization of the ASoC framework and the continuing
migration to using regmap for IO the control_data field of the snd_soc_codec
struct will eventually be removed. Prepare the da732x driver for this by using
da732x->regmap instead of accessing the CODEC's control_data field.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/da732x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/da732x.c b/sound/soc/codecs/da732x.c
index f295b65..54db45d 100644
--- a/sound/soc/codecs/da732x.c
+++ b/sound/soc/codecs/da732x.c
@@ -1487,8 +1487,8 @@ static int da732x_set_bias_level(struct snd_soc_codec *codec,
da732x_hp_dc_offset_cancellation(codec);
- regcache_cache_only(codec->control_data, false);
- regcache_sync(codec->control_data);
+ regcache_cache_only(da732x->regmap, false);
+ regcache_sync(da732x->regmap);
} else {
snd_soc_update_bits(codec, DA732X_REG_BIAS_EN,
DA732X_BIAS_BOOST_MASK,
@@ -1499,7 +1499,7 @@ static int da732x_set_bias_level(struct snd_soc_codec *codec,
}
break;
case SND_SOC_BIAS_OFF:
- regcache_cache_only(codec->control_data, true);
+ regcache_cache_only(da732x->regmap, true);
da732x_set_charge_pump(codec, DA732X_DISABLE_CP);
snd_soc_update_bits(codec, DA732X_REG_BIAS_EN, DA732X_BIAS_EN,
DA732X_BIAS_DIS);
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: da732x: Use da732x->regmap instead of codec->control_data
2014-02-22 17:34 [PATCH] ASoC: da732x: Use da732x->regmap instead of codec->control_data Lars-Peter Clausen
@ 2014-02-24 11:21 ` Opensource [Adam Thomson]
2014-02-25 4:34 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Opensource [Adam Thomson] @ 2014-02-24 11:21 UTC (permalink / raw)
To: Lars-Peter Clausen, Mark Brown, Liam Girdwood; +Cc: alsa-devel
On Sat, 22 Feb 2014 17:35:01 +0000, Lars-Peter Clausen wrote:
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: da732x: Use da732x->regmap instead of codec->control_data
2014-02-22 17:34 [PATCH] ASoC: da732x: Use da732x->regmap instead of codec->control_data Lars-Peter Clausen
2014-02-24 11:21 ` Opensource [Adam Thomson]
@ 2014-02-25 4:34 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-02-25 4:34 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Adam Thomson, Liam Girdwood, alsa-devel, Michal Hajduk
[-- Attachment #1.1: Type: text/plain, Size: 394 bytes --]
On Sat, Feb 22, 2014 at 06:34:45PM +0100, Lars-Peter Clausen wrote:
> With the ongoing component-ization of the ASoC framework and the continuing
> migration to using regmap for IO the control_data field of the snd_soc_codec
> struct will eventually be removed. Prepare the da732x driver for this by using
> da732x->regmap instead of accessing the CODEC's control_data field.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-25 4:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-22 17:34 [PATCH] ASoC: da732x: Use da732x->regmap instead of codec->control_data Lars-Peter Clausen
2014-02-24 11:21 ` Opensource [Adam Thomson]
2014-02-25 4:34 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.