[PATCH net-next] ieee802154: fix new function declaration

[PATCH net-next] ieee802154: fix new function declaration

[Jean Sacren]

The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
at86rf230 driver") introduced the new function is_rf212() with some
minor issues in declaration:

1) Fix the function type by changing it to bool as the function
   definition returns a boolean value. Additionally both callers of
   is_rf212() are expected to return a boolean value.

2) Fix the function specifier by deleting the inline keyword as the
   compiler takes care of that.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Cc: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
---
 drivers/net/ieee802154/at86rf230.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 34bf011584fb..dd9ef5e1c730 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -57,7 +57,7 @@ struct at86rf230_local {
 	int rssi_base_val;
 };
 
-static inline int is_rf212(struct at86rf230_local *local)
+static bool is_rf212(struct at86rf230_local *local)
 {
 	return local->part == 7;
 }

Re: [PATCH net-next] ieee802154: fix new function declaration

[Phoebe Buckheister]

On Tue, 25 Feb 2014 22:38:29 -0700
Jean Sacren <sakiwit@gmail.com> wrote:

> The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
> at86rf230 driver") introduced the new function is_rf212() with some
> minor issues in declaration:
> 
> 1) Fix the function type by changing it to bool as the function
>    definition returns a boolean value. Additionally both callers of
>    is_rf212() are expected to return a boolean value.
> 
> 2) Fix the function specifier by deleting the inline keyword as the
>    compiler takes care of that.
> 
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
> Cc: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>

+1. My original intent was to have is_rf212 as a predicate like that,
but I slipped.

Re: [PATCH net-next] ieee802154: fix new function declaration

[David Miller]

From: Jean Sacren <sakiwit@gmail.com>
Date: Tue, 25 Feb 2014 22:38:29 -0700

> The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
> at86rf230 driver") introduced the new function is_rf212() with some
> minor issues in declaration:
> 
> 1) Fix the function type by changing it to bool as the function
>    definition returns a boolean value. Additionally both callers of
>    is_rf212() are expected to return a boolean value.
> 
> 2) Fix the function specifier by deleting the inline keyword as the
>    compiler takes care of that.
> 
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>

Applied, thanks.