All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Salter <msalter@redhat.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH v4 4/6] arm: add early_ioremap support
Date: Wed, 26 Feb 2014 09:59:20 -0500	[thread overview]
Message-ID: <1393426760.26583.43.camel@deneb.redhat.com> (raw)
In-Reply-To: <CAL_JsqLi=GhGy7dNf2BiAGd4EtzfqqYfbo0YhRhyhuwEp0w8HQ@mail.gmail.com>

On Tue, 2014-02-25 at 23:48 -0600, Rob Herring wrote:
> > +#define NR_FIX_BTMAPS          32
> > +#define FIX_BTMAPS_SLOTS       7
> > +#define TOTAL_FIX_BTMAPS       (NR_FIX_BTMAPS * FIX_BTMAPS_SLOTS)
> > +#define FIX_BTMAP_END          FIX_KMAP_BEGIN
> > +#define FIX_BTMAP_BEGIN                (FIX_BTMAP_END +
> TOTAL_FIX_BTMAPS - 1)
> 
> Why the different logic from arm64? Specifically, it doesn't make
> adding a permanent mapping simple.

I looked at adding support for permanent mappings but it was going to
take more time than I had. Also on ARM, we have to deal with kmap's
needs as well. Working that out was going to take more time than I
had. I think getting the patch in now to support early_ioremap is
the way to go. Adding support for permanent mappings can be done
later with the early console support for which it is needed.



WARNING: multiple messages have this Message-ID (diff)
From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/6] arm: add early_ioremap support
Date: Wed, 26 Feb 2014 09:59:20 -0500	[thread overview]
Message-ID: <1393426760.26583.43.camel@deneb.redhat.com> (raw)
In-Reply-To: <CAL_JsqLi=GhGy7dNf2BiAGd4EtzfqqYfbo0YhRhyhuwEp0w8HQ@mail.gmail.com>

On Tue, 2014-02-25 at 23:48 -0600, Rob Herring wrote:
> > +#define NR_FIX_BTMAPS          32
> > +#define FIX_BTMAPS_SLOTS       7
> > +#define TOTAL_FIX_BTMAPS       (NR_FIX_BTMAPS * FIX_BTMAPS_SLOTS)
> > +#define FIX_BTMAP_END          FIX_KMAP_BEGIN
> > +#define FIX_BTMAP_BEGIN                (FIX_BTMAP_END +
> TOTAL_FIX_BTMAPS - 1)
> 
> Why the different logic from arm64? Specifically, it doesn't make
> adding a permanent mapping simple.

I looked at adding support for permanent mappings but it was going to
take more time than I had. Also on ARM, we have to deal with kmap's
needs as well. Working that out was going to take more time than I
had. I think getting the patch in now to support early_ioremap is
the way to go. Adding support for permanent mappings can be done
later with the early console support for which it is needed.

  parent reply	other threads:[~2014-02-26 15:00 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 20:56 [PATCH v4 0/6] generic early_ioremap support Mark Salter
2014-02-12 20:56 ` Mark Salter
2014-02-12 20:56 ` [PATCH v4 1/6] x86/mm: sparse warning fix for early_memremap Mark Salter
2014-02-12 20:56 ` [PATCH v4 2/6] mm: create generic early_ioremap() support Mark Salter
2014-02-12 20:56   ` Mark Salter
2014-02-12 20:56 ` [PATCH v4 3/6] x86: use generic early_ioremap Mark Salter
2014-02-12 20:56 ` [PATCH v4 4/6] arm: add early_ioremap support Mark Salter
2014-02-12 20:56   ` Mark Salter
2014-02-26  5:48   ` Rob Herring
2014-02-26  5:48     ` Rob Herring
2014-02-26  9:38     ` Leif Lindholm
2014-02-26  9:38       ` Leif Lindholm
2014-02-26 14:59     ` Mark Salter [this message]
2014-02-26 14:59       ` Mark Salter
2014-02-26 15:56       ` Rob Herring
2014-02-26 15:56         ` Rob Herring
2014-02-12 20:56 ` [PATCH v4 5/6] arm64: initialize pgprot info earlier in boot Mark Salter
2014-02-12 20:56   ` Mark Salter
2014-02-12 20:56 ` [PATCH v4 6/6] arm64: add early_ioremap support Mark Salter
2014-02-12 20:56   ` Mark Salter
2014-02-25 14:10 ` [PATCH v4 0/6] generic " Mark Salter
2014-02-25 14:10   ` Mark Salter
2014-02-25 18:30   ` Will Deacon
2014-02-25 18:30     ` Will Deacon
2014-02-25 18:45     ` Mark Salter
2014-02-25 18:45       ` Mark Salter
2014-02-25 19:42       ` H. Peter Anvin
2014-02-25 19:42         ` H. Peter Anvin
2014-02-25 23:04         ` Catalin Marinas
2014-02-25 23:04           ` Catalin Marinas
2014-02-25 23:05           ` H. Peter Anvin
2014-02-25 23:05             ` H. Peter Anvin
2014-03-03 22:29         ` Mark Salter
2014-03-03 22:29           ` Mark Salter
2014-03-04  1:30           ` H. Peter Anvin
2014-03-04  1:30             ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393426760.26583.43.camel@deneb.redhat.com \
    --to=msalter@redhat.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=patches@linaro.org \
    --cc=robherring2@gmail.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.