* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] <1393418058-14113-1-git-send-email-ian.campbell@citrix.com>
@ 2014-02-26 12:37 ` Daniel P. Berrange
[not found] ` <20140226123703.GC29185@redhat.com>
1 sibling, 0 replies; 11+ messages in thread
From: Daniel P. Berrange @ 2014-02-26 12:37 UTC (permalink / raw)
To: Ian Campbell
Cc: stefano.stabellini, libvir-list, julien.grall, tim, xen-devel,
Jim Fehlig
On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
> Only tested on v7 but the v8 equivalent seems pretty obvious.
>
> XEN_CAP_REGEX already accepts more than it should (e.g. x86_64p or x86_32be)
> but I have stuck with the existing pattern.
>
> With this I can create a guest from:
> <domain type='xen'>
> <name>libvirt-test</name>
> <uuid>6343998e-9eda-11e3-98f6-77252a7d02f3</uuid>
> <memory>393216</memory>
> <currentMemory>393216</currentMemory>
> <vcpu>1</vcpu>
> <os>
> <type arch='armv7l' machine='xenpv'>linux</type>
> <kernel>/boot/vmlinuz-arm-native</kernel>
> <cmdline>console=hvc0 earlyprintk debug root=/dev/xvda1</cmdline>
> </os>
> <clock offset='utc'/>
> <on_poweroff>destroy</on_poweroff>
> <on_reboot>restart</on_reboot>
> <on_crash>destroy</on_crash>
> <devices>
> <disk type='block' device='disk'>
> <source dev='/dev/marilith-n0/debian-disk'/>
> <target dev='xvda1'/>
> </disk>
> <interface type='bridge'>
> <mac address='8e:a7:8e:3c:f4:f6'/>
> <source bridge='xenbr0'/>
> </interface>
> </devices>
> </domain>
>
> Using virsh create and I can destroy it too.
>
> Currently virsh console fails with:
> Connected to domain libvirt-test
> Escape character is ^]
> error: internal error: cannot find character device <null>
>
> I haven't investigated yet.
That'll be because no <console> or <serial> device is
listed in your config above I expect. Also looks like
bogus error handling in the console API, not checking
for <null>.
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <20140226123703.GC29185@redhat.com>
@ 2014-02-26 12:42 ` Ian Campbell
2014-02-26 13:34 ` Eric Blake
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Ian Campbell @ 2014-02-26 12:42 UTC (permalink / raw)
To: Daniel P. Berrange
Cc: stefano.stabellini, libvir-list, julien.grall, tim, xen-devel,
Jim Fehlig
On Wed, 2014-02-26 at 12:37 +0000, Daniel P. Berrange wrote:
> On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
> > Currently virsh console fails with:
> > Connected to domain libvirt-test
> > Escape character is ^]
> > error: internal error: cannot find character device <null>
> >
> > I haven't investigated yet.
>
> That'll be because no <console> or <serial> device is
> listed in your config above I expect. Also looks like
> bogus error handling in the console API, not checking
> for <null>.
Thanks. I've just tried (inside <devices>...</...>):
<console tty='/dev/pts/5'/>
and
<console type='pty'>
<target port='0'/>
</console>
which I gleaned from http://libvirt.org/drvxen.html but neither seem to
do the trick (and the first ones use of an explicit pts looks odd to
me...).
> ACK
Thanks.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <20140226123703.GC29185@redhat.com>
2014-02-26 12:42 ` Ian Campbell
@ 2014-02-26 13:34 ` Eric Blake
[not found] ` <1393418554.18730.41.camel@kazak.uk.xensource.com>
[not found] ` <530DED71.4020604@redhat.com>
3 siblings, 0 replies; 11+ messages in thread
From: Eric Blake @ 2014-02-26 13:34 UTC (permalink / raw)
To: Daniel P. Berrange, Ian Campbell
Cc: libvir-list, xen-devel, julien.grall, tim, stefano.stabellini
[-- Attachment #1.1: Type: text/plain, Size: 960 bytes --]
On 02/26/2014 05:37 AM, Daniel P. Berrange wrote:
> On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
>> Only tested on v7 but the v8 equivalent seems pretty obvious.
>>
>> XEN_CAP_REGEX already accepts more than it should (e.g. x86_64p or x86_32be)
>> but I have stuck with the existing pattern.
>>
>> With this I can create a guest from:
>> <domain type='xen'>
>> <name>libvirt-test</name>
>> <uuid>6343998e-9eda-11e3-98f6-77252a7d02f3</uuid>
>> <memory>393216</memory>
>> <currentMemory>393216</currentMemory>
>> <vcpu>1</vcpu>
>> <os>
>> <type arch='armv7l' machine='xenpv'>linux</type>
>> <kernel>/boot/vmlinuz-arm-native</kernel>
>> <cmdline>console=hvc0 earlyprintk debug root=/dev/xvda1</cmdline>
>> </os>
>
> ACK
I've gone ahead and pushed the patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <1393418554.18730.41.camel@kazak.uk.xensource.com>
@ 2014-02-26 14:00 ` Olaf Hering
2014-02-26 14:55 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Olaf Hering @ 2014-02-26 14:00 UTC (permalink / raw)
To: Ian Campbell
Cc: Daniel P. Berrange, stefano.stabellini, libvir-list,
julien.grall, tim, xen-devel, Jim Fehlig
On Wed, Feb 26, Ian Campbell wrote:
> On Wed, 2014-02-26 at 12:37 +0000, Daniel P. Berrange wrote:
> > On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
> > > Currently virsh console fails with:
> > > Connected to domain libvirt-test
> > > Escape character is ^]
> > > error: internal error: cannot find character device <null>
> > That'll be because no <console> or <serial> device is
> > listed in your config above I expect. Also looks like
> > bogus error handling in the console API, not checking
> > for <null>.
> Thanks. I've just tried (inside <devices>...</...>):
> <console tty='/dev/pts/5'/>
> and
> <console type='pty'>
> <target port='0'/>
> </console>
> which I gleaned from http://libvirt.org/drvxen.html but neither seem to
> do the trick (and the first ones use of an explicit pts looks odd to
> me...).
I learned yesterday this should be "serial" instead of "console", maybe
it fixes also your case.
Olaf
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
2014-02-26 14:00 ` Olaf Hering
@ 2014-02-26 14:55 ` Ian Campbell
2014-02-26 15:01 ` Daniel P. Berrange
[not found] ` <20140226150100.GC6046@redhat.com>
0 siblings, 2 replies; 11+ messages in thread
From: Ian Campbell @ 2014-02-26 14:55 UTC (permalink / raw)
To: Olaf Hering
Cc: Daniel P. Berrange, stefano.stabellini, libvir-list,
julien.grall, tim, xen-devel, Jim Fehlig
On Wed, 2014-02-26 at 15:00 +0100, Olaf Hering wrote:
> On Wed, Feb 26, Ian Campbell wrote:
>
> > On Wed, 2014-02-26 at 12:37 +0000, Daniel P. Berrange wrote:
> > > On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
> > > > Currently virsh console fails with:
> > > > Connected to domain libvirt-test
> > > > Escape character is ^]
> > > > error: internal error: cannot find character device <null>
> > > That'll be because no <console> or <serial> device is
> > > listed in your config above I expect. Also looks like
> > > bogus error handling in the console API, not checking
> > > for <null>.
> > Thanks. I've just tried (inside <devices>...</...>):
> > <console tty='/dev/pts/5'/>
> > and
> > <console type='pty'>
> > <target port='0'/>
> > </console>
> > which I gleaned from http://libvirt.org/drvxen.html but neither seem to
> > do the trick (and the first ones use of an explicit pts looks odd to
> > me...).
>
> I learned yesterday this should be "serial" instead of "console", maybe
> it fixes also your case.
My understanding was that this was for HVM guests, whereas ARM has a PV
console but I suppose I should try it anyway. I've got a flight to catch
so it'll be a few days I expect.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
2014-02-26 14:55 ` Ian Campbell
@ 2014-02-26 15:01 ` Daniel P. Berrange
[not found] ` <20140226150100.GC6046@redhat.com>
1 sibling, 0 replies; 11+ messages in thread
From: Daniel P. Berrange @ 2014-02-26 15:01 UTC (permalink / raw)
To: Ian Campbell
Cc: Olaf Hering, stefano.stabellini, libvir-list, julien.grall, tim,
xen-devel, Jim Fehlig
On Wed, Feb 26, 2014 at 02:55:13PM +0000, Ian Campbell wrote:
> On Wed, 2014-02-26 at 15:00 +0100, Olaf Hering wrote:
> > On Wed, Feb 26, Ian Campbell wrote:
> >
> > > On Wed, 2014-02-26 at 12:37 +0000, Daniel P. Berrange wrote:
> > > > On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
> > > > > Currently virsh console fails with:
> > > > > Connected to domain libvirt-test
> > > > > Escape character is ^]
> > > > > error: internal error: cannot find character device <null>
> > > > That'll be because no <console> or <serial> device is
> > > > listed in your config above I expect. Also looks like
> > > > bogus error handling in the console API, not checking
> > > > for <null>.
> > > Thanks. I've just tried (inside <devices>...</...>):
> > > <console tty='/dev/pts/5'/>
> > > and
> > > <console type='pty'>
> > > <target port='0'/>
> > > </console>
> > > which I gleaned from http://libvirt.org/drvxen.html but neither seem to
> > > do the trick (and the first ones use of an explicit pts looks odd to
> > > me...).
> >
> > I learned yesterday this should be "serial" instead of "console", maybe
> > it fixes also your case.
>
> My understanding was that this was for HVM guests, whereas ARM has a PV
> console but I suppose I should try it anyway. I've got a flight to catch
> so it'll be a few days I expect.
Yep, if ARM has a PV console, then we'd need to add tiny bit to the XML
to allow us to configure that explicitly, similar to how we do for KVM's
virtio-console support.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <530DED71.4020604@redhat.com>
@ 2014-02-26 15:28 ` Ian Campbell
0 siblings, 0 replies; 11+ messages in thread
From: Ian Campbell @ 2014-02-26 15:28 UTC (permalink / raw)
To: Eric Blake
Cc: Daniel P. Berrange, stefano.stabellini, libvir-list,
julien.grall, tim, xen-devel
On Wed, 2014-02-26 at 06:34 -0700, Eric Blake wrote:
> On 02/26/2014 05:37 AM, Daniel P. Berrange wrote:
> > On Wed, Feb 26, 2014 at 12:34:17PM +0000, Ian Campbell wrote:
> >> Only tested on v7 but the v8 equivalent seems pretty obvious.
> >>
> >> XEN_CAP_REGEX already accepts more than it should (e.g. x86_64p or x86_32be)
> >> but I have stuck with the existing pattern.
> >>
> >> With this I can create a guest from:
> >> <domain type='xen'>
> >> <name>libvirt-test</name>
> >> <uuid>6343998e-9eda-11e3-98f6-77252a7d02f3</uuid>
> >> <memory>393216</memory>
> >> <currentMemory>393216</currentMemory>
> >> <vcpu>1</vcpu>
> >> <os>
> >> <type arch='armv7l' machine='xenpv'>linux</type>
> >> <kernel>/boot/vmlinuz-arm-native</kernel>
> >> <cmdline>console=hvc0 earlyprintk debug root=/dev/xvda1</cmdline>
> >> </os>
>
> >
> > ACK
>
> I've gone ahead and pushed the patch.
Wow, that was quick, thanks!
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <20140226150100.GC6046@redhat.com>
@ 2014-02-28 2:12 ` Ian Campbell
2014-02-28 11:03 ` Daniel P. Berrange
[not found] ` <20140228110329.GB17909@redhat.com>
0 siblings, 2 replies; 11+ messages in thread
From: Ian Campbell @ 2014-02-28 2:12 UTC (permalink / raw)
To: Daniel P. Berrange
Cc: Olaf Hering, stefano.stabellini, libvir-list, julien.grall, tim,
xen-devel, Jim Fehlig
On Wed, 2014-02-26 at 15:01 +0000, Daniel P. Berrange wrote:
> Yep, if ARM has a PV console, then we'd need to add tiny bit to the XML
> to allow us to configure that explicitly, similar to how we do for KVM's
> virtio-console support.
Do you mean I need to add something to the XML config snippet, or I need
to add some special handling in the XML parser/consumer?
I've grepped around the virtio-console stuff and I'm none the wiser.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
2014-02-28 2:12 ` Ian Campbell
@ 2014-02-28 11:03 ` Daniel P. Berrange
[not found] ` <20140228110329.GB17909@redhat.com>
1 sibling, 0 replies; 11+ messages in thread
From: Daniel P. Berrange @ 2014-02-28 11:03 UTC (permalink / raw)
To: Ian Campbell
Cc: Olaf Hering, stefano.stabellini, libvir-list, julien.grall, tim,
xen-devel, Jim Fehlig
On Fri, Feb 28, 2014 at 02:12:30AM +0000, Ian Campbell wrote:
> On Wed, 2014-02-26 at 15:01 +0000, Daniel P. Berrange wrote:
> > Yep, if ARM has a PV console, then we'd need to add tiny bit to the XML
> > to allow us to configure that explicitly, similar to how we do for KVM's
> > virtio-console support.
>
> Do you mean I need to add something to the XML config snippet, or I need
> to add some special handling in the XML parser/consumer?
>
> I've grepped around the virtio-console stuff and I'm none the wiser.
Opps, yes, I should have explained this better, since our docs here are
about as clear as mud.
With traditional x86 paravirt Xen, we just have the plain paravirt console
devices
<console type='pty'>
<target type='xen'/>
</console>
With x86 fullvirt Xen/KVM/QEMU, the console type just defaults to being
a serial port so you would usually just add
<serial type='pty'>
</serial>
and then libvirt would automatically add a <console> with
<console type='pty'>
<target type='serial'/>
</console>
With x86 fullvirt KVM, we also have support for virtio which is
done using
<console type='pty'>
<target type='virtio'/>
</console>
So actually this leads me to ask what kind of console Arm fullvirt Xen
guests actually have ? If they just use the traditional Xen paravirt
console, then we just need to make sure that this works for them by
default:
<console type='pty'>
<target type='xen'/>
</console>
If there's a different type of console device that's not related to
the Xen paravirt console device, then we'd need to invent a new
<target type='xxx'/> value for Arm.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <20140228110329.GB17909@redhat.com>
@ 2014-02-28 14:29 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1402281428470.31489@kaball.uk.xensource.com>
1 sibling, 0 replies; 11+ messages in thread
From: Stefano Stabellini @ 2014-02-28 14:29 UTC (permalink / raw)
To: Daniel P. Berrange
Cc: Olaf Hering, Ian Campbell, stefano.stabellini, libvir-list,
julien.grall, tim, xen-devel, Jim Fehlig
On Fri, 28 Feb 2014, Daniel P. Berrange wrote:
> On Fri, Feb 28, 2014 at 02:12:30AM +0000, Ian Campbell wrote:
> > On Wed, 2014-02-26 at 15:01 +0000, Daniel P. Berrange wrote:
> > > Yep, if ARM has a PV console, then we'd need to add tiny bit to the XML
> > > to allow us to configure that explicitly, similar to how we do for KVM's
> > > virtio-console support.
> >
> > Do you mean I need to add something to the XML config snippet, or I need
> > to add some special handling in the XML parser/consumer?
> >
> > I've grepped around the virtio-console stuff and I'm none the wiser.
>
> Opps, yes, I should have explained this better, since our docs here are
> about as clear as mud.
>
> With traditional x86 paravirt Xen, we just have the plain paravirt console
> devices
>
> <console type='pty'>
> <target type='xen'/>
> </console>
>
> With x86 fullvirt Xen/KVM/QEMU, the console type just defaults to being
> a serial port so you would usually just add
>
> <serial type='pty'>
> </serial>
>
> and then libvirt would automatically add a <console> with
>
> <console type='pty'>
> <target type='serial'/>
> </console>
>
>
> With x86 fullvirt KVM, we also have support for virtio which is
> done using
>
> <console type='pty'>
> <target type='virtio'/>
> </console>
>
>
> So actually this leads me to ask what kind of console Arm fullvirt Xen
> guests actually have ? If they just use the traditional Xen paravirt
> console, then we just need to make sure that this works for them by
> default:
>
> <console type='pty'>
> <target type='xen'/>
> </console>
>
>
> If there's a different type of console device that's not related to
> the Xen paravirt console device, then we'd need to invent a new
> <target type='xxx'/> value for Arm.
It is just the traditional Xen paravirt console.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures
[not found] ` <alpine.DEB.2.02.1402281428470.31489@kaball.uk.xensource.com>
@ 2014-02-28 15:55 ` Ian Campbell
0 siblings, 0 replies; 11+ messages in thread
From: Ian Campbell @ 2014-02-28 15:55 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Olaf Hering, Daniel P. Berrange, libvir-list, julien.grall, tim,
xen-devel, Jim Fehlig
On Fri, 2014-02-28 at 14:29 +0000, Stefano Stabellini wrote:
> On Fri, 28 Feb 2014, Daniel P. Berrange wrote:
> > So actually this leads me to ask what kind of console Arm fullvirt Xen
> > guests actually have ? If they just use the traditional Xen paravirt
> > console, then we just need to make sure that this works for them by
> > default:
> >
> > <console type='pty'>
> > <target type='xen'/>
> > </console>
> >
> >
> > If there's a different type of console device that's not related to
> > the Xen paravirt console device, then we'd need to invent a new
> > <target type='xxx'/> value for Arm.
>
> It is just the traditional Xen paravirt console.
I tried the above,which AIUI should work, but it fails with the same
"cannot find character device <null>" error. I'll investigate properly
next week.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-02-28 15:55 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1393418058-14113-1-git-send-email-ian.campbell@citrix.com>
2014-02-26 12:37 ` [libvirt] [PATCH LIBVIRT] libxl: Recognise ARM architectures Daniel P. Berrange
[not found] ` <20140226123703.GC29185@redhat.com>
2014-02-26 12:42 ` Ian Campbell
2014-02-26 13:34 ` Eric Blake
[not found] ` <1393418554.18730.41.camel@kazak.uk.xensource.com>
2014-02-26 14:00 ` Olaf Hering
2014-02-26 14:55 ` Ian Campbell
2014-02-26 15:01 ` Daniel P. Berrange
[not found] ` <20140226150100.GC6046@redhat.com>
2014-02-28 2:12 ` Ian Campbell
2014-02-28 11:03 ` Daniel P. Berrange
[not found] ` <20140228110329.GB17909@redhat.com>
2014-02-28 14:29 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1402281428470.31489@kaball.uk.xensource.com>
2014-02-28 15:55 ` Ian Campbell
[not found] ` <530DED71.4020604@redhat.com>
2014-02-26 15:28 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.