* [Buildroot] [PATCH] lzip: new package
@ 2014-02-28 14:54 Gustavo Zacarias
2014-03-01 13:46 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2014-02-28 14:54 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/Config.in | 1 +
package/lzip/Config.in | 15 +++++++++++++++
package/lzip/lzip.mk | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 64 insertions(+)
create mode 100644 package/lzip/Config.in
create mode 100644 package/lzip/lzip.mk
diff --git a/package/Config.in b/package/Config.in
index e87d409..71dbf71 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -35,6 +35,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/gzip/Config.in"
endif
source "package/infozip/Config.in"
+source "package/lzip/Config.in"
source "package/lzop/Config.in"
source "package/xz/Config.in"
endmenu
diff --git a/package/lzip/Config.in b/package/lzip/Config.in
new file mode 100644
index 0000000..b72ac78
--- /dev/null
+++ b/package/lzip/Config.in
@@ -0,0 +1,15 @@
+comment "lzip needs a toolchain w/ C++, largefile"
+ depends on !(BR2_INSTALL_LIBSTDCPP && BR2_LARGEFILE)
+
+config BR2_PACKAGE_LZIP
+ bool "lzip"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_LARGEFILE
+ help
+ Lzip is a lossless data compressor with a user interface similar
+ to the one of gzip or bzip2.
+ Lzip is about as fast as gzip, compresses most files more than
+ bzip2, and is better than both from a data recovery perspective.
+ Lzip is a clean implementation of the LZMA algorithm.
+
+ http://savannah.nongnu.org/projects/lzip
diff --git a/package/lzip/lzip.mk b/package/lzip/lzip.mk
new file mode 100644
index 0000000..ed6975b
--- /dev/null
+++ b/package/lzip/lzip.mk
@@ -0,0 +1,48 @@
+################################################################################
+#
+# lzip
+#
+################################################################################
+
+LZIP_VERSION = 1.15
+LZIP_SITE = http://download.savannah.gnu.org/releases/lzip/
+LZIP_LICENSE = GPLv3+
+LZIP_LICENSE_FILES = COPYING
+
+define LZIP_CONFIGURE_CMDS
+ (cd $(@D); ./configure \
+ CXX="$(TARGET_CXX)" \
+ CPPFLAGS="$(TARGET_CPPFLAGS)" \
+ CXXFLAGS="$(TARGET_CXXFLAGS)" \
+ LDFLAGS="$(TARGET_LDFLAGS)" \
+ --prefix=/usr )
+
+endef
+
+define HOST_LZIP_CONFIGURE_CMDS
+ (cd $(@D); ./configure \
+ CXX="$(HOSTCXX)" \
+ CPPFLAGS="$(HOST_CPPFLAGS)" \
+ CXXFLAGS="$(HOST_CXXFLAGS)" \
+ LDFLAGS="$(HOST_LDFLAGS)" \
+ --prefix=/usr )
+endef
+
+define LZIP_BUILD_CMDS
+ $(MAKE) -C $(@D)
+endef
+
+define HOST_LZIP_BUILD_CMDS
+ $(MAKE) -C $(@D)
+endef
+
+define LZIP_INSTALL_TARGET_CMDS
+ $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+endef
+
+define HOST_LZIP_INSTALL_CMDS
+ $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) install
+endef
+
+$(eval $(generic-package))
+$(eval $(host-generic-package))
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] lzip: new package
2014-02-28 14:54 [Buildroot] [PATCH] lzip: new package Gustavo Zacarias
@ 2014-03-01 13:46 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2014-03-01 13:46 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Fri, 28 Feb 2014 11:54:41 -0300, Gustavo Zacarias wrote:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Since you're adding a host variant of the package, it would be good to
have some details in the commit log as to why this is necessary.
> +define LZIP_CONFIGURE_CMDS
> + (cd $(@D); ./configure \
> + CXX="$(TARGET_CXX)" \
> + CPPFLAGS="$(TARGET_CPPFLAGS)" \
> + CXXFLAGS="$(TARGET_CXXFLAGS)" \
> + LDFLAGS="$(TARGET_LDFLAGS)" \
> + --prefix=/usr )
> +
> +endef
Useless blank line before endef.
If you're using the generic-package infra, I suppose it's because the
configure script isn't autotools-based. It would be good to mention
that in a comment before LZIP_CONFIGURE_CMDS.
Also, what about using TARGET_CONFIGURE_OPTS / HOST_CONFIGURE_OPTS
instead of passing CXX, CPPFLAGS, CXXFLAGS and LDFLAGS ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-01 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-28 14:54 [Buildroot] [PATCH] lzip: new package Gustavo Zacarias
2014-03-01 13:46 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.