From: Philipp Zabel <p.zabel@pengutronix.de> To: Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Philipp Zabel <p.zabel@pengutronix.de>, David Airlie <airlied@linux.ie>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, dri-devel@lists.freedesktop.org, kernel@pengutronix.de, Grant Likely <grant.likely@linaro.org>, Shawn Guo <shawn.guo@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 02/11] staging: imx-drm-core: use of_graph_parse_endpoint Date: Wed, 5 Mar 2014 10:20:53 +0100 [thread overview] Message-ID: <1394011262-16849-3-git-send-email-p.zabel@pengutronix.de> (raw) In-Reply-To: <1394011262-16849-1-git-send-email-p.zabel@pengutronix.de> Using of_graph_parse_endpoint recovers the port id from an endpoint device tree node. This just replaces an open coded read of the "reg" property. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/staging/imx-drm/imx-drm-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index ecfc88b..4144a75 100644 --- a/drivers/staging/imx-drm/imx-drm-core.c +++ b/drivers/staging/imx-drm/imx-drm-core.c @@ -501,8 +501,9 @@ int imx_drm_encoder_get_mux_id(struct device_node *node, { struct imx_drm_crtc *imx_crtc = imx_drm_find_crtc(encoder->crtc); struct device_node *ep = NULL; + struct of_endpoint endpoint; struct device_node *port; - int id, ret; + int ret; if (!node || !imx_crtc) return -EINVAL; @@ -515,9 +516,8 @@ int imx_drm_encoder_get_mux_id(struct device_node *node, port = of_graph_get_remote_port(ep); of_node_put(port); if (port == imx_crtc->port) { - ret = of_property_read_u32(ep->parent, "reg", &id); - of_node_put(ep); - return ret ? ret : id; + ret = of_graph_parse_endpoint(ep, &endpoint); + return ret ? ret : endpoint.id; } } while (ep); -- 1.9.0.rc3
WARNING: multiple messages have this Message-ID (diff)
From: p.zabel@pengutronix.de (Philipp Zabel) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 02/11] staging: imx-drm-core: use of_graph_parse_endpoint Date: Wed, 5 Mar 2014 10:20:53 +0100 [thread overview] Message-ID: <1394011262-16849-3-git-send-email-p.zabel@pengutronix.de> (raw) In-Reply-To: <1394011262-16849-1-git-send-email-p.zabel@pengutronix.de> Using of_graph_parse_endpoint recovers the port id from an endpoint device tree node. This just replaces an open coded read of the "reg" property. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/staging/imx-drm/imx-drm-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index ecfc88b..4144a75 100644 --- a/drivers/staging/imx-drm/imx-drm-core.c +++ b/drivers/staging/imx-drm/imx-drm-core.c @@ -501,8 +501,9 @@ int imx_drm_encoder_get_mux_id(struct device_node *node, { struct imx_drm_crtc *imx_crtc = imx_drm_find_crtc(encoder->crtc); struct device_node *ep = NULL; + struct of_endpoint endpoint; struct device_node *port; - int id, ret; + int ret; if (!node || !imx_crtc) return -EINVAL; @@ -515,9 +516,8 @@ int imx_drm_encoder_get_mux_id(struct device_node *node, port = of_graph_get_remote_port(ep); of_node_put(port); if (port == imx_crtc->port) { - ret = of_property_read_u32(ep->parent, "reg", &id); - of_node_put(ep); - return ret ? ret : id; + ret = of_graph_parse_endpoint(ep, &endpoint); + return ret ? ret : endpoint.id; } } while (ep); -- 1.9.0.rc3
next prev parent reply other threads:[~2014-03-05 9:20 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-03-05 9:20 [PATCH v5 00/11] imx-drm dt bindings Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 9:20 ` [PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 10:05 ` Russell King - ARM Linux 2014-03-05 10:05 ` Russell King - ARM Linux 2014-03-05 14:25 ` Philipp Zabel 2014-03-05 14:25 ` Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel [this message] 2014-03-05 9:20 ` [PATCH v5 02/11] staging: imx-drm-core: use of_graph_parse_endpoint Philipp Zabel 2014-03-05 9:20 ` [PATCH v5 03/11] staging: imx-drm: Document updated imx-drm device tree bindings Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 9:20 ` [PATCH v5 04/11] staging: imx-drm: Document imx-hdmi " Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 9:20 ` [PATCH v5 05/11] imx-drm: imx-hdmi: Fix DDC I2C bus property Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 9:20 ` [PATCH v5 07/11] ARM: dts: imx53-mba53: Fix TVE " Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 9:20 ` [PATCH v5 08/11] ARM: dts: imx51: Add IPU ports and endpoints, move imx-drm node to dtsi Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-05 9:21 ` [PATCH v5 10/11] ARM: dts: imx6qdl: Add IPU DI " Philipp Zabel 2014-03-05 9:21 ` Philipp Zabel 2014-03-05 9:21 ` [PATCH v5 11/11] staging: imx-drm: Update TODO Philipp Zabel 2014-03-05 9:21 ` Philipp Zabel 2014-03-07 17:56 ` [PATCH v5 00/11] imx-drm dt bindings Russell King - ARM Linux 2014-03-07 17:56 ` Russell King - ARM Linux 2014-03-07 18:28 ` Greg Kroah-Hartman 2014-03-07 18:28 ` Greg Kroah-Hartman 2014-03-07 18:57 ` Philipp Zabel 2014-03-07 18:57 ` Philipp Zabel 2014-03-07 19:17 ` Russell King - ARM Linux 2014-03-07 19:17 ` Russell King - ARM Linux [not found] ` <1394011262-16849-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2014-03-05 9:20 ` [PATCH v5 06/11] imx-drm: imx-tve: Fix DDC I2C bus property Philipp Zabel 2014-03-05 9:20 ` Philipp Zabel 2014-03-06 13:03 ` Russell King - ARM Linux 2014-03-06 13:03 ` Russell King - ARM Linux 2014-03-06 13:32 ` Philipp Zabel 2014-03-06 13:32 ` Philipp Zabel 2014-03-05 9:21 ` [PATCH v5 09/11] ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi Philipp Zabel 2014-03-05 9:21 ` Philipp Zabel 2014-03-11 3:46 ` [PATCH v5 00/11] imx-drm dt bindings Shawn Guo 2014-03-11 3:46 ` Shawn Guo 2014-03-11 11:42 ` Philipp Zabel 2014-03-11 11:42 ` Philipp Zabel 2014-03-11 13:27 ` Shawn Guo 2014-03-11 13:27 ` Shawn Guo 2014-03-11 13:34 ` Lucas Stach 2014-03-11 13:34 ` Lucas Stach [not found] ` <1394544878.4339.7.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org> 2014-03-11 14:14 ` Shawn Guo 2014-03-11 14:14 ` Shawn Guo [not found] ` <20140311034607.GA26502-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> 2014-04-07 4:23 ` Shawn Guo 2014-04-07 4:23 ` Shawn Guo 2014-04-07 9:09 ` Russell King - ARM Linux 2014-04-07 9:09 ` Russell King - ARM Linux 2014-04-07 13:40 ` Shawn Guo 2014-04-07 13:40 ` Shawn Guo 2014-04-07 10:05 ` Philipp Zabel 2014-04-07 10:05 ` Philipp Zabel 2014-04-07 12:34 ` Philipp Zabel 2014-04-07 12:34 ` Philipp Zabel 2014-04-07 13:43 ` Shawn Guo 2014-04-07 13:43 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1394011262-16849-3-git-send-email-p.zabel@pengutronix.de \ --to=p.zabel@pengutronix.de \ --cc=airlied@linux.ie \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux@arm.linux.org.uk \ --cc=shawn.guo@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.