From: Ian Campbell <Ian.Campbell@citrix.com>
To: Matt Wilson <msw@linux.com>
Cc: Charles Arnold <carnold@suse.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Matt Wilson <msw@amazon.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: Support for btrfs in pv-grub
Date: Tue, 11 Mar 2014 10:58:31 +0000 [thread overview]
Message-ID: <1394535511.18366.35.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <20140228033029.GA14114@u109add4315675089e695.ant.amazon.com>
On Thu, 2014-02-27 at 19:30 -0800, Matt Wilson wrote:
> On Fri, Feb 28, 2014 at 02:42:28AM +0000, Ian Campbell wrote:
> > On Wed, 2014-02-26 at 15:59 -0700, Charles Arnold wrote:
> > > Code to support btrfs in pv-grub was added almost two years ago (c/s 25154).
> >
> > Ccing the author.
> >
> > > Building the code doesn't seem to be enabled in stubdom/grub/Makefile.
> > > Was this functionality ever intended to work?
> >
> > One would like to assume so!
> >
> > > Does anyone know the status of this code?
> >
> > Matt?
> >
> > Looks like Makefile.am was patched but not Makefile.in, and I don't
> > think we run automake as part of the stubdom build process.
>
> True, but we also don't use the Makefiles in grub-upstream to build
> GRUB. We use xen/stubdom/grub/Makefile, which also isn't patched to
> build the btrfs code.
So this code was untested when it was submitted and you aren't using it
today?
> Unfortunately when I added it grub/Makefile, it doesn't build on a
> modern compiler.
>
> Do you think we should revert the patch that adds btrfs support?
Unless someone is going to fix it up up as Charles suggests then it
seems misleading to keep it in the code base.
Ian.
prev parent reply other threads:[~2014-03-11 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 22:59 Support for btrfs in pv-grub Charles Arnold
2014-02-28 2:42 ` Ian Campbell
2014-02-28 3:30 ` Matt Wilson
2014-02-28 15:24 ` Charles Arnold
2014-03-11 10:58 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394535511.18366.35.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=carnold@suse.com \
--cc=msw@amazon.com \
--cc=msw@linux.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.