* [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ
@ 2014-03-14 10:13 ` Robert Baldyga
0 siblings, 0 replies; 4+ messages in thread
From: Robert Baldyga @ 2014-03-14 10:13 UTC (permalink / raw)
To: ben-linux, kgene.kim
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
m.szyprowski, t.figa, Robert Baldyga
This patch adds device tree node for IRQ used by max8997.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
arch/arm/boot/dts/exynos4210-trats.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 1d18428..0e1fc19 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -148,6 +148,14 @@
};
};
+ pinctrl@11000000 {
+ max8997_irq: max8997-irq {
+ samsung,pins = "gpx0-7";
+ samsung,pin-pud = <3>;
+ samsung,pin-drv = <0>;
+ };
+ };
+
i2c@13890000 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
@@ -179,6 +187,11 @@
max8997_pmic@66 {
compatible = "maxim,max8997-pmic";
+ pinctrl-0 = <&max8997_irq>;
+ pinctrl-names = "default";
+
+ interrupt-parent = <&gpx0>;
+ interrupts = <7 0>;
reg = <0x66>;
max8997,pmic-buck1-uses-gpio-dvs;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ
@ 2014-03-14 10:13 ` Robert Baldyga
0 siblings, 0 replies; 4+ messages in thread
From: Robert Baldyga @ 2014-03-14 10:13 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds device tree node for IRQ used by max8997.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
arch/arm/boot/dts/exynos4210-trats.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 1d18428..0e1fc19 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -148,6 +148,14 @@
};
};
+ pinctrl at 11000000 {
+ max8997_irq: max8997-irq {
+ samsung,pins = "gpx0-7";
+ samsung,pin-pud = <3>;
+ samsung,pin-drv = <0>;
+ };
+ };
+
i2c at 13890000 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
@@ -179,6 +187,11 @@
max8997_pmic at 66 {
compatible = "maxim,max8997-pmic";
+ pinctrl-0 = <&max8997_irq>;
+ pinctrl-names = "default";
+
+ interrupt-parent = <&gpx0>;
+ interrupts = <7 0>;
reg = <0x66>;
max8997,pmic-buck1-uses-gpio-dvs;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ
2014-03-14 10:13 ` Robert Baldyga
@ 2014-03-14 17:23 ` Tomasz Figa
-1 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-03-14 17:23 UTC (permalink / raw)
To: Robert Baldyga, ben-linux, kgene.kim
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
m.szyprowski
Hi Robert,
On 14.03.2014 11:13, Robert Baldyga wrote:
> This patch adds device tree node for IRQ used by max8997.
>
Generally, this patch does not add just a node, but rather "IRQ line
specification for the MAX8997 PMIC chip and necessary pinctrl group to
configure pull-up and driver strength of the pin".
Also it would be nice to mention a reason for this change, e.g. what can
be achieved after applying this patch.
Otherwise looks good.
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index 1d18428..0e1fc19 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -148,6 +148,14 @@
> };
> };
>
> + pinctrl@11000000 {
> + max8997_irq: max8997-irq {
> + samsung,pins = "gpx0-7";
> + samsung,pin-pud = <3>;
> + samsung,pin-drv = <0>;
> + };
> + };
> +
> i2c@13890000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-slave-addr = <0x10>;
> @@ -179,6 +187,11 @@
> max8997_pmic@66 {
> compatible = "maxim,max8997-pmic";
>
> + pinctrl-0 = <&max8997_irq>;
> + pinctrl-names = "default";
> +
> + interrupt-parent = <&gpx0>;
> + interrupts = <7 0>;
> reg = <0x66>;
>
> max8997,pmic-buck1-uses-gpio-dvs;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ
@ 2014-03-14 17:23 ` Tomasz Figa
0 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-03-14 17:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Robert,
On 14.03.2014 11:13, Robert Baldyga wrote:
> This patch adds device tree node for IRQ used by max8997.
>
Generally, this patch does not add just a node, but rather "IRQ line
specification for the MAX8997 PMIC chip and necessary pinctrl group to
configure pull-up and driver strength of the pin".
Also it would be nice to mention a reason for this change, e.g. what can
be achieved after applying this patch.
Otherwise looks good.
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index 1d18428..0e1fc19 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -148,6 +148,14 @@
> };
> };
>
> + pinctrl at 11000000 {
> + max8997_irq: max8997-irq {
> + samsung,pins = "gpx0-7";
> + samsung,pin-pud = <3>;
> + samsung,pin-drv = <0>;
> + };
> + };
> +
> i2c at 13890000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-slave-addr = <0x10>;
> @@ -179,6 +187,11 @@
> max8997_pmic at 66 {
> compatible = "maxim,max8997-pmic";
>
> + pinctrl-0 = <&max8997_irq>;
> + pinctrl-names = "default";
> +
> + interrupt-parent = <&gpx0>;
> + interrupts = <7 0>;
> reg = <0x66>;
>
> max8997,pmic-buck1-uses-gpio-dvs;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-14 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-14 10:13 [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ Robert Baldyga
2014-03-14 10:13 ` Robert Baldyga
2014-03-14 17:23 ` Tomasz Figa
2014-03-14 17:23 ` Tomasz Figa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.