All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: dri-devel@lists.freedesktop.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Grant Likely <grant.likely@linaro.org>,
	Denis Carikli <denis@eukrea.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 3/9] drm/exynos: correct timing porch conversion
Date: Mon, 17 Mar 2014 11:27:19 +0100	[thread overview]
Message-ID: <1395052045-23848-4-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1395052045-23848-1-git-send-email-a.hajda@samsung.com>

The patch corrects porch calculation. It should
be calculated as a difference between adjacent
respective fields of drm_display_mode.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index f78fbf4..10431b0 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -221,7 +221,7 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	struct drm_display_mode *mode = &ctx->mode;
 	struct fimd_driver_data *driver_data;
 	u32 val, clkdiv, vidcon1;
-	int hblank, vblank, vsync_len, vbpd, vfpd, hsync_len, hbpd, hfpd;
+	int vsync_len, vbpd, vfpd, hsync_len, hbpd, hfpd;
 
 	driver_data = ctx->driver_data;
 	if (ctx->suspended)
@@ -240,10 +240,9 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	writel(vidcon1, ctx->regs + driver_data->timing_base + VIDCON1);
 
 	/* setup vertical timing values. */
-	vblank = mode->crtc_vblank_end - mode->crtc_vblank_start;
 	vsync_len = mode->crtc_vsync_end - mode->crtc_vsync_start;
-	vbpd = (vblank - vsync_len) / 2;
-	vfpd = vblank - vsync_len - vbpd;
+	vbpd = mode->crtc_vtotal - mode->crtc_vsync_end;
+	vfpd = mode->crtc_vsync_start - mode->crtc_vdisplay;
 
 	val = VIDTCON0_VBPD(vbpd - 1) |
 		VIDTCON0_VFPD(vfpd - 1) |
@@ -251,10 +250,9 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	writel(val, ctx->regs + driver_data->timing_base + VIDTCON0);
 
 	/* setup horizontal timing values.  */
-	hblank = mode->crtc_hblank_end - mode->crtc_hblank_start;
 	hsync_len = mode->crtc_hsync_end - mode->crtc_hsync_start;
-	hbpd = (hblank - hsync_len) / 2;
-	hfpd = hblank - hsync_len - hbpd;
+	hbpd = mode->crtc_htotal - mode->crtc_hsync_end;
+	hfpd = mode->crtc_hsync_start - mode->crtc_hdisplay;
 
 	val = VIDTCON1_HBPD(hbpd - 1) |
 		VIDTCON1_HFPD(hfpd - 1) |
-- 
1.8.3.2

  parent reply	other threads:[~2014-03-17 10:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
2014-03-17 10:27 ` [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected Andrzej Hajda
2014-03-17 10:27 ` [PATCH 2/9] drm/exynos: init kms poll after creation of connectors Andrzej Hajda
2014-03-17 10:27 ` Andrzej Hajda [this message]
2014-03-17 10:27 ` [PATCH 4/9] exynos/fimd: add parallel output related bindings Andrzej Hajda
2014-03-17 10:27 ` [PATCH 5/9] drm/exynos: restore parallel output interface support Andrzej Hajda
2014-03-17 12:03   ` [PATCH v2 " Andrzej Hajda
2014-03-17 10:27 ` [PATCH 6/9] ARM: dts: exynos4210-universal: add exynos/fimd node Andrzej Hajda
2014-03-17 10:27 ` [PATCH 7/9] drm/modes: add polarization handling to mode conversion Andrzej Hajda
2014-03-17 10:27 ` [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode Andrzej Hajda
2014-03-20  6:03   ` Inki Dae
2014-03-20  7:01     ` Andrzej Hajda
2014-03-20 13:26     ` [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings Andrzej Hajda
2014-03-21  5:36       ` Inki Dae
     [not found] ` <1395052045-23848-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-17 10:27   ` [PATCH 9/9] drm/exynos/fimd: remove unused variable Andrzej Hajda
2014-03-17 13:16     ` [PATCH v2 " Andrzej Hajda
2014-03-18 13:05 ` [PATCH 0/9] Restore parallel display support for Exynos based boards Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395052045-23848-4-git-send-email-a.hajda@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=denis@eukrea.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.