From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
broonie@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01
Date: Wed, 19 Mar 2014 13:41:59 +0100 [thread overview]
Message-ID: <1395232919.15174.7.camel@AMDC1943> (raw)
In-Reply-To: <20140319091404.GF31687@lee--X1>
On Wed, 2014-03-19 at 09:14 +0000, Lee Jones wrote:
> > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least
> > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because
> > rtc-s5m driver does not support S2MPA01.
> >
> > This fixes following error:
> > drivers/mfd/sec-core.c:342:45: warning: ‘regmap_rtc’ may be used uninitialized in this function [-Wuninitialized]
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/mfd/sec-core.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
>
> Please don't send patches in the middle of threads like this (v2's are
> a different story as it saves on re-sending entire patch-sets), as I
> very nearly missed it.
OK, I understand. I put it in the middle because it was a follow up of
your immutable branch ib-mfd-regulator-3.15 (merging mine S2MPS14 and
Sachin's S2MPA01).
>
> We already have drivers doing similar things so I'll apply this as a
> temporary fix, but please find something a little less 'hacky' to
> supersede it _soon_.
Sure, I just sent a patch for it.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Sachin Kamat
<sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01
Date: Wed, 19 Mar 2014 13:41:59 +0100 [thread overview]
Message-ID: <1395232919.15174.7.camel@AMDC1943> (raw)
In-Reply-To: <20140319091404.GF31687@lee--X1>
On Wed, 2014-03-19 at 09:14 +0000, Lee Jones wrote:
> > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least
> > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because
> > rtc-s5m driver does not support S2MPA01.
> >
> > This fixes following error:
> > drivers/mfd/sec-core.c:342:45: warning: ‘regmap_rtc’ may be used uninitialized in this function [-Wuninitialized]
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> > drivers/mfd/sec-core.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
>
> Please don't send patches in the middle of threads like this (v2's are
> a different story as it saves on re-sending entire patch-sets), as I
> very nearly missed it.
OK, I understand. I put it in the middle because it was a follow up of
your immutable branch ib-mfd-regulator-3.15 (merging mine S2MPS14 and
Sachin's S2MPA01).
>
> We already have drivers doing similar things so I'll apply this as a
> temporary fix, but please find something a little less 'hacky' to
> supersede it _soon_.
Sure, I just sent a patch for it.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-19 12:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 11:51 [PATCH v4 1/3] mfd: Add support for S2MPA01 device Sachin Kamat
2014-03-14 11:51 ` [PATCH v4 2/3] regulator: Add support for S2MPA01 regulator Sachin Kamat
2014-03-14 11:51 ` Sachin Kamat
2014-03-18 9:12 ` Lee Jones
2014-03-14 11:51 ` [PATCH v4 3/3] Documentation: mfd: Add binding document for S2MPA01 Sachin Kamat
2014-03-18 9:13 ` Lee Jones
2014-03-18 9:11 ` [PATCH v4 1/3] mfd: Add support for S2MPA01 device Lee Jones
2014-03-18 9:11 ` Lee Jones
2014-03-18 11:09 ` [GIT PULL] mfd: regulator: S2MPA01 device support IB for Mark Brown Lee Jones
2014-03-18 11:09 ` Lee Jones
2014-03-18 13:10 ` Krzysztof Kozlowski
2014-03-18 13:10 ` Krzysztof Kozlowski
2014-03-18 13:11 ` [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01 Krzysztof Kozlowski
2014-03-19 8:27 ` Sachin Kamat
2014-03-19 8:41 ` Krzysztof Kozlowski
2014-04-06 13:23 ` Geert Uytterhoeven
2014-04-06 13:23 ` Geert Uytterhoeven
2014-03-19 9:14 ` Lee Jones
2014-03-19 9:14 ` Lee Jones
2014-03-19 12:41 ` Krzysztof Kozlowski [this message]
2014-03-19 12:41 ` Krzysztof Kozlowski
2014-03-19 12:55 ` [GIT PULL] mfd: regulator: S2MPA01 device support IB for Mark Brown Mark Brown
2014-03-19 13:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395232919.15174.7.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.