* [PATCH 0/3] Add DTS node for FTM PWM
@ 2014-03-20 5:12 ` Xiubo Li
0 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
Hi Shawn,
The FTM PWM driver has been applied by the Maintainer, so here I resend
this patches based upon git://git.linaro.org/people/shawnguo/linux-2.6.git
newest reporsitory.
Xiubo Li (3):
ARM: dts: vf610: Add Freescale FTM PWM node. ==> resend v10
ARM: dts: vf610-twr: Add PWM0's pinctrl node ==> new
ARM: dts: vf610-twr: Enables FTM PWM device. ==> resend v10
arch/arm/boot/dts/vf610-twr.dts | 17 +++++++++++++++++
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
2 files changed, 30 insertions(+)
--
1.8.4
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 0/3] Add DTS node for FTM PWM
@ 2014-03-20 5:12 ` Xiubo Li
0 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
Hi Shawn,
The FTM PWM driver has been applied by the Maintainer, so here I resend
this patches based upon git://git.linaro.org/people/shawnguo/linux-2.6.git
newest reporsitory.
Xiubo Li (3):
ARM: dts: vf610: Add Freescale FTM PWM node. ==> resend v10
ARM: dts: vf610-twr: Add PWM0's pinctrl node ==> new
ARM: dts: vf610-twr: Enables FTM PWM device. ==> resend v10
arch/arm/boot/dts/vf610-twr.dts | 17 +++++++++++++++++
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
2 files changed, 30 insertions(+)
--
1.8.4
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
2014-03-20 5:12 ` Xiubo Li
@ 2014-03-20 5:12 ` Xiubo Li
-1 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
This adds devicetree node for VF610, and there are 8 channels
supported.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
---
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index acf544e..ccc6d35 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -192,6 +192,19 @@
status = "disabled";
};
+ pwm0: pwm@40038000 {
+ compatible = "fsl,vf610-ftm-pwm";
+ #pwm-cells = <3>;
+ reg = <0x40038000 0x1000>;
+ clock-names = "ftm_sys", "ftm_ext",
+ "ftm_fix", "ftm_cnt_clk_en";
+ clocks = <&clks VF610_CLK_FTM0>,
+ <&clks VF610_CLK_FTM0_EXT_SEL>,
+ <&clks VF610_CLK_FTM0_FIX_SEL>,
+ <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
+ status = "disabled";
+ };
+
wdog@4003e000 {
compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
reg = <0x4003e000 0x1000>;
--
1.8.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
@ 2014-03-20 5:12 ` Xiubo Li
0 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
This adds devicetree node for VF610, and there are 8 channels
supported.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
---
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index acf544e..ccc6d35 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -192,6 +192,19 @@
status = "disabled";
};
+ pwm0: pwm@40038000 {
+ compatible = "fsl,vf610-ftm-pwm";
+ #pwm-cells = <3>;
+ reg = <0x40038000 0x1000>;
+ clock-names = "ftm_sys", "ftm_ext",
+ "ftm_fix", "ftm_cnt_clk_en";
+ clocks = <&clks VF610_CLK_FTM0>,
+ <&clks VF610_CLK_FTM0_EXT_SEL>,
+ <&clks VF610_CLK_FTM0_FIX_SEL>,
+ <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
+ status = "disabled";
+ };
+
wdog@4003e000 {
compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
reg = <0x4003e000 0x1000>;
--
1.8.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
2014-03-20 5:12 ` Xiubo Li
@ 2014-03-20 5:12 ` Xiubo Li
-1 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index f3af8ea..3fabdb5 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -213,6 +213,17 @@
>;
};
+ pinctrl_pwm0: pwm0grp {
+ fsl,pins = <
+ VF610_PAD_PTB0__FTM0_CH0 0x1582
+ VF610_PAD_PTB1__FTM0_CH1 0x1582
+ VF610_PAD_PTB2__FTM0_CH2 0x1582
+ VF610_PAD_PTB3__FTM0_CH3 0x1582
+ VF610_PAD_PTB6__FTM0_CH6 0x1582
+ VF610_PAD_PTB7__FTM0_CH7 0x1582
+ >;
+ };
+
pinctrl_sai2: sai2grp {
fsl,pins = <
VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
--
1.8.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-20 5:12 ` Xiubo Li
0 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index f3af8ea..3fabdb5 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -213,6 +213,17 @@
>;
};
+ pinctrl_pwm0: pwm0grp {
+ fsl,pins = <
+ VF610_PAD_PTB0__FTM0_CH0 0x1582
+ VF610_PAD_PTB1__FTM0_CH1 0x1582
+ VF610_PAD_PTB2__FTM0_CH2 0x1582
+ VF610_PAD_PTB3__FTM0_CH3 0x1582
+ VF610_PAD_PTB6__FTM0_CH6 0x1582
+ VF610_PAD_PTB7__FTM0_CH7 0x1582
+ >;
+ };
+
pinctrl_sai2: sai2grp {
fsl,pins = <
VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
--
1.8.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 3/3] ARM: dts: vf610-twr: Enables FTM PWM device.
2014-03-20 5:12 ` Xiubo Li
@ 2014-03-20 5:12 ` Xiubo Li
-1 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index 3fabdb5..c016ec8 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -245,6 +245,12 @@
};
};
+&pwm0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0>;
+ status = "okay";
+};
+
&sai2 {
#sound-dai-cells = <0>;
pinctrl-names = "default";
--
1.8.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 3/3] ARM: dts: vf610-twr: Enables FTM PWM device.
@ 2014-03-20 5:12 ` Xiubo Li
0 siblings, 0 replies; 18+ messages in thread
From: Xiubo Li @ 2014-03-20 5:12 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-kernel, Xiubo Li
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index 3fabdb5..c016ec8 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -245,6 +245,12 @@
};
};
+&pwm0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0>;
+ status = "okay";
+};
+
&sai2 {
#sound-dai-cells = <0>;
pinctrl-names = "default";
--
1.8.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
@ 2014-03-24 2:45 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2014-03-24 2:45 UTC (permalink / raw)
To: Xiubo Li; +Cc: devicetree, linux-kernel
On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> This adds devicetree node for VF610, and there are 8 channels
> supported.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
changes, and also be noted that my email and git addresses just got
updated [1].
> ---
> arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index acf544e..ccc6d35 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -192,6 +192,19 @@
> status = "disabled";
> };
>
> + pwm0: pwm@40038000 {
The node should be sorted in unit-address. So shouldn't it be put right
after pit node?
Shawn
[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c12837220c54c8d7138a4ee4a08c1ec67b68a2
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x40038000 0x1000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clks VF610_CLK_FTM0>,
> + <&clks VF610_CLK_FTM0_EXT_SEL>,
> + <&clks VF610_CLK_FTM0_FIX_SEL>,
> + <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> + status = "disabled";
> + };
> +
> wdog@4003e000 {
> compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> reg = <0x4003e000 0x1000>;
> --
> 1.8.4
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
@ 2014-03-24 2:45 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2014-03-24 2:45 UTC (permalink / raw)
To: Xiubo Li
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> This adds devicetree node for VF610, and there are 8 channels
> supported.
>
> Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Reviewed-by: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
changes, and also be noted that my email and git addresses just got
updated [1].
> ---
> arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index acf544e..ccc6d35 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -192,6 +192,19 @@
> status = "disabled";
> };
>
> + pwm0: pwm@40038000 {
The node should be sorted in unit-address. So shouldn't it be put right
after pit node?
Shawn
[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c12837220c54c8d7138a4ee4a08c1ec67b68a2
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x40038000 0x1000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clks VF610_CLK_FTM0>,
> + <&clks VF610_CLK_FTM0_EXT_SEL>,
> + <&clks VF610_CLK_FTM0_FIX_SEL>,
> + <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> + status = "disabled";
> + };
> +
> wdog@4003e000 {
> compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> reg = <0x4003e000 0x1000>;
> --
> 1.8.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-24 2:48 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2014-03-24 2:48 UTC (permalink / raw)
To: Xiubo Li; +Cc: devicetree, linux-kernel
On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Patch #2 and #3 can be reasonably merged into one.
Shawn
> ---
> arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index f3af8ea..3fabdb5 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -213,6 +213,17 @@
> >;
> };
>
> + pinctrl_pwm0: pwm0grp {
> + fsl,pins = <
> + VF610_PAD_PTB0__FTM0_CH0 0x1582
> + VF610_PAD_PTB1__FTM0_CH1 0x1582
> + VF610_PAD_PTB2__FTM0_CH2 0x1582
> + VF610_PAD_PTB3__FTM0_CH3 0x1582
> + VF610_PAD_PTB6__FTM0_CH6 0x1582
> + VF610_PAD_PTB7__FTM0_CH7 0x1582
> + >;
> + };
> +
> pinctrl_sai2: sai2grp {
> fsl,pins = <
> VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
> --
> 1.8.4
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-24 2:48 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2014-03-24 2:48 UTC (permalink / raw)
To: Xiubo Li
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Patch #2 and #3 can be reasonably merged into one.
Shawn
> ---
> arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index f3af8ea..3fabdb5 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -213,6 +213,17 @@
> >;
> };
>
> + pinctrl_pwm0: pwm0grp {
> + fsl,pins = <
> + VF610_PAD_PTB0__FTM0_CH0 0x1582
> + VF610_PAD_PTB1__FTM0_CH1 0x1582
> + VF610_PAD_PTB2__FTM0_CH2 0x1582
> + VF610_PAD_PTB3__FTM0_CH3 0x1582
> + VF610_PAD_PTB6__FTM0_CH6 0x1582
> + VF610_PAD_PTB7__FTM0_CH7 0x1582
> + >;
> + };
> +
> pinctrl_sai2: sai2grp {
> fsl,pins = <
> VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
> --
> 1.8.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
2014-03-24 2:48 ` Shawn Guo
@ 2014-03-24 2:52 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
-1 siblings, 0 replies; 18+ messages in thread
From: Li.Xiubo @ 2014-03-24 2:52 UTC (permalink / raw)
To: Shawn Guo; +Cc: devicetree, linux-kernel
> Subject: Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
>
> On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote:
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
>
> Patch #2 and #3 can be reasonably merged into one.
>
Yes, they are.
But the Patch #2 is a new one, not reviewed by Sascha Hauer and Yao Yuan.
I'm not sure could it be merged with Patch #3 ? Or just split them into
Two patches like this ?
Thanks,
BRs
Xiubo
> Shawn
>
> > ---
> > arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-
> twr.dts
> > index f3af8ea..3fabdb5 100644
> > --- a/arch/arm/boot/dts/vf610-twr.dts
> > +++ b/arch/arm/boot/dts/vf610-twr.dts
> > @@ -213,6 +213,17 @@
> > >;
> > };
> >
> > + pinctrl_pwm0: pwm0grp {
> > + fsl,pins = <
> > + VF610_PAD_PTB0__FTM0_CH0 0x1582
> > + VF610_PAD_PTB1__FTM0_CH1 0x1582
> > + VF610_PAD_PTB2__FTM0_CH2 0x1582
> > + VF610_PAD_PTB3__FTM0_CH3 0x1582
> > + VF610_PAD_PTB6__FTM0_CH6 0x1582
> > + VF610_PAD_PTB7__FTM0_CH7 0x1582
> > + >;
> > + };
> > +
> > pinctrl_sai2: sai2grp {
> > fsl,pins = <
> > VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
> > --
> > 1.8.4
> >
> >
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-24 2:52 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
0 siblings, 0 replies; 18+ messages in thread
From: Li.Xiubo-KZfg59tc24xl57MIdRCFDg @ 2014-03-24 2:52 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
> Subject: Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
>
> On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote:
> > Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Patch #2 and #3 can be reasonably merged into one.
>
Yes, they are.
But the Patch #2 is a new one, not reviewed by Sascha Hauer and Yao Yuan.
I'm not sure could it be merged with Patch #3 ? Or just split them into
Two patches like this ?
Thanks,
BRs
Xiubo
> Shawn
>
> > ---
> > arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-
> twr.dts
> > index f3af8ea..3fabdb5 100644
> > --- a/arch/arm/boot/dts/vf610-twr.dts
> > +++ b/arch/arm/boot/dts/vf610-twr.dts
> > @@ -213,6 +213,17 @@
> > >;
> > };
> >
> > + pinctrl_pwm0: pwm0grp {
> > + fsl,pins = <
> > + VF610_PAD_PTB0__FTM0_CH0 0x1582
> > + VF610_PAD_PTB1__FTM0_CH1 0x1582
> > + VF610_PAD_PTB2__FTM0_CH2 0x1582
> > + VF610_PAD_PTB3__FTM0_CH3 0x1582
> > + VF610_PAD_PTB6__FTM0_CH6 0x1582
> > + VF610_PAD_PTB7__FTM0_CH7 0x1582
> > + >;
> > + };
> > +
> > pinctrl_sai2: sai2grp {
> > fsl,pins = <
> > VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
> > --
> > 1.8.4
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-24 2:55 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2014-03-24 2:55 UTC (permalink / raw)
To: Li.Xiubo; +Cc: devicetree, linux-kernel
On Mon, Mar 24, 2014 at 02:52:56AM +0000, Li.Xiubo@freescale.com wrote:
>
> > Subject: Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
> >
> > On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote:
> > > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> >
> > Patch #2 and #3 can be reasonably merged into one.
> >
>
> Yes, they are.
>
> But the Patch #2 is a new one, not reviewed by Sascha Hauer and Yao Yuan.
> I'm not sure could it be merged with Patch #3 ? Or just split them into
> Two patches like this ?
Okay, since you have some reason for doing that.
Shawn
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-24 2:55 ` Shawn Guo
0 siblings, 0 replies; 18+ messages in thread
From: Shawn Guo @ 2014-03-24 2:55 UTC (permalink / raw)
To: Li.Xiubo-KZfg59tc24xl57MIdRCFDg
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, Mar 24, 2014 at 02:52:56AM +0000, Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote:
>
> > Subject: Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
> >
> > On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote:
> > > Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >
> > Patch #2 and #3 can be reasonably merged into one.
> >
>
> Yes, they are.
>
> But the Patch #2 is a new one, not reviewed by Sascha Hauer and Yao Yuan.
> I'm not sure could it be merged with Patch #3 ? Or just split them into
> Two patches like this ?
Okay, since you have some reason for doing that.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
2014-03-24 2:45 ` Shawn Guo
@ 2014-03-24 2:55 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
-1 siblings, 0 replies; 18+ messages in thread
From: Li.Xiubo @ 2014-03-24 2:55 UTC (permalink / raw)
To: Shawn Guo; +Cc: devicetree, linux-kernel
> Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
>
> On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> > This adds devicetree node for VF610, and there are 8 channels
> > supported.
> >
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
>
> Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
> changes, and also be noted that my email and git addresses just got
> updated [1].
>
Okey.
> > ---
> > arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> > index acf544e..ccc6d35 100644
> > --- a/arch/arm/boot/dts/vf610.dtsi
> > +++ b/arch/arm/boot/dts/vf610.dtsi
> > @@ -192,6 +192,19 @@
> > status = "disabled";
> > };
> >
> > + pwm0: pwm@40038000 {
>
> The node should be sorted in unit-address. So shouldn't it be put right
> after pit node?
>
Yes, I will fix it.
Thanks,
BRs,
Xiubo
> Shawn
>
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c
> 12837220c54c8d7138a4ee4a08c1ec67b68a2
>
> > + compatible = "fsl,vf610-ftm-pwm";
> > + #pwm-cells = <3>;
> > + reg = <0x40038000 0x1000>;
> > + clock-names = "ftm_sys", "ftm_ext",
> > + "ftm_fix", "ftm_cnt_clk_en";
> > + clocks = <&clks VF610_CLK_FTM0>,
> > + <&clks VF610_CLK_FTM0_EXT_SEL>,
> > + <&clks VF610_CLK_FTM0_FIX_SEL>,
> > + <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> > + status = "disabled";
> > + };
> > +
> > wdog@4003e000 {
> > compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> > reg = <0x4003e000 0x1000>;
> > --
> > 1.8.4
> >
> >
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
@ 2014-03-24 2:55 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
0 siblings, 0 replies; 18+ messages in thread
From: Li.Xiubo-KZfg59tc24xl57MIdRCFDg @ 2014-03-24 2:55 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
> Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
>
> On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> > This adds devicetree node for VF610, and there are 8 channels
> > supported.
> >
> > Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Reviewed-by: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
> changes, and also be noted that my email and git addresses just got
> updated [1].
>
Okey.
> > ---
> > arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> > index acf544e..ccc6d35 100644
> > --- a/arch/arm/boot/dts/vf610.dtsi
> > +++ b/arch/arm/boot/dts/vf610.dtsi
> > @@ -192,6 +192,19 @@
> > status = "disabled";
> > };
> >
> > + pwm0: pwm@40038000 {
>
> The node should be sorted in unit-address. So shouldn't it be put right
> after pit node?
>
Yes, I will fix it.
Thanks,
BRs,
Xiubo
> Shawn
>
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c
> 12837220c54c8d7138a4ee4a08c1ec67b68a2
>
> > + compatible = "fsl,vf610-ftm-pwm";
> > + #pwm-cells = <3>;
> > + reg = <0x40038000 0x1000>;
> > + clock-names = "ftm_sys", "ftm_ext",
> > + "ftm_fix", "ftm_cnt_clk_en";
> > + clocks = <&clks VF610_CLK_FTM0>,
> > + <&clks VF610_CLK_FTM0_EXT_SEL>,
> > + <&clks VF610_CLK_FTM0_FIX_SEL>,
> > + <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> > + status = "disabled";
> > + };
> > +
> > wdog@4003e000 {
> > compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> > reg = <0x4003e000 0x1000>;
> > --
> > 1.8.4
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2014-03-24 2:55 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-20 5:12 [PATCH 0/3] Add DTS node for FTM PWM Xiubo Li
2014-03-20 5:12 ` Xiubo Li
2014-03-20 5:12 ` [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node Xiubo Li
2014-03-20 5:12 ` Xiubo Li
2014-03-24 2:45 ` Shawn Guo
2014-03-24 2:45 ` Shawn Guo
2014-03-24 2:55 ` Li.Xiubo
2014-03-24 2:55 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-03-20 5:12 ` [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node Xiubo Li
2014-03-20 5:12 ` Xiubo Li
2014-03-24 2:48 ` Shawn Guo
2014-03-24 2:48 ` Shawn Guo
2014-03-24 2:52 ` Li.Xiubo
2014-03-24 2:52 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-03-24 2:55 ` Shawn Guo
2014-03-24 2:55 ` Shawn Guo
2014-03-20 5:12 ` [PATCH 3/3] ARM: dts: vf610-twr: Enables FTM PWM device Xiubo Li
2014-03-20 5:12 ` Xiubo Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.