* [PATCH] Bluetooth: btmrvl: don't consume all vendor specific events
@ 2014-03-21 3:05 Bing Zhao
2014-03-21 3:30 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Bing Zhao @ 2014-03-21 3:05 UTC (permalink / raw)
To: linux-bluetooth
Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
Amitkumar Karwar, Bing Zhao
From: Amitkumar Karwar <akarwar@marvell.com>
If vendor specific HCI commands are received from application,
we should send corresponding events to stack.
These events should be consumed in driver, only if they are for
the internal HCI commands generated by driver.
This patch fixes the vendor command 0x3f stuck problem with
above mentioned change. For example,
hcitool cmd 3f 22 fe 06 22 21 20 43 50 00
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
---
drivers/bluetooth/btmrvl_main.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c
index 1e0320a..2c4997c 100644
--- a/drivers/bluetooth/btmrvl_main.c
+++ b/drivers/bluetooth/btmrvl_main.c
@@ -59,12 +59,13 @@ bool btmrvl_check_evtpkt(struct btmrvl_private *priv, struct sk_buff *skb)
priv->btmrvl_dev.sendcmdflag = false;
priv->adapter->cmd_complete = true;
wake_up_interruptible(&priv->adapter->cmd_wait_q);
- }
- if (hci_opcode_ogf(opcode) == 0x3F) {
- BT_DBG("vendor event skipped: opcode=%#4.4x", opcode);
- kfree_skb(skb);
- return false;
+ if (hci_opcode_ogf(opcode) == 0x3F) {
+ BT_DBG("vendor event skipped: opcode=%#4.4x",
+ opcode);
+ kfree_skb(skb);
+ return false;
+ }
}
}
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: btmrvl: don't consume all vendor specific events
2014-03-21 3:05 [PATCH] Bluetooth: btmrvl: don't consume all vendor specific events Bing Zhao
@ 2014-03-21 3:30 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2014-03-21 3:30 UTC (permalink / raw)
To: Bing Zhao
Cc: bluez mailin list (linux-bluetooth@vger.kernel.org),
Gustavo F. Padovan, Johan Hedberg, Amitkumar Karwar
Hi Bing,
> If vendor specific HCI commands are received from application,
> we should send corresponding events to stack.
> These events should be consumed in driver, only if they are for
> the internal HCI commands generated by driver.
>
> This patch fixes the vendor command 0x3f stuck problem with
> above mentioned change. For example,
>
> hcitool cmd 3f 22 fe 06 22 21 20 43 50 00
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
> drivers/bluetooth/btmrvl_main.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-21 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-21 3:05 [PATCH] Bluetooth: btmrvl: don't consume all vendor specific events Bing Zhao
2014-03-21 3:30 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.