From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <mareklindner@neomailbox.ch>,
Antonio Quartulli <antonio@meshcoding.com>
Subject: [PATCH 06/16] batman-adv: call unregister_netdev() to have it handle the locking for us
Date: Sat, 22 Mar 2014 09:56:06 +0100 [thread overview]
Message-ID: <1395478576-10999-7-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1395478576-10999-1-git-send-email-antonio@meshcoding.com>
From: Marek Lindner <mareklindner@neomailbox.ch>
Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
net/batman-adv/soft-interface.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index db3e467..633e9d6 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -652,10 +652,7 @@ static void batadv_softif_destroy_finish(struct work_struct *work)
}
batadv_sysfs_del_meshif(soft_iface);
-
- rtnl_lock();
- unregister_netdevice(soft_iface);
- rtnl_unlock();
+ unregister_netdev(soft_iface);
}
/**
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <mareklindner@neomailbox.ch>,
Antonio Quartulli <antonio@meshcoding.com>
Subject: [B.A.T.M.A.N.] [PATCH 06/16] batman-adv: call unregister_netdev() to have it handle the locking for us
Date: Sat, 22 Mar 2014 09:56:06 +0100 [thread overview]
Message-ID: <1395478576-10999-7-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1395478576-10999-1-git-send-email-antonio@meshcoding.com>
From: Marek Lindner <mareklindner@neomailbox.ch>
Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
net/batman-adv/soft-interface.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index db3e467..633e9d6 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -652,10 +652,7 @@ static void batadv_softif_destroy_finish(struct work_struct *work)
}
batadv_sysfs_del_meshif(soft_iface);
-
- rtnl_lock();
- unregister_netdevice(soft_iface);
- rtnl_unlock();
+ unregister_netdev(soft_iface);
}
/**
--
1.8.3.2
next prev parent reply other threads:[~2014-03-22 8:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 8:56 pull request: batman-adv 20140322 Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 01/16] batman-adv: fix coccinelle warnings Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 02/16] batman-adv: use vlan_/eth_hdr() instead of skb->data in interface_tx path Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 03/16] batman-adv: remove obsolete skb_reset_mac_header() in batadv_bla_tx() Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 04/16] batman-adv: prefer ether_addr_copy to memcpy Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 05/16] batman-adv: fix a few kerneldoc inconsistencies Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` Antonio Quartulli [this message]
2014-03-22 8:56 ` [B.A.T.M.A.N.] [PATCH 06/16] batman-adv: call unregister_netdev() to have it handle the locking for us Antonio Quartulli
2014-03-22 8:56 ` [PATCH 07/16] batman-adv: add kerneldoc for dst_hint argument Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 08/16] batman-adv: Multicast Listener Announcements via Translation Table Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 09/16] batman-adv: introduce capability initialization bitfield Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 10/16] batman-adv: Announce new capability via multicast TVLV Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 11/16] batman-adv: Modified forwarding behaviour for multicast packets Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 12/16] batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 13/16] batman-adv: Send multicast packets to nodes with a WANT_ALL flag Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 14/16] batman-adv: improve the TT flags documentation Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 15/16] batman-adv: improve DAT documentation Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 8:56 ` [PATCH 16/16] batman-adv: Start new development cycle Antonio Quartulli
2014-03-22 8:56 ` [B.A.T.M.A.N.] " Antonio Quartulli
2014-03-22 19:00 ` pull request: batman-adv 20140322 David Miller
2014-03-22 19:00 ` [B.A.T.M.A.N.] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395478576-10999-7-git-send-email-antonio@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.