[U-Boot] [PATCH] usb/xhci: remove XHCI init code from other usb controllers

* [U-Boot] [PATCH] usb/xhci: remove XHCI init code from other usb controllers
@ 2014-03-24  1:52 Zhao Qiang
  2014-10-22 18:56 ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Zhao Qiang @ 2014-03-24  1:52 UTC (permalink / raw)
  To: u-boot

The patch with commit id "020bbcb76b5be0d5406d2ae7c26dbdb013ead812"
adds some init codes for XHCI but not for other usb controllers.
And it will causes a bug for EHCI.
so use macro "#ifdef CONFIG_USB_XHCI" to run it just for XHCI.

Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
 common/usb_hub.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/usb_hub.c b/common/usb_hub.c
index ffac0e7..7f791f1 100644
--- a/common/usb_hub.c
+++ b/common/usb_hub.c
@@ -90,12 +90,16 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
 	int i;
 	struct usb_device *dev;
 	unsigned pgood_delay = hub->desc.bPwrOn2PwrGood * 2;
+
+#ifdef CONFIG_USB_XHCI
 	ALLOC_CACHE_ALIGN_BUFFER(struct usb_port_status, portsts, 1);
 	unsigned short portstatus;
 	int ret;
+#endif
 
 	dev = hub->pusb_dev;
 
+#ifdef CONFIG_USB_XHCI
 	/*
 	 * Enable power to the ports:
 	 * Here we Power-cycle the ports: aka,
@@ -132,6 +136,7 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
 			continue;
 		}
 	}
+#endif
 
 	for (i = 0; i < dev->maxchild; i++) {
 		usb_set_port_feature(dev, i + 1, USB_PORT_FEAT_POWER);
-- 
1.8.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread