* [PATCHv2 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
2014-03-24 2:22 ` Xiubo Li
@ 2014-03-24 2:22 ` Xiubo Li
-1 siblings, 0 replies; 13+ messages in thread
From: Xiubo Li @ 2014-03-24 2:22 UTC (permalink / raw)
To: shawn.guo-QSEj5FYQhm4dnm+yROfE0A
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Xiubo Li
This adds devicetree node for VF610, and there are 8 channels
supported.
Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Reviewed-by: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index acf544e..2a7917e 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -183,6 +183,19 @@
clock-names = "pit";
};
+ pwm0: pwm@40038000 {
+ compatible = "fsl,vf610-ftm-pwm";
+ #pwm-cells = <3>;
+ reg = <0x40038000 0x1000>;
+ clock-names = "ftm_sys", "ftm_ext",
+ "ftm_fix", "ftm_cnt_clk_en";
+ clocks = <&clks VF610_CLK_FTM0>,
+ <&clks VF610_CLK_FTM0_EXT_SEL>,
+ <&clks VF610_CLK_FTM0_FIX_SEL>,
+ <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
+ status = "disabled";
+ };
+
adc0: adc@4003b000 {
compatible = "fsl,vf610-adc";
reg = <0x4003b000 0x1000>;
--
1.8.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCHv2 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
@ 2014-03-24 2:22 ` Xiubo Li
0 siblings, 0 replies; 13+ messages in thread
From: Xiubo Li @ 2014-03-24 2:22 UTC (permalink / raw)
To: linux-arm-kernel
This adds devicetree node for VF610, and there are 8 channels
supported.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
---
arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index acf544e..2a7917e 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -183,6 +183,19 @@
clock-names = "pit";
};
+ pwm0: pwm at 40038000 {
+ compatible = "fsl,vf610-ftm-pwm";
+ #pwm-cells = <3>;
+ reg = <0x40038000 0x1000>;
+ clock-names = "ftm_sys", "ftm_ext",
+ "ftm_fix", "ftm_cnt_clk_en";
+ clocks = <&clks VF610_CLK_FTM0>,
+ <&clks VF610_CLK_FTM0_EXT_SEL>,
+ <&clks VF610_CLK_FTM0_FIX_SEL>,
+ <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
+ status = "disabled";
+ };
+
adc0: adc at 4003b000 {
compatible = "fsl,vf610-adc";
reg = <0x4003b000 0x1000>;
--
1.8.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
2014-03-24 2:22 ` Xiubo Li
@ 2014-03-24 2:22 ` Xiubo Li
-1 siblings, 0 replies; 13+ messages in thread
From: Xiubo Li @ 2014-03-24 2:22 UTC (permalink / raw)
To: shawn.guo-QSEj5FYQhm4dnm+yROfE0A
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Xiubo Li
Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index f3af8ea..3fabdb5 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -213,6 +213,17 @@
>;
};
+ pinctrl_pwm0: pwm0grp {
+ fsl,pins = <
+ VF610_PAD_PTB0__FTM0_CH0 0x1582
+ VF610_PAD_PTB1__FTM0_CH1 0x1582
+ VF610_PAD_PTB2__FTM0_CH2 0x1582
+ VF610_PAD_PTB3__FTM0_CH3 0x1582
+ VF610_PAD_PTB6__FTM0_CH6 0x1582
+ VF610_PAD_PTB7__FTM0_CH7 0x1582
+ >;
+ };
+
pinctrl_sai2: sai2grp {
fsl,pins = <
VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
--
1.8.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
@ 2014-03-24 2:22 ` Xiubo Li
0 siblings, 0 replies; 13+ messages in thread
From: Xiubo Li @ 2014-03-24 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index f3af8ea..3fabdb5 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -213,6 +213,17 @@
>;
};
+ pinctrl_pwm0: pwm0grp {
+ fsl,pins = <
+ VF610_PAD_PTB0__FTM0_CH0 0x1582
+ VF610_PAD_PTB1__FTM0_CH1 0x1582
+ VF610_PAD_PTB2__FTM0_CH2 0x1582
+ VF610_PAD_PTB3__FTM0_CH3 0x1582
+ VF610_PAD_PTB6__FTM0_CH6 0x1582
+ VF610_PAD_PTB7__FTM0_CH7 0x1582
+ >;
+ };
+
pinctrl_sai2: sai2grp {
fsl,pins = <
VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
--
1.8.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
2014-03-24 2:22 ` Xiubo Li
(?)
@ 2014-07-29 18:56 ` Bill Pringlemeir
2014-07-30 2:11 ` Li.Xiubo at freescale.com
-1 siblings, 1 reply; 13+ messages in thread
From: Bill Pringlemeir @ 2014-07-29 18:56 UTC (permalink / raw)
To: linux-arm-kernel
On 23 Mar 2014, Li.Xiubo at freescale.com wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-twr.dts
> b/arch/arm/boot/dts/vf610-twr.dts index f3af8ea..3fabdb5 100644 ---
> a/arch/arm/boot/dts/vf610-twr.dts +++
> b/arch/arm/boot/dts/vf610-twr.dts @@ -213,6 +213,17 @@
> >;
> };
>
> + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0
Hi Xiubo,
I think you added this for the tower audio board? Maybe the beeper?
Are these lines needed?
+ VF610_PAD_PTB6__FTM0_CH6 0x1582
+ VF610_PAD_PTB7__FTM0_CH7 0x1582
According to my tower schematics, PTB6 routes to the Primary B35/GPIO4,
and B40/FTM0CH6/PWM4 and to the jumpers J23. PTB7 routes to
B39/FTM0CH7/PWM5, EIRQ3/B55/B56, and jumper J24. I think that most
people have some tower serial card which can also route these lines
and/or they are sent to the OpenSDA chip which does a ttyACM (USB
serial) on all Tower main boards.
Did you just add all FTM channels 0-7 in the DTS? Or are each and every
one mapped to a pin on the expansion/riser boards. Could we remove the
two lines above and use,
pinctrl_uart2: uart2grp {
fsl,pins = <
VF610_PAD_PTB6__UART2_TX 0x21a2
VF610_PAD_PTB7__UART2_RX 0x21a1
>;
};
So that the PTB6/7 map to UART2? Or are these indeed a conflict with
some audio board (or other)? I think it might be valuable to add the
'ttyLP2' to the vf610-twr. An MMC image could echo 'wrong serial port,
set J23/24' for instance to tell people that the serial console was not
connected properly (or something else). People may also wish to use a
serial interface for other peripherals or as a 2nd debug port.
Thanks,
Bill Pringlemeir.
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
2014-07-29 18:56 ` Bill Pringlemeir
@ 2014-07-30 2:11 ` Li.Xiubo at freescale.com
2014-07-30 2:58 ` Shawn Guo
0 siblings, 1 reply; 13+ messages in thread
From: Li.Xiubo at freescale.com @ 2014-07-30 2:11 UTC (permalink / raw)
To: linux-arm-kernel
Hi Bill Pringlemeir,
> > diff --git a/arch/arm/boot/dts/vf610-twr.dts
> > b/arch/arm/boot/dts/vf610-twr.dts index f3af8ea..3fabdb5 100644 ---
> > a/arch/arm/boot/dts/vf610-twr.dts +++
> > b/arch/arm/boot/dts/vf610-twr.dts @@ -213,6 +213,17 @@
> > >;
> > };
> >
> > + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0
>
> Hi Xiubo,
>
> I think you added this for the tower audio board? Maybe the beeper?
For the PWM leds and beepers, for now only the ch0~ch3 are used here.
> Are these lines needed?
>
> + VF610_PAD_PTB6__FTM0_CH6 0x1582
> + VF610_PAD_PTB7__FTM0_CH7 0x1582
>
> According to my tower schematics, PTB6 routes to the Primary B35/GPIO4,
> and B40/FTM0CH6/PWM4 and to the jumpers J23. PTB7 routes to
> B39/FTM0CH7/PWM5, EIRQ3/B55/B56, and jumper J24. I think that most
> people have some tower serial card which can also route these lines
> and/or they are sent to the OpenSDA chip which does a ttyACM (USB
> serial) on all Tower main boards.
>
> Did you just add all FTM channels 0-7 in the DTS? Or are each and every
> one mapped to a pin on the expansion/riser boards. Could we remove the
> two lines above and use,
>
> pinctrl_uart2: uart2grp {
> fsl,pins = <
> VF610_PAD_PTB6__UART2_TX 0x21a2
> VF610_PAD_PTB7__UART2_RX 0x21a1
> >;
> };
>
> So that the PTB6/7 map to UART2? Or are these indeed a conflict with
> some audio board (or other)?
There hasn't any confliction with audio board as far as I know.
I think they can be removed.
> I think it might be valuable to add the
> 'ttyLP2' to the vf610-twr. An MMC image could echo 'wrong serial port,
> set J23/24' for instance to tell people that the serial console was not
> connected properly (or something else). People may also wish to use a
> serial interface for other peripherals or as a 2nd debug port.
>
Hum, if so I think it's okay.
@Shawn,
Do you have any comments here ?
Thanks,
BRs
Xiubo
> Thanks,
> Bill Pringlemeir.
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCHv2 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node
2014-07-30 2:11 ` Li.Xiubo at freescale.com
@ 2014-07-30 2:58 ` Shawn Guo
0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2014-07-30 2:58 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 30, 2014 at 10:11:48AM +0800, Xiubo Li-B47053 wrote:
> > I think it might be valuable to add the
> > 'ttyLP2' to the vf610-twr. An MMC image could echo 'wrong serial port,
> > set J23/24' for instance to tell people that the serial console was not
> > connected properly (or something else). People may also wish to use a
> > serial interface for other peripherals or as a 2nd debug port.
> >
>
> Hum, if so I think it's okay.
>
> @Shawn,
>
> Do you have any comments here ?
I'm fine with leaving the pins to serial interface, if it makes the most
sense to most people, which sounds like the case from your discussion.
Shawn
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCHv2 3/3] ARM: dts: vf610-twr: Enables FTM PWM device.
2014-03-24 2:22 ` Xiubo Li
@ 2014-03-24 2:22 ` Xiubo Li
-1 siblings, 0 replies; 13+ messages in thread
From: Xiubo Li @ 2014-03-24 2:22 UTC (permalink / raw)
To: shawn.guo-QSEj5FYQhm4dnm+yROfE0A
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Xiubo Li
Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Reviewed-by: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
arch/arm/boot/dts/vf610-twr.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index 3fabdb5..c016ec8 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -245,6 +245,12 @@
};
};
+&pwm0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0>;
+ status = "okay";
+};
+
&sai2 {
#sound-dai-cells = <0>;
pinctrl-names = "default";
--
1.8.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCHv2 3/3] ARM: dts: vf610-twr: Enables FTM PWM device.
@ 2014-03-24 2:22 ` Xiubo Li
0 siblings, 0 replies; 13+ messages in thread
From: Xiubo Li @ 2014-03-24 2:22 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
---
arch/arm/boot/dts/vf610-twr.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index 3fabdb5..c016ec8 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -245,6 +245,12 @@
};
};
+&pwm0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0>;
+ status = "okay";
+};
+
&sai2 {
#sound-dai-cells = <0>;
pinctrl-names = "default";
--
1.8.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCHv2 0/3] Add DTS node for FTM PWM
2014-03-24 2:22 ` Xiubo Li
@ 2014-03-24 4:36 ` Shawn Guo
-1 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2014-03-24 4:36 UTC (permalink / raw)
To: Xiubo Li
Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA, linux-lFZ/pmaqli7XmaaqVzeoHQ,
pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, galak-sgV2jX0FEOL9JmXXK+q4OQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Mar 24, 2014 at 10:22:13AM +0800, Xiubo Li wrote:
> Xiubo Li (3):
> ARM: dts: vf610: Add Freescale FTM PWM node. ==> resend v10
> ARM: dts: vf610-twr: Add PWM0's pinctrl node ==> new
> ARM: dts: vf610-twr: Enables FTM PWM device. ==> resend v10
Applied all, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread