[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Insop Song]

Remove warning

Insop Song (1):
  Remove warning printk

 drivers/staging/gs_fpgaboot/gs_fpgaboot.c |    1 -
 1 file changed, 1 deletion(-)

-- 
1.7.9.5

[PATCH] Remove warning printk

[Insop Song]

Found from build with option -Werror=date-time

Signed-off-by: Insop Song <insop.song@gainspeed.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 89bc84d..7506900 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
 	r = -1;
 
 	pr_info("FPGA DOWNLOAD --->\n");
-	pr_info("built at %s UTC\n", __TIMESTAMP__);
 
 	pr_info("FPGA image file name: %s\n", file);
 
-- 
1.7.9.5

Re: [PATCH] Remove warning printk

[Greg KH]

On Thu, Mar 27, 2014 at 08:54:43PM -0700, Insop Song wrote:
> Found from build with option -Werror=date-time
> 
> Signed-off-by: Insop Song <insop.song@gainspeed.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Did Arnd really sign off on this?

And what is with the "odd" subject, your first email should have been
the subject of this one.  We don't need a "cover letter" for a one-patch
email sequence.

Care to fix this up and resend?

thanks,

greg k-h

RE: [PATCH] Remove warning printk

[Insop Song]

Hi Greg,

Will send out a new patch mail with single patch shortly.

I have not yet find a good way to reply mail and add patch yet with my mailing server/client.

That's why I send out a separate email instead of replying to Arnd.

Below is his email and it has his signed-off, that's why I put that in my patch you got.

I took that out from a new patch to make it clear on your end.

Regards,

ISS

Here is Arnd's original email 
________________________________________
From: Arnd Bergmann <arnd@arndb.de>
Sent: Tuesday, March 25, 2014 8:48 AM
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org; Insop Song
Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

We specifically build the kernel with -Werror=date-time to detect
such macros, which gives us this error:

gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
  pr_info("built at %s UTC\n", __TIMESTAMP__);

The obvious fix is to remove the printk output line.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 89bc84d..7506900 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
        r = -1;

        pr_info("FPGA DOWNLOAD --->\n");
-       pr_info("built at %s UTC\n", __TIMESTAMP__);

        pr_info("FPGA image file name: %s\n", file);



________________________________________
From: Greg KH <gregkh@linuxfoundation.org>
Sent: Thursday, March 27, 2014 11:49 PM
To: Insop Song
Cc: insop.song@gmail.com; linux-kernel@vger.kernel.org; Arnd Bergmann
Subject: Re: [PATCH] Remove warning printk

On Thu, Mar 27, 2014 at 08:54:43PM -0700, Insop Song wrote:
> Found from build with option -Werror=date-time
>
> Signed-off-by: Insop Song <insop.song@gainspeed.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Did Arnd really sign off on this?

And what is with the "odd" subject, your first email should have been
the subject of this one.  We don't need a "cover letter" for a one-patch
email sequence.

Care to fix this up and resend?

thanks,

greg k-h

Re: [PATCH] Remove warning printk

[Greg KH]

On Fri, Mar 28, 2014 at 08:05:23AM +0000, Insop Song wrote:
> Hi Greg,
> 
> Will send out a new patch mail with single patch shortly.
> 
> I have not yet find a good way to reply mail and add patch yet with my mailing server/client.
> 
> That's why I send out a separate email instead of replying to Arnd.
> 
> Below is his email and it has his signed-off, that's why I put that in my patch you got.

But Arnd wrote the patch, not you.  Why are you claiming credit for it?

You also changed the subject.  Not good.

I'll just take Arnd's original patch, when my merge window opens back up
again (after 3.15-rc1), and add your signed-off-by to the patch.  You
can just reply to Arnd's patch with that line, and I will add it.

Don't strip off ownership of the patch, if you are having email
problems, read Documenation/SubmittingPatches for how to get the
authorship right.

greg k-h

Re: [PATCH] Remove warning printk

[Insop Song]

On Fri, Mar 28, 2014 at 1:46 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Mar 28, 2014 at 08:05:23AM +0000, Insop Song wrote:
>> Hi Greg,
>>
>> Will send out a new patch mail with single patch shortly.
>>
>> I have not yet find a good way to reply mail and add patch yet with my mailing server/client.
>>
>> That's why I send out a separate email instead of replying to Arnd.
>>
>> Below is his email and it has his signed-off, that's why I put that in my patch you got.
>
> But Arnd wrote the patch, not you.  Why are you claiming credit for it?
>

I didn't mean to do that.
>From next time, I will simply add my sign-off and reply for any similar case.

> You also changed the subject.  Not good.

If I just reply from the next time, this should be taken care of as well.

>
> I'll just take Arnd's original patch, when my merge window opens back up
> again (after 3.15-rc1), and add your signed-off-by to the patch.  You
> can just reply to Arnd's patch with that line, and I will add it.
>

I've replied.

Thank you,

ISS

Re: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Geert Uytterhoeven]

On Tue, Mar 25, 2014 at 4:48 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> We specifically build the kernel with -Werror=date-time to detect
> such macros, which gives us this error:
>
> gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
>   pr_info("built at %s UTC\n", __TIMESTAMP__);

Worse, gcc 4.1.2 doesn't seem to understand __TIMESTAMP__:

drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_fpgaboot_init’:
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: ‘__TIMESTAMP__’
undeclared (first use in this function)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: (Each undeclared
identifier is reported only once
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: for each
function it appears in.)

> The obvious fix is to remove the printk output line.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> index 89bc84d..7506900 100644
> --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> @@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
>         r = -1;
>
>         pr_info("FPGA DOWNLOAD --->\n");
> -       pr_info("built at %s UTC\n", __TIMESTAMP__);
>
>         pr_info("FPGA image file name: %s\n", file);
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Insop Song]

________________________________________
From: Arnd Bergmann <arnd@arndb.de>
Sent: Tuesday, March 25, 2014 8:48 AM
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org; Insop Song
Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

We specifically build the kernel with -Werror=date-time to detect
such macros, which gives us this error:

gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
  pr_info("built at %s UTC\n", __TIMESTAMP__);

The obvious fix is to remove the printk output line.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Insop Song <insop.song@gainspeed.com>

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 89bc84d..7506900 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
        r = -1;

        pr_info("FPGA DOWNLOAD --->\n");
-       pr_info("built at %s UTC\n", __TIMESTAMP__);

        pr_info("FPGA image file name: %s\n", file);

[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Arnd Bergmann]

We specifically build the kernel with -Werror=date-time to detect
such macros, which gives us this error:

gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
  pr_info("built at %s UTC\n", __TIMESTAMP__);

The obvious fix is to remove the printk output line.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 89bc84d..7506900 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
 	r = -1;
 
 	pr_info("FPGA DOWNLOAD --->\n");
-	pr_info("built at %s UTC\n", __TIMESTAMP__);
 
 	pr_info("FPGA image file name: %s\n", file);