From: Oliver Neukum <oneukum@suse.de>
To: Roger <rogerable@realtek.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>, Chris Ball <chris@printf.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn,
micky_ching@realsil.com.cn
Subject: Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver
Date: Fri, 28 Mar 2014 09:31:26 +0100 [thread overview]
Message-ID: <1395995486.9520.2.camel@linux-fkkt.site> (raw)
In-Reply-To: <5334ED70.6050309@realtek.com>
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote:
> On 03/26/2014 10:36 PM, Oliver Neukum wrote:
> > On Tue, 2014-03-25 at 18:44 +0800, rogerable@realtek.com wrote:
> >> From: Roger Tseng <rogerable@realtek.com>
> >> + if (ret)
> >> + goto out_init_fail;
> >> +
> >> + /* initialize USB SG transfer timer */
> >> + init_timer(&ucr->sg_timer);
> >> + setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr);
> >> +#ifdef CONFIG_PM
> >> + intf->needs_remote_wakeup = 1;
> >
> > Why?
> Our reader supports remote wake-up from card slot event(insertion,
> removal). It should be enabled to let the driver be able to detect the
> newly inserted card.
Interesting. This capability has been lacking for a long time.
That is cool hardware. Are you sure the upper layers implement
the event infrastructure so that devices are not polled?
> The LED is not in a permanent cut-off state after here. It is called to
> guarantee the LED is off during suspend to save more power. It could be
> lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c) anytime whenever
> necessary.
>
> This has been asked may times. I'm considering putting some comment in
> next revision.
Good idea.
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.de>
To: Roger <rogerable@realtek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
Andrew Morton <akpm@linux-foundation.org>,
Lee Jones <lee.jones@linaro.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver
Date: Fri, 28 Mar 2014 09:31:26 +0100 [thread overview]
Message-ID: <1395995486.9520.2.camel@linux-fkkt.site> (raw)
In-Reply-To: <5334ED70.6050309@realtek.com>
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote:
> On 03/26/2014 10:36 PM, Oliver Neukum wrote:
> > On Tue, 2014-03-25 at 18:44 +0800, rogerable@realtek.com wrote:
> >> From: Roger Tseng <rogerable@realtek.com>
> >> + if (ret)
> >> + goto out_init_fail;
> >> +
> >> + /* initialize USB SG transfer timer */
> >> + init_timer(&ucr->sg_timer);
> >> + setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr);
> >> +#ifdef CONFIG_PM
> >> + intf->needs_remote_wakeup = 1;
> >
> > Why?
> Our reader supports remote wake-up from card slot event(insertion,
> removal). It should be enabled to let the driver be able to detect the
> newly inserted card.
Interesting. This capability has been lacking for a long time.
That is cool hardware. Are you sure the upper layers implement
the event infrastructure so that devices are not polled?
> The LED is not in a permanent cut-off state after here. It is called to
> guarantee the LED is off during suspend to save more power. It could be
> lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c) anytime whenever
> necessary.
>
> This has been asked may times. I'm considering putting some comment in
> next revision.
Good idea.
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.de>
To: Roger <rogerable@realtek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
Andrew Morton <akpm@linux-foundation.org>,
Lee Jones <lee.jones@linaro.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver
Date: Fri, 28 Mar 2014 09:31:26 +0100 [thread overview]
Message-ID: <1395995486.9520.2.camel@linux-fkkt.site> (raw)
In-Reply-To: <5334ED70.6050309@realtek.com>
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote:
> On 03/26/2014 10:36 PM, Oliver Neukum wrote:
> > On Tue, 2014-03-25 at 18:44 +0800, rogerable@realtek.com wrote:
> >> From: Roger Tseng <rogerable@realtek.com>
> >> + if (ret)
> >> + goto out_init_fail;
> >> +
> >> + /* initialize USB SG transfer timer */
> >> + init_timer(&ucr->sg_timer);
> >> + setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr);
> >> +#ifdef CONFIG_PM
> >> + intf->needs_remote_wakeup = 1;
> >
> > Why?
> Our reader supports remote wake-up from card slot event(insertion,
> removal). It should be enabled to let the driver be able to detect the
> newly inserted card.
Interesting. This capability has been lacking for a long time.
That is cool hardware. Are you sure the upper layers implement
the event infrastructure so that devices are not polled?
> The LED is not in a permanent cut-off state after here. It is called to
> guarantee the LED is off during suspend to save more power. It could be
> lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c) anytime whenever
> necessary.
>
> This has been asked may times. I'm considering putting some comment in
> next revision.
Good idea.
Regards
Oliver
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2014-03-28 8:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 10:44 [PATCH v5 0/3] Add modules for realtek USB card reader rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` [PATCH v5 1/3] mfd: Add realtek USB card reader driver rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` rogerable
2014-03-26 14:36 ` Oliver Neukum
2014-03-26 14:36 ` Oliver Neukum
[not found] ` <201403280231.s2S2VP8X017745@rtits1.realtek.com>
2014-03-28 3:33 ` Roger
2014-03-28 3:33 ` Roger
2014-03-28 3:33 ` Roger
2014-03-28 7:59 ` Lee Jones
2014-03-28 7:59 ` Lee Jones
2014-03-28 8:31 ` Oliver Neukum [this message]
2014-03-28 8:31 ` Oliver Neukum
2014-03-28 8:31 ` Oliver Neukum
2014-03-28 8:57 ` Roger
2014-03-28 8:57 ` Roger
2014-03-28 8:57 ` Roger
2014-03-25 10:44 ` [PATCH v5 2/3] mmc: Add realtek USB sdmmc host driver rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` [PATCH v5 3/3] memstick: Add realtek USB memstick " rogerable
2014-03-25 10:44 ` rogerable
2014-03-25 10:44 ` rogerable
2014-04-01 3:20 ` Roger
2014-04-01 3:20 ` Roger
2014-04-01 3:20 ` Roger
2014-04-01 22:06 ` Andrew Morton
2014-04-01 22:06 ` Andrew Morton
2014-04-01 22:06 ` Andrew Morton
2014-04-02 15:16 ` Lee Jones
2014-04-02 15:16 ` Lee Jones
2014-04-08 8:06 ` Roger
2014-04-08 8:06 ` Roger
2014-04-08 8:06 ` Roger
2014-04-08 11:37 ` Lee Jones
2014-04-08 11:37 ` Lee Jones
2014-04-08 13:10 ` Roger
2014-04-08 13:10 ` Roger
2014-04-08 13:10 ` Roger
2014-04-08 13:25 ` Dan Carpenter
2014-04-08 13:25 ` Dan Carpenter
2014-04-08 13:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395995486.9520.2.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=micky_ching@realsil.com.cn \
--cc=oakad@yahoo.com \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.