[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Guillaume Subiron <maethor@subiron.org>
Subject: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails
Date: Mon, 31 Mar 2014 00:22:52 +0200	[thread overview]
Message-ID: <1396218189-14422-2-git-send-email-samuel.thibault@ens-lyon.org> (raw)
In-Reply-To: <1396218189-14422-1-git-send-email-samuel.thibault@ens-lyon.org>

Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent. This could cause memory leak.
This patch adds a goto bad to cut the execution of this function.

Signed-off-by: Guillaume Subiron <maethor@subiron.org>
---
 slirp/udp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/slirp/udp.c b/slirp/udp.c
index 8cc6cb6..fd2446a 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
 	  *ip=save_ip;
 	  DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
 	  icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
+	  goto bad;
 	}
 
 	m_free(so->so_m);   /* used for ICMP if error on sorecvfrom */
-- 
1.9.0
