* [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix
@ 2014-03-31 13:31 Axel Lin
2014-03-31 13:32 ` [PATCH 2/2] mfd: bcm590xx: Add missing remove function Axel Lin
2014-04-15 10:03 ` [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2014-03-31 13:31 UTC (permalink / raw)
To: Lee Jones, Samuel Ortiz; +Cc: Matt Porter, linux-kernel
This is a i2c driver, so uses i2c prefix in modalias.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/bcm590xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index e9a33c7..40c0dd3 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -90,4 +90,4 @@ module_i2c_driver(bcm590xx_i2c_driver);
MODULE_AUTHOR("Matt Porter <mporter@linaro.org>");
MODULE_DESCRIPTION("BCM590xx multi-function driver");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:bcm590xx");
+MODULE_ALIAS("i2c:bcm590xx");
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] mfd: bcm590xx: Add missing remove function
2014-03-31 13:31 [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Axel Lin
@ 2014-03-31 13:32 ` Axel Lin
2014-04-15 10:03 ` Lee Jones
2014-04-15 10:03 ` [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2014-03-31 13:32 UTC (permalink / raw)
To: Lee Jones; +Cc: Samuel Ortiz, Matt Porter, linux-kernel
Add missing mfd_remove_devices() call in remove function.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/bcm590xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 40c0dd3..c986149 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -64,6 +64,12 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c,
return ret;
}
+static int bcm590xx_i2c_remove(struct i2c_client *i2c)
+{
+ mfd_remove_devices(&i2c->dev);
+ return 0;
+}
+
static const struct of_device_id bcm590xx_of_match[] = {
{ .compatible = "brcm,bcm59056" },
{ }
@@ -83,6 +89,7 @@ static struct i2c_driver bcm590xx_i2c_driver = {
.of_match_table = of_match_ptr(bcm590xx_of_match),
},
.probe = bcm590xx_i2c_probe,
+ .remove = bcm590xx_i2c_remove,
.id_table = bcm590xx_i2c_id,
};
module_i2c_driver(bcm590xx_i2c_driver);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix
2014-03-31 13:31 [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Axel Lin
2014-03-31 13:32 ` [PATCH 2/2] mfd: bcm590xx: Add missing remove function Axel Lin
@ 2014-04-15 10:03 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-04-15 10:03 UTC (permalink / raw)
To: Axel Lin; +Cc: Samuel Ortiz, Matt Porter, linux-kernel
> This is a i2c driver, so uses i2c prefix in modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/bcm590xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] mfd: bcm590xx: Add missing remove function
2014-03-31 13:32 ` [PATCH 2/2] mfd: bcm590xx: Add missing remove function Axel Lin
@ 2014-04-15 10:03 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-04-15 10:03 UTC (permalink / raw)
To: Axel Lin; +Cc: Samuel Ortiz, Matt Porter, linux-kernel
> Add missing mfd_remove_devices() call in remove function.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/bcm590xx.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-15 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-31 13:31 [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Axel Lin
2014-03-31 13:32 ` [PATCH 2/2] mfd: bcm590xx: Add missing remove function Axel Lin
2014-04-15 10:03 ` Lee Jones
2014-04-15 10:03 ` [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.