* [PATCH v2 1/1] staging: comedi: Fix checkpatch warning
@ 2014-04-04 20:55 Camille Begue
2014-04-05 22:09 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Camille Begue @ 2014-04-04 20:55 UTC (permalink / raw)
To: devel
Cc: Camille Begue, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman,
open list
Wrap lines > 80 columns.
This patch is part of eudyptula challenge
Signed-off-by: Camille Begue <camille.begue44@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index ea6dc36..0f05e87 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
s = &dev->subdevices[cmd->subdev];
if (s->type == COMEDI_SUBD_UNUSED) {
- dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
+ dev_dbg(dev->class_dev,
+ "%d not valid subdevice\n",
+ cmd->subdev);
return -EIO;
}
if (!s->do_cmd || !s->do_cmdtest || !s->async) {
dev_dbg(dev->class_dev,
- "subdevice %d does not support commands\n", cmd->subdev);
+ "subdevice %d does not support commands\n",
+ cmd->subdev);
return -EIO;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning
2014-04-04 20:55 [PATCH v2 1/1] staging: comedi: Fix checkpatch warning Camille Begue
@ 2014-04-05 22:09 ` Greg Kroah-Hartman
2014-04-05 22:19 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-04-05 22:09 UTC (permalink / raw)
To: Camille Begue; +Cc: devel, Ian Abbott, open list
On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote:
> Wrap lines > 80 columns.
> This patch is part of eudyptula challenge
>
> Signed-off-by: Camille Begue <camille.begue44@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ea6dc36..0f05e87 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev,
> + "%d not valid subdevice\n",
> + cmd->subdev);
Why did you split this into 3 lines, it only needs to be 2 like this:
dev_dbg(dev->class_dev, "%d not valid subdevice\n",
cmd->subdev);
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning
2014-04-05 22:09 ` Greg Kroah-Hartman
@ 2014-04-05 22:19 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-04-05 22:19 UTC (permalink / raw)
To: Camille Begue; +Cc: devel, Ian Abbott, open list
On Sat, Apr 05, 2014 at 03:09:27PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote:
> > Wrap lines > 80 columns.
> > This patch is part of eudyptula challenge
> >
> > Signed-off-by: Camille Begue <camille.begue44@gmail.com>
> > ---
> > drivers/staging/comedi/comedi_fops.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> > index ea6dc36..0f05e87 100644
> > --- a/drivers/staging/comedi/comedi_fops.c
> > +++ b/drivers/staging/comedi/comedi_fops.c
> > @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> > s = &dev->subdevices[cmd->subdev];
> >
> > if (s->type == COMEDI_SUBD_UNUSED) {
> > - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> > + dev_dbg(dev->class_dev,
> > + "%d not valid subdevice\n",
> > + cmd->subdev);
>
> Why did you split this into 3 lines, it only needs to be 2 like this:
> dev_dbg(dev->class_dev, "%d not valid subdevice\n",
> cmd->subdev);
Nevermind, you fixed it up later...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-05 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-04 20:55 [PATCH v2 1/1] staging: comedi: Fix checkpatch warning Camille Begue
2014-04-05 22:09 ` Greg Kroah-Hartman
2014-04-05 22:19 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.