All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com,
	stefano.stabellini@eu.citrix.com, weidong.han@intel.com,
	allen.m.kay@intel.com, qemu-devel@nongnu.org,
	jean.guyader@eu.citrix.com, anthony.perard@citrix.com,
	anthony@codemonkey.ws, Yang Zhang <yang.z.zhang@intel.com>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 0/5] xen: add Intel IGD passthrough support
Date: Mon, 7 Apr 2014 09:36:08 +0100	[thread overview]
Message-ID: <1396859768.22845.7.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <20140404224605.GA10732@morn.localdomain>

On Fri, 2014-04-04 at 18:46 -0400, Kevin O'Connor wrote:
> On Fri, Feb 21, 2014 at 02:44:08PM +0800, Yang Zhang wrote:
> > From: Yang Zhang <yang.z.zhang@Intel.com>
> > 
> > The following patches are ported from Xen Qemu-traditional branch which are
> > adding Intel IGD passthrough supporting to Qemu upstream.
> > 
> > To pass through IGD to guest, user need to add following lines in Xen config
> > file:
> > gfx_passthru=1
> > pci=['00:02.0@2']
> > 
> > Besides, since Xen + Qemu upstream is requiring seabios, user also need to
> > recompile seabios with CONFIG_OPTIONROMS_DEPLOYED=y to allow IGD pass through
> > successfully:
> 
> I'm not familiar with the Xen parts of your patch series.  However, I
> don't think one should be compiling SeaBIOS with
> CONFIG_OPTIONROMS_DEPLOYED enabled.

I agree, thanks for spotting this. I would nack any patch which tried to
enable this option in the Xen build of SeaBIOS.

>   That option was for very old
> versions of Bochs and QEMU that did not support fetching of optionroms
> directly from PCI config space nor from fw_cfg.
> 
> That compile time option is no longer well supported and it may be
> removed in the future.  I suggest looking at getting one of the other
> mechanisms working instead of using CONFIG_OPTIONROMS_DEPLOYED.

AFAIK the usual mechanisms already work for SeaBIOS under Xen, e.g. for
the video BIOS of the emulated VGA it Just Works. I've no idea what
makes Intel IGD passthrough special.

Ian.

WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com,
	stefano.stabellini@eu.citrix.com, weidong.han@intel.com,
	allen.m.kay@intel.com, qemu-devel@nongnu.org,
	jean.guyader@eu.citrix.com, anthony.perard@citrix.com,
	anthony@codemonkey.ws, Yang Zhang <yang.z.zhang@intel.com>
Subject: Re: [Xen-devel] [PATCH 0/5] xen: add Intel IGD passthrough support
Date: Mon, 7 Apr 2014 09:36:08 +0100	[thread overview]
Message-ID: <1396859768.22845.7.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <20140404224605.GA10732@morn.localdomain>

On Fri, 2014-04-04 at 18:46 -0400, Kevin O'Connor wrote:
> On Fri, Feb 21, 2014 at 02:44:08PM +0800, Yang Zhang wrote:
> > From: Yang Zhang <yang.z.zhang@Intel.com>
> > 
> > The following patches are ported from Xen Qemu-traditional branch which are
> > adding Intel IGD passthrough supporting to Qemu upstream.
> > 
> > To pass through IGD to guest, user need to add following lines in Xen config
> > file:
> > gfx_passthru=1
> > pci=['00:02.0@2']
> > 
> > Besides, since Xen + Qemu upstream is requiring seabios, user also need to
> > recompile seabios with CONFIG_OPTIONROMS_DEPLOYED=y to allow IGD pass through
> > successfully:
> 
> I'm not familiar with the Xen parts of your patch series.  However, I
> don't think one should be compiling SeaBIOS with
> CONFIG_OPTIONROMS_DEPLOYED enabled.

I agree, thanks for spotting this. I would nack any patch which tried to
enable this option in the Xen build of SeaBIOS.

>   That option was for very old
> versions of Bochs and QEMU that did not support fetching of optionroms
> directly from PCI config space nor from fw_cfg.
> 
> That compile time option is no longer well supported and it may be
> removed in the future.  I suggest looking at getting one of the other
> mechanisms working instead of using CONFIG_OPTIONROMS_DEPLOYED.

AFAIK the usual mechanisms already work for SeaBIOS under Xen, e.g. for
the video BIOS of the emulated VGA it Just Works. I've no idea what
makes Intel IGD passthrough special.

Ian.

  reply	other threads:[~2014-04-07  8:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21  6:44 [Qemu-devel] [PATCH 0/5] xen: add Intel IGD passthrough support Yang Zhang
2014-02-21  6:44 ` Yang Zhang
2014-02-21  6:44 ` [Qemu-devel] [PATCH 1/5] xen, gfx passthrough: basic graphics " Yang Zhang
2014-02-21  6:44   ` Yang Zhang
2014-03-21 16:24   ` [Qemu-devel] " Anthony PERARD
2014-03-21 16:24     ` Anthony PERARD
2014-05-09  7:27     ` [Qemu-devel] " Zhang, Yang Z
2014-05-09  7:27       ` Zhang, Yang Z
2014-04-02 15:19   ` [Qemu-devel] [Xen-devel] " Zytaruk, Kelly
2014-04-02 15:19     ` Zytaruk, Kelly
2014-02-21  6:44 ` [Qemu-devel] [PATCH 2/5] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD Yang Zhang
2014-02-21  6:44   ` Yang Zhang
2014-03-21 17:26   ` [Qemu-devel] " Anthony PERARD
2014-03-21 17:26     ` Anthony PERARD
2014-02-21  6:44 ` [Qemu-devel] [PATCH 3/5] xen, gfx passthrough: create intel isa bridge Yang Zhang
2014-02-21  6:44   ` Yang Zhang
2014-02-21  6:44 ` [Qemu-devel] [PATCH 4/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D Yang Zhang
2014-02-21  6:44   ` Yang Zhang
2014-03-27 18:21   ` [Qemu-devel] " Stefano Stabellini
2014-03-27 18:21     ` Stefano Stabellini
2014-03-27 19:10     ` [Qemu-devel] " Michael S. Tsirkin
2014-03-27 19:10       ` Michael S. Tsirkin
2014-02-21  6:44 ` [Qemu-devel] [PATCH 5/5] xen, gfx passthrough: add opregion mapping Yang Zhang
2014-02-21  6:44   ` Yang Zhang
2014-02-27  5:38 ` [Qemu-devel] [PATCH 0/5] xen: add Intel IGD passthrough support Zhang, Yang Z
2014-02-27  5:38   ` Zhang, Yang Z
2014-02-27 12:47   ` [Qemu-devel] " Stefano Stabellini
2014-02-27 12:47     ` Stefano Stabellini
2014-04-04 22:46 ` [Qemu-devel] " Kevin O'Connor
2014-04-04 22:46   ` Kevin O'Connor
2014-04-07  8:36   ` Ian Campbell [this message]
2014-04-07  8:36     ` [Xen-devel] " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396859768.22845.7.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=allen.m.kay@intel.com \
    --cc=anthony.perard@citrix.com \
    --cc=anthony@codemonkey.ws \
    --cc=jean.guyader@eu.citrix.com \
    --cc=kevin@koconnor.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=weidong.han@intel.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.