* [PATCH] reset: Add of_reset_control_get to reset.h
@ 2014-04-13 12:09 Hans de Goede
2014-04-13 12:47 ` Josh Triplett
2014-04-14 7:58 ` Philipp Zabel
0 siblings, 2 replies; 5+ messages in thread
From: Hans de Goede @ 2014-04-13 12:09 UTC (permalink / raw)
To: linux-arm-kernel
of_reset_control_get is not declared static in drivers/reset/core.c, which
is correct as we want to use it elsewhere too. But it does not have a
protype declared anywhere under include/linux. Add a prototype / stub for it
to linux/reset.h to fix this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
include/linux/reset.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index c0eda50..f1ae7ce 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -33,6 +33,9 @@ static inline struct reset_control *devm_reset_control_get_optional(
return devm_reset_control_get(dev, id);
}
+struct reset_control *of_reset_control_get(struct device_node *node,
+ const char *id);
+
#else
static inline int reset_control_reset(struct reset_control *rstc)
@@ -75,6 +78,12 @@ static inline struct reset_control *devm_reset_control_get_optional(
return ERR_PTR(-ENOSYS);
}
+static inline struct reset_control *of_reset_control_get(
+ struct device_node *node, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
#endif /* CONFIG_RESET_CONTROLLER */
#endif
--
1.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] reset: Add of_reset_control_get to reset.h
2014-04-13 12:09 [PATCH] reset: Add of_reset_control_get to reset.h Hans de Goede
@ 2014-04-13 12:47 ` Josh Triplett
2014-04-14 7:58 ` Philipp Zabel
1 sibling, 0 replies; 5+ messages in thread
From: Josh Triplett @ 2014-04-13 12:47 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Apr 13, 2014 at 02:09:15PM +0200, Hans de Goede wrote:
> of_reset_control_get is not declared static in drivers/reset/core.c, which
> is correct as we want to use it elsewhere too. But it does not have a
> protype declared anywhere under include/linux. Add a prototype / stub for it
> to linux/reset.h to fix this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> include/linux/reset.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index c0eda50..f1ae7ce 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -33,6 +33,9 @@ static inline struct reset_control *devm_reset_control_get_optional(
> return devm_reset_control_get(dev, id);
> }
>
> +struct reset_control *of_reset_control_get(struct device_node *node,
> + const char *id);
> +
> #else
>
> static inline int reset_control_reset(struct reset_control *rstc)
> @@ -75,6 +78,12 @@ static inline struct reset_control *devm_reset_control_get_optional(
> return ERR_PTR(-ENOSYS);
> }
>
> +static inline struct reset_control *of_reset_control_get(
> + struct device_node *node, const char *id)
> +{
> + return ERR_PTR(-ENOSYS);
> +}
> +
> #endif /* CONFIG_RESET_CONTROLLER */
>
> #endif
> --
> 1.9.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] reset: Add of_reset_control_get to reset.h
2014-04-13 12:09 [PATCH] reset: Add of_reset_control_get to reset.h Hans de Goede
2014-04-13 12:47 ` Josh Triplett
@ 2014-04-14 7:58 ` Philipp Zabel
2014-04-23 12:27 ` Maxime Ripard
1 sibling, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2014-04-14 7:58 UTC (permalink / raw)
To: linux-arm-kernel
Am Sonntag, den 13.04.2014, 14:09 +0200 schrieb Hans de Goede:
> of_reset_control_get is not declared static in drivers/reset/core.c, which
> is correct as we want to use it elsewhere too. But it does not have a
> protype declared anywhere under include/linux. Add a prototype / stub for it
> to linux/reset.h to fix this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> include/linux/reset.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index c0eda50..f1ae7ce 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -33,6 +33,9 @@ static inline struct reset_control *devm_reset_control_get_optional(
> return devm_reset_control_get(dev, id);
> }
>
> +struct reset_control *of_reset_control_get(struct device_node *node,
> + const char *id);
> +
> #else
>
> static inline int reset_control_reset(struct reset_control *rstc)
> @@ -75,6 +78,12 @@ static inline struct reset_control *devm_reset_control_get_optional(
> return ERR_PTR(-ENOSYS);
> }
>
> +static inline struct reset_control *of_reset_control_get(
> + struct device_node *node, const char *id)
> +{
> + return ERR_PTR(-ENOSYS);
> +}
> +
> #endif /* CONFIG_RESET_CONTROLLER */
>
> #endif
Applied, thanks.
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] reset: Add of_reset_control_get to reset.h
2014-04-14 7:58 ` Philipp Zabel
@ 2014-04-23 12:27 ` Maxime Ripard
2014-04-30 8:29 ` Philipp Zabel
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2014-04-23 12:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Philipp,
On Mon, Apr 14, 2014 at 09:58:06AM +0200, Philipp Zabel wrote:
> Am Sonntag, den 13.04.2014, 14:09 +0200 schrieb Hans de Goede:
> > of_reset_control_get is not declared static in drivers/reset/core.c, which
> > is correct as we want to use it elsewhere too. But it does not have a
> > protype declared anywhere under include/linux. Add a prototype / stub for it
> > to linux/reset.h to fix this.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > include/linux/reset.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/include/linux/reset.h b/include/linux/reset.h
> > index c0eda50..f1ae7ce 100644
> > --- a/include/linux/reset.h
> > +++ b/include/linux/reset.h
> > @@ -33,6 +33,9 @@ static inline struct reset_control *devm_reset_control_get_optional(
> > return devm_reset_control_get(dev, id);
> > }
> >
> > +struct reset_control *of_reset_control_get(struct device_node *node,
> > + const char *id);
> > +
> > #else
> >
> > static inline int reset_control_reset(struct reset_control *rstc)
> > @@ -75,6 +78,12 @@ static inline struct reset_control *devm_reset_control_get_optional(
> > return ERR_PTR(-ENOSYS);
> > }
> >
> > +static inline struct reset_control *of_reset_control_get(
> > + struct device_node *node, const char *id)
> > +{
> > + return ERR_PTR(-ENOSYS);
> > +}
> > +
> > #endif /* CONFIG_RESET_CONTROLLER */
> >
> > #endif
>
> Applied, thanks.
I just noticed you queued this patch up for 3.16.
Since that function got introduced in 3.15-rc1, maybe it would be
better if you queued it for one of 3.15-rc* ?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140423/e3d3819a/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] reset: Add of_reset_control_get to reset.h
2014-04-23 12:27 ` Maxime Ripard
@ 2014-04-30 8:29 ` Philipp Zabel
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Zabel @ 2014-04-30 8:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Maxime,
Am Mittwoch, den 23.04.2014, 14:27 +0200 schrieb Maxime Ripard:
> On Mon, Apr 14, 2014 at 09:58:06AM +0200, Philipp Zabel wrote:
> > Am Sonntag, den 13.04.2014, 14:09 +0200 schrieb Hans de Goede:
> > > of_reset_control_get is not declared static in drivers/reset/core.c, which
> > > is correct as we want to use it elsewhere too. But it does not have a
> > > protype declared anywhere under include/linux. Add a prototype / stub for it
> > > to linux/reset.h to fix this.
> > >
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > ---
> > > include/linux/reset.h | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/include/linux/reset.h b/include/linux/reset.h
> > > index c0eda50..f1ae7ce 100644
> > > --- a/include/linux/reset.h
> > > +++ b/include/linux/reset.h
> > > @@ -33,6 +33,9 @@ static inline struct reset_control *devm_reset_control_get_optional(
> > > return devm_reset_control_get(dev, id);
> > > }
> > >
> > > +struct reset_control *of_reset_control_get(struct device_node *node,
> > > + const char *id);
> > > +
> > > #else
> > >
> > > static inline int reset_control_reset(struct reset_control *rstc)
> > > @@ -75,6 +78,12 @@ static inline struct reset_control *devm_reset_control_get_optional(
> > > return ERR_PTR(-ENOSYS);
> > > }
> > >
> > > +static inline struct reset_control *of_reset_control_get(
> > > + struct device_node *node, const char *id)
> > > +{
> > > + return ERR_PTR(-ENOSYS);
> > > +}
> > > +
> > > #endif /* CONFIG_RESET_CONTROLLER */
> > >
> > > #endif
> >
> > Applied, thanks.
>
> I just noticed you queued this patch up for 3.16.
>
> Since that function got introduced in 3.15-rc1, maybe it would be
> better if you queued it for one of 3.15-rc* ?
Good point, this is the first reset framework patch that should actually
be fast-tracked.
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-30 8:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-13 12:09 [PATCH] reset: Add of_reset_control_get to reset.h Hans de Goede
2014-04-13 12:47 ` Josh Triplett
2014-04-14 7:58 ` Philipp Zabel
2014-04-23 12:27 ` Maxime Ripard
2014-04-30 8:29 ` Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.