All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] freescale: m5253demo: fix unused-but-set-variable warnings
@ 2014-04-15  4:26 Masahiro Yamada
  2014-06-19 15:20 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2014-04-15  4:26 UTC (permalink / raw)
  To: u-boot

Fix the following warning messages:

In function 'flash_erase': 180:21:
warning: variable 'last' set but not used [-Wunused-but-set-variable]
In function 'write_buff':  322:10:
warning: variable 'port_width' set but not used [-Wunused-but-set-variable]

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
---
 board/freescale/m5253demo/flash.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/board/freescale/m5253demo/flash.c b/board/freescale/m5253demo/flash.c
index 387e454..16bba59 100644
--- a/board/freescale/m5253demo/flash.c
+++ b/board/freescale/m5253demo/flash.c
@@ -177,7 +177,7 @@ int flash_erase(flash_info_t * info, int s_first, int s_last)
 {
 	FPWV *addr;
 	int flag, prot, sect, count;
-	ulong type, start, last;
+	ulong type, start;
 	int rcode = 0, flashtype = 0;
 
 	if ((s_first < 0) || (s_first > s_last)) {
@@ -217,7 +217,6 @@ int flash_erase(flash_info_t * info, int s_first, int s_last)
 	flag = disable_interrupts();
 
 	start = get_timer(0);
-	last = start;
 
 	if ((s_last - s_first) == (CONFIG_SYS_SST_SECT - 1)) {
 		if (prot == 0) {
@@ -319,14 +318,13 @@ int write_buff(flash_info_t * info, uchar * src, ulong addr, ulong cnt)
 {
 	ulong wp, count;
 	u16 data;
-	int rc, port_width;
+	int rc;
 
 	if (info->flash_id == FLASH_UNKNOWN)
 		return 4;
 
 	/* get lower word aligned address */
 	wp = addr;
-	port_width = sizeof(FPW);
 
 	/* handle unaligned start bytes */
 	if (wp & 1) {
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] freescale: m5253demo: fix unused-but-set-variable warnings
  2014-04-15  4:26 [U-Boot] [PATCH] freescale: m5253demo: fix unused-but-set-variable warnings Masahiro Yamada
@ 2014-06-19 15:20 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2014-06-19 15:20 UTC (permalink / raw)
  To: u-boot

On Tue, Apr 15, 2014 at 01:26:34PM +0900, Masahiro Yamada wrote:

> Fix the following warning messages:
> 
> In function 'flash_erase': 180:21:
> warning: variable 'last' set but not used [-Wunused-but-set-variable]
> In function 'write_buff':  322:10:
> warning: variable 'port_width' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: TsiChung Liew <Tsi-Chung.Liew@freescale.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140619/8dfa6896/attachment.pgp>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-19 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15  4:26 [U-Boot] [PATCH] freescale: m5253demo: fix unused-but-set-variable warnings Masahiro Yamada
2014-06-19 15:20 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.