All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ
@ 2014-04-15  4:49 ` Harini Katakam
  0 siblings, 0 replies; 6+ messages in thread
From: Harini Katakam @ 2014-04-15  4:49 UTC (permalink / raw)
  To: broonie, linux-spi, linux-kernel; +Cc: michals, Harini Katakam

Add dependency on ARCH_ZYNQ in Kconfig.
This is to fix the build error.

Signed-off-by: Harini Katakam <harinik@xilinx.com>
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index b0f091b..0db219b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -150,6 +150,7 @@ config SPI_BUTTERFLY
 
 config SPI_CADENCE
 	tristate "Cadence SPI controller"
+	depends on ARCH_ZYNQ
 	depends on SPI_MASTER
 	help
 	  This selects the Cadence SPI controller master driver
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ
@ 2014-04-15  4:49 ` Harini Katakam
  0 siblings, 0 replies; 6+ messages in thread
From: Harini Katakam @ 2014-04-15  4:49 UTC (permalink / raw)
  To: broonie-DgEjT+Ai2ygdnm+yROfE0A, linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: michals-gjFFaj9aHVfQT0dZR+AlfA, Harini Katakam

Add dependency on ARCH_ZYNQ in Kconfig.
This is to fix the build error.

Signed-off-by: Harini Katakam <harinik-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index b0f091b..0db219b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -150,6 +150,7 @@ config SPI_BUTTERFLY
 
 config SPI_CADENCE
 	tristate "Cadence SPI controller"
+	depends on ARCH_ZYNQ
 	depends on SPI_MASTER
 	help
 	  This selects the Cadence SPI controller master driver
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ
       [not found] ` <CAHTX3dJrMxWJ-8i-wLRkQYtR_zbA+nJyGW+r-DFMYHHU4Erzbw@mail.gmail.com>
@ 2014-04-15  9:45   ` Mark Brown
  2014-04-15 16:26       ` Will Deacon
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2014-04-15  9:45 UTC (permalink / raw)
  To: Michal Simek; +Cc: Harini Katakam, linux-spi, LKML, Michal Simek, will.deacon

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

On Tue, Apr 15, 2014 at 08:11:37AM +0200, Michal Simek wrote:

> I sent the patch for it which solve this problem in generic way.
> http://lkml.org/lkml/2014/4/8/42

> Feel free to give me ACK for it.

Will has been working on this too off and on, he was also trying to
define some semantics for the relaxed versions.  It'd be really good to
address this properly, this is a constant source of make work.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ
  2014-04-15  4:49 ` Harini Katakam
  (?)
  (?)
@ 2014-04-15  9:49 ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-04-15  9:49 UTC (permalink / raw)
  To: Harini Katakam; +Cc: linux-spi, linux-kernel, michals

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

On Tue, Apr 15, 2014 at 10:19:52AM +0530, Harini Katakam wrote:
> Add dependency on ARCH_ZYNQ in Kconfig.
> This is to fix the build error.

This is too strict - ARCH_ARM would be fine (PowerPC also defines the
_relaxed() operaton if you want to include that too).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ
@ 2014-04-15 16:26       ` Will Deacon
  0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2014-04-15 16:26 UTC (permalink / raw)
  To: Mark Brown; +Cc: Michal Simek, Harini Katakam, linux-spi, LKML, Michal Simek

On Tue, Apr 15, 2014 at 10:45:41AM +0100, Mark Brown wrote:
> On Tue, Apr 15, 2014 at 08:11:37AM +0200, Michal Simek wrote:
> 
> > I sent the patch for it which solve this problem in generic way.
> > http://lkml.org/lkml/2014/4/8/42
> 
> > Feel free to give me ACK for it.
> 
> Will has been working on this too off and on, he was also trying to
> define some semantics for the relaxed versions.  It'd be really good to
> address this properly, this is a constant source of make work.

Yes, I have a series adding relaxed accessors to all architectures (and
asm-generic) along with an attempt at defining some semantics. This came
about from discussion with BenH at the last kernel summit, I just didn't get
around to posting what we came up with.

I should be able to post something this week, but there's still an open
question relating to mmiowb() that I'd like the PPC guys to chime in on.

Will

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ
@ 2014-04-15 16:26       ` Will Deacon
  0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2014-04-15 16:26 UTC (permalink / raw)
  To: Mark Brown
  Cc: Michal Simek, Harini Katakam, linux-spi-u79uwXL29TY76Z2rM5mHXA,
	LKML, Michal Simek

On Tue, Apr 15, 2014 at 10:45:41AM +0100, Mark Brown wrote:
> On Tue, Apr 15, 2014 at 08:11:37AM +0200, Michal Simek wrote:
> 
> > I sent the patch for it which solve this problem in generic way.
> > http://lkml.org/lkml/2014/4/8/42
> 
> > Feel free to give me ACK for it.
> 
> Will has been working on this too off and on, he was also trying to
> define some semantics for the relaxed versions.  It'd be really good to
> address this properly, this is a constant source of make work.

Yes, I have a series adding relaxed accessors to all architectures (and
asm-generic) along with an attempt at defining some semantics. This came
about from discussion with BenH at the last kernel summit, I just didn't get
around to posting what we came up with.

I should be able to post something this week, but there's still an open
question relating to mmiowb() that I'd like the PPC guys to chime in on.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-15 16:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-15  4:49 [PATCH] spi: cadence: Add dependency on ARCH_ZYNQ Harini Katakam
2014-04-15  4:49 ` Harini Katakam
     [not found] ` <CAHTX3dJrMxWJ-8i-wLRkQYtR_zbA+nJyGW+r-DFMYHHU4Erzbw@mail.gmail.com>
2014-04-15  9:45   ` Mark Brown
2014-04-15 16:26     ` Will Deacon
2014-04-15 16:26       ` Will Deacon
2014-04-15  9:49 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.