[PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

[PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

[Xiubo Li]

The pit_read_sched_clock mean to getting the current counter value,
and the vf pit timer is a down count timer, this should return
the counter value or the cycles elapsed.

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
 drivers/clocksource/vf_pit_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/vf_pit_timer.c b/drivers/clocksource/vf_pit_timer.c
index 02821b0..a918bc4 100644
--- a/drivers/clocksource/vf_pit_timer.c
+++ b/drivers/clocksource/vf_pit_timer.c
@@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void)
 
 static u64 pit_read_sched_clock(void)
 {
-	return __raw_readl(clksrc_base + PITCVAL);
+	return ~__raw_readl(clksrc_base + PITCVAL);
 }
 
 static int __init pit_clocksource_init(unsigned long rate)
-- 
1.8.4

Re: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

[Daniel Lezcano]

On 04/15/2014 12:48 PM, Xiubo Li wrote:
> The pit_read_sched_clock mean to getting the current counter value,
> and the vf pit timer is a down count timer, this should return
> the counter value or the cycles elapsed.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>   drivers/clocksource/vf_pit_timer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/vf_pit_timer.c b/drivers/clocksource/vf_pit_timer.c
> index 02821b0..a918bc4 100644
> --- a/drivers/clocksource/vf_pit_timer.c
> +++ b/drivers/clocksource/vf_pit_timer.c
> @@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void)
>
>   static u64 pit_read_sched_clock(void)
>   {
> -	return __raw_readl(clksrc_base + PITCVAL);
> +	return ~__raw_readl(clksrc_base + PITCVAL);
>   }
>
>   static int __init pit_clocksource_init(unsigned long rate)
>

Hi Xiubo,

thanks for the patch but this has already been fixed [1] and is 
available in the timers/urgent branch.

Thanks

   -- Daniel

[1] 
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=224aa3ed45c8735ae02bb2ecca002409fa6aa772
-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

[Thomas Gleixner]

On Tue, 15 Apr 2014, Daniel Lezcano wrote:
> On 04/15/2014 12:48 PM, Xiubo Li wrote:
> > The pit_read_sched_clock mean to getting the current counter value,
> > and the vf pit timer is a down count timer, this should return
> > the counter value or the cycles elapsed.
> > 
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> >   drivers/clocksource/vf_pit_timer.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clocksource/vf_pit_timer.c
> > b/drivers/clocksource/vf_pit_timer.c
> > index 02821b0..a918bc4 100644
> > --- a/drivers/clocksource/vf_pit_timer.c
> > +++ b/drivers/clocksource/vf_pit_timer.c
> > @@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void)
> > 
> >   static u64 pit_read_sched_clock(void)
> >   {
> > -	return __raw_readl(clksrc_base + PITCVAL);
> > +	return ~__raw_readl(clksrc_base + PITCVAL);
> >   }
> > 
> >   static int __init pit_clocksource_init(unsigned long rate)
> > 
> 
> Hi Xiubo,
> 
> thanks for the patch but this has already been fixed [1] and is available in
> the timers/urgent branch.

It's in Linus tree already and tagged for stable.

Thanks,

	tglx

RE: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

[Li.Xiubo]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 858 bytes --]


> > diff --git a/drivers/clocksource/vf_pit_timer.c
> b/drivers/clocksource/vf_pit_timer.c
> > index 02821b0..a918bc4 100644
> > --- a/drivers/clocksource/vf_pit_timer.c
> > +++ b/drivers/clocksource/vf_pit_timer.c
> > @@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void)
> >
> >   static u64 pit_read_sched_clock(void)
> >   {
> > -	return __raw_readl(clksrc_base + PITCVAL);
> > +	return ~__raw_readl(clksrc_base + PITCVAL);
> >   }
> >
> >   static int __init pit_clocksource_init(unsigned long rate)
> >
> 
> Hi Xiubo,
> 
> thanks for the patch but this has already been fixed [1] and is
> available in the timers/urgent branch.
> 

Good news and I will pull it.

Thanks,

BRs
Xiubo
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

RE: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

[Li.Xiubo]

> >
> > thanks for the patch but this has already been fixed [1] and is available in
> > the timers/urgent branch.
> 
> It's in Linus tree already and tagged for stable.
> 

Yes, I have found it, I was developing this in the old tree...
:)

Thanks,

BRs
Xiubo