[Buildroot] [PATCH 1/1] libsoxr: new package

[Buildroot] [PATCH 1/1] libsoxr: new package

[Hadrien Boutteville]

Building tests fails mainly because of the cross-compilation, so they
are disabled for the moment.

Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
---
 package/Config.in          |  1 +
 package/libsoxr/Config.in  | 16 ++++++++++++++++
 package/libsoxr/libsoxr.mk | 24 ++++++++++++++++++++++++
 3 files changed, 41 insertions(+)
 create mode 100644 package/libsoxr/Config.in
 create mode 100644 package/libsoxr/libsoxr.mk

diff --git a/package/Config.in b/package/Config.in
index 748d28e..f04e422 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -505,6 +505,7 @@ source "package/libmpd/Config.in"
 source "package/libreplaygain/Config.in"
 source "package/libsamplerate/Config.in"
 source "package/libsndfile/Config.in"
+source "package/libsoxr/Config.in"
 source "package/libvorbis/Config.in"
 source "package/opus/Config.in"
 source "package/portaudio/Config.in"
diff --git a/package/libsoxr/Config.in b/package/libsoxr/Config.in
new file mode 100644
index 0000000..ad6f8dd
--- /dev/null
+++ b/package/libsoxr/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_LIBSOXR
+	bool "libsoxr"
+	help
+	  The SoX Resampler library `libsoxr' performs one-dimensional
+	  sample-rate conversion?it may be used, for example, to
+	  resample PCM-encoded audio.
+
+	  It aims to give fast and high quality results for any constant
+	  (rational or irrational) resampling ratio. Phase-response,
+	  preserved bandwidth, aliasing, and rejection level parameters
+	  are all configurable; alternatively, simple `preset'
+	  configurations may be selected. An experimental, variable-rate
+	  resampling mode of operation is also included.
+
+	  http://sourceforge.net/projects/soxr/
+
diff --git a/package/libsoxr/libsoxr.mk b/package/libsoxr/libsoxr.mk
new file mode 100644
index 0000000..c0fb72b
--- /dev/null
+++ b/package/libsoxr/libsoxr.mk
@@ -0,0 +1,24 @@
+################################################################################
+#
+# libsoxr
+#
+################################################################################
+
+LIBSOXR_VERSION = 0.1.1
+LIBSOXR_SITE = git://git.code.sf.net/p/soxr/code
+LIBSOXR_LICENSE = LGPLv2.1
+LIBSOXR_LICENSE_FILES = LICENCE COPYING.LGPL
+LIBSOXR_INSTALL_STAGING = YES
+LIBSOXR_CONF_OPT = -DWITH_OPENMP:BOOL=OFF -DBUILD_TESTS:BOOL=OFF
+
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+LIBSOXR_CONF_OPT += -DBUILD_SHARED_LIBS:BOOL=OFF
+endif
+
+ifeq ($(BR2_ENDIAN),"BIG")
+LIBSOXR_CONF_OPT += -DHAVE_WORDS_BIGENDIAN=1
+else
+LIBSOXR_CONF_OPT += -DHAVE_WORDS_BIGENDIAN=0
+endif
+
+$(eval $(cmake-package))

[Buildroot] [PATCH 1/1] libsoxr: new package

[Thomas De Schampheleire]

Hadrien Boutteville <hadrien.boutteville@gmail.com> schreef:
>Building tests fails mainly because of the cross-compilation, so they
>are disabled for the moment.
>
>Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
>---
> package/Config.in          |  1 +
> package/libsoxr/Config.in  | 16 ++++++++++++++++
> package/libsoxr/libsoxr.mk | 24 ++++++++++++++++++++++++
> 3 files changed, 41 insertions(+)
> create mode 100644 package/libsoxr/Config.in
> create mode 100644 package/libsoxr/libsoxr.mk
>
>diff --git a/package/Config.in b/package/Config.in
>index 748d28e..f04e422 100644
>--- a/package/Config.in
>+++ b/package/Config.in
>@@ -505,6 +505,7 @@ source "package/libmpd/Config.in"
> source "package/libreplaygain/Config.in"
> source "package/libsamplerate/Config.in"
> source "package/libsndfile/Config.in"
>+source "package/libsoxr/Config.in"
> source "package/libvorbis/Config.in"
> source "package/opus/Config.in"
> source "package/portaudio/Config.in"
>diff --git a/package/libsoxr/Config.in b/package/libsoxr/Config.in
>new file mode 100644
>index 0000000..ad6f8dd
>--- /dev/null
>+++ b/package/libsoxr/Config.in
>@@ -0,0 +1,16 @@
>+config BR2_PACKAGE_LIBSOXR
>+	bool "libsoxr"
>+	help
>+	  The SoX Resampler library `libsoxr' performs one-dimensional
>+	  sample-rate conversion?it may be used, for example, to
>+	  resample PCM-encoded audio.
>+
>+	  It aims to give fast and high quality results for any constant
>+	  (rational or irrational) resampling ratio. Phase-response,
>+	  preserved bandwidth, aliasing, and rejection level parameters
>+	  are all configurable; alternatively, simple `preset'
>+	  configurations may be selected. An experimental, variable-rate
>+	  resampling mode of operation is also included.
>+
>+	  http://sourceforge.net/projects/soxr/
>+
>diff --git a/package/libsoxr/libsoxr.mk b/package/libsoxr/libsoxr.mk
>new file mode 100644
>index 0000000..c0fb72b
>--- /dev/null
>+++ b/package/libsoxr/libsoxr.mk
>@@ -0,0 +1,24 @@
>+################################################################################
>+#
>+# libsoxr
>+#
>+################################################################################
>+
>+LIBSOXR_VERSION = 0.1.1
>+LIBSOXR_SITE = git://git.code.sf.net/p/soxr/code
>+LIBSOXR_LICENSE = LGPLv2.1
>+LIBSOXR_LICENSE_FILES = LICENCE COPYING.LGPL
>+LIBSOXR_INSTALL_STAGING = YES
>+LIBSOXR_CONF_OPT = -DWITH_OPENMP:BOOL=OFF -DBUILD_TESTS:BOOL=OFF
>+
>+ifeq ($(BR2_PREFER_STATIC_LIB),y)
>+LIBSOXR_CONF_OPT += -DBUILD_SHARED_LIBS:BOOL=OFF
>+endif
>+
>+ifeq ($(BR2_ENDIAN),"BIG")

Use 
ifeq ($(call qstrip,$(BR2_ENDIAN) ),BIG) 
instead..

Best regards,
Thomas

[Buildroot] [PATCH 1/1] libsoxr: new package

[Thomas Petazzoni]

Dear Hadrien Boutteville,

On Sat, 19 Apr 2014 02:32:33 +0200, Hadrien Boutteville wrote:
> Building tests fails mainly because of the cross-compilation, so they
> are disabled for the moment.
> 
> Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>

Thanks, this is looking good. A few comments below.


> diff --git a/package/libsoxr/Config.in b/package/libsoxr/Config.in
> new file mode 100644
> index 0000000..ad6f8dd
> --- /dev/null
> +++ b/package/libsoxr/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_LIBSOXR
> +	bool "libsoxr"

Really no toolchain dependencies? Can you test this package with the
following toolchain configurations:

 http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-linux-uclibc.config
  -> this one tests !MMU

 http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-uclinux.config
  -> this one tests !MMU and static library only

 http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config
  -> this one tests the absence of thread support

 http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
  -> and this one tests a minimal toolchain


> diff --git a/package/libsoxr/libsoxr.mk b/package/libsoxr/libsoxr.mk
> new file mode 100644
> index 0000000..c0fb72b
> --- /dev/null
> +++ b/package/libsoxr/libsoxr.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# libsoxr
> +#
> +################################################################################
> +
> +LIBSOXR_VERSION = 0.1.1
> +LIBSOXR_SITE = git://git.code.sf.net/p/soxr/code

The project apparently provides a tarball. Could you use the tarball
instead of the Git repository?

> +LIBSOXR_LICENSE = LGPLv2.1

According to the LICENSE file, the license is LGPLv2.1+

> +LIBSOXR_LICENSE_FILES = LICENCE COPYING.LGPL
> +LIBSOXR_INSTALL_STAGING = YES

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libsoxr: new package

[Hadrien Boutteville]

Hello Thomas,

On Sat, 19 Apr 2014 09:52:42 +0200, Thomas Petazzoni wrote:
> Really no toolchain dependencies? Can you test this package with the
> following toolchain configurations:
> 
>  http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-linux-uclibc.config
>   -> this one tests !MMU
> 
>  http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-uclinux.config
>   -> this one tests !MMU and static library only
> 
>  http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config
>   -> this one tests the absence of thread support
> 
>  http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
>   -> and this one tests a minimal toolchain
> 

I packaged it with minimal toolchain configuration and checked for these
cases, it built fine. I rebuilt with your configurations and it is
always good.

At first glance the threads references in the code depend on OpenMP, and
I disabled it.

I don't have time today to test the execution with static library and no
thread, I just tested with a standard ARM configuration.

>> diff --git a/package/libsoxr/libsoxr.mk b/package/libsoxr/libsoxr.mk
>> new file mode 100644
>> index 0000000..c0fb72b
>> --- /dev/null
>> +++ b/package/libsoxr/libsoxr.mk
>> @@ -0,0 +1,24 @@
>> +################################################################################
>> +#
>> +# libsoxr
>> +#
>> +################################################################################
>> +
>> +LIBSOXR_VERSION = 0.1.1
>> +LIBSOXR_SITE = git://git.code.sf.net/p/soxr/code
> 
> The project apparently provides a tarball. Could you use the tarball
> instead of the Git repository?

OK. Is it better to always use the tarball if available?

>> +LIBSOXR_LICENSE = LGPLv2.1
> 
> According to the LICENSE file, the license is LGPLv2.1+

Corrected, thanks !

Regards,

Hadrien

[Buildroot] [PATCH 1/1] libsoxr: new package

[Thomas Petazzoni]

Dear Hadrien Boutteville,

On Sat, 19 Apr 2014 12:49:30 +0200, Hadrien Boutteville wrote:

> I packaged it with minimal toolchain configuration and checked for these
> cases, it built fine. I rebuilt with your configurations and it is
> always good.

Good.

> At first glance the threads references in the code depend on OpenMP, and
> I disabled it.
> 
> I don't have time today to test the execution with static library and no
> thread, I just tested with a standard ARM configuration.

That's ok.


> > The project apparently provides a tarball. Could you use the tarball
> > instead of the Git repository?
> 
> OK. Is it better to always use the tarball if available?

Yes. It's typically faster to download, and git:// access can be
problematic in some companies that have stupid firewall/proxy policies.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com