[kexec-tools] [PATCH] Do not distribute generated files in the release tarball

[kexec-tools] [PATCH] Do not distribute generated files in the release tarball

[Paul Wise]

---
 kexec/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kexec/Makefile b/kexec/Makefile
index 7d3175b..a758b4a 100644
--- a/kexec/Makefile
+++ b/kexec/Makefile
@@ -29,7 +29,7 @@ KEXEC_SRCS_base += kexec/kexec-xen.c
 
 KEXEC_GENERATED_SRCS += $(PURGATORY_HEX_C)
 
-dist += kexec/Makefile $(KEXEC_GENERATED_SRCS)			\
+dist += kexec/Makefile						\
 	$(KEXEC_SRCS_base) kexec/crashdump-elf.c		\
 	kexec/crashdump.h kexec/firmware_memmap.h		\
 	kexec/kexec-elf-boot.h					\
-- 
1.9.2


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] [PATCH] Do not distribute generated files in the release tarball

[Simon Horman]

While I'm not opposed to this off-hand I am curious to know what the
motivation for it is.

On Thu, Apr 24, 2014 at 12:20:56PM +0800, Paul Wise wrote:
> ---
>  kexec/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kexec/Makefile b/kexec/Makefile
> index 7d3175b..a758b4a 100644
> --- a/kexec/Makefile
> +++ b/kexec/Makefile
> @@ -29,7 +29,7 @@ KEXEC_SRCS_base += kexec/kexec-xen.c
>  
>  KEXEC_GENERATED_SRCS += $(PURGATORY_HEX_C)
>  
> -dist += kexec/Makefile $(KEXEC_GENERATED_SRCS)			\
> +dist += kexec/Makefile						\
>  	$(KEXEC_SRCS_base) kexec/crashdump-elf.c		\
>  	kexec/crashdump.h kexec/firmware_memmap.h		\
>  	kexec/kexec-elf-boot.h					\
> -- 
> 1.9.2
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] [PATCH] Do not distribute generated files in the release tarball

[Simon Horman]

On Thu, Apr 24, 2014 at 12:46:08PM +0800, Paul Wise wrote:
> On Thu, 2014-04-24 at 13:32 +0900, Simon Horman wrote:
> 
> > While I'm not opposed to this off-hand I am curious to know what the
> > motivation for it is.
> 
> Within Debian there has been a renewed focus on finding and removing
> sourceless files and one Debian contributor mentioned kexec/purgatory.c
> on IRC and asked for help finding if source was missing. It was
> concluded that the source was present and this wasn't an issue....

Thanks, an interesting initiative.

> ..but I tend to think that generated files should always be built from
> source and never be present in VCS repositories and only autotools
> generated files should be in tarballs. This ensures that they get built
> as often as possible and bugs with that process are discovered early.

That seems reasonable to me.

Could you add something like that to the changelog and add
a signed-off-by line?

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] [PATCH] Do not distribute generated files in the release tarball

[Paul Wise]

[-- Attachment #1.1.1: Type: text/plain, Size: 361 bytes --]

On Thu, 2014-04-24 at 14:42 +0900, Simon Horman wrote:

> Thanks, an interesting initiative.

One of the parts of that:

http://lintian.debian.org/tags/source-is-missing.html

> Could you add something like that to the changelog and add
> a signed-off-by line?

Attached a new patch, hope thats OK.

-- 
bye,
pabs

http://bonedaddy.net/pabs3/

[-- Attachment #1.1.2: 0001-Do-not-distribute-generated-files-in-the-release-tar.patch --]
[-- Type: text/x-patch, Size: 1067 bytes --]

From c3437b10008dba491843aa46aa54b860b5e69785 Mon Sep 17 00:00:00 2001
From: Paul Wise <pabs3@bonedaddy.net>
Date: Thu, 24 Apr 2014 12:20:56 +0800
Subject: [PATCH] Do not distribute generated files in the release tarball

Generated files should always be built from source and never be present in
VCS repositories and only autotools generated files should be in tarballs.
This ensures that they get built as often as possible and bugs with that
process are discovered early.

Signed-off-by: Paul Wise <pabs3@bonedaddy.net>
---
 kexec/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kexec/Makefile b/kexec/Makefile
index 7d3175b..a758b4a 100644
--- a/kexec/Makefile
+++ b/kexec/Makefile
@@ -29,7 +29,7 @@ KEXEC_SRCS_base += kexec/kexec-xen.c
 
 KEXEC_GENERATED_SRCS += $(PURGATORY_HEX_C)
 
-dist += kexec/Makefile $(KEXEC_GENERATED_SRCS)			\
+dist += kexec/Makefile						\
 	$(KEXEC_SRCS_base) kexec/crashdump-elf.c		\
 	kexec/crashdump.h kexec/firmware_memmap.h		\
 	kexec/kexec-elf-boot.h					\
-- 
1.9.2


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [kexec-tools] [PATCH] Do not distribute generated files in the release tarball

[Simon Horman]

On Thu, Apr 24, 2014 at 02:42:16PM +0800, Paul Wise wrote:
> On Thu, 2014-04-24 at 14:42 +0900, Simon Horman wrote:
> 
> > Thanks, an interesting initiative.
> 
> One of the parts of that:
> 
> http://lintian.debian.org/tags/source-is-missing.html
> 
> > Could you add something like that to the changelog and add
> > a signed-off-by line?
> 
> Attached a new patch, hope thats OK.

Thanks, applied.




_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec