All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY
@ 2014-04-26  4:52 Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 2/8] ARM: dts: imx27-phytec-phycore-som: Fix active level for FEC reset Alexander Shiyan
                   ` (7 more replies)
  0 siblings, 8 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

"compatible", "#address-cells" and "#size-cells" for USB PHY are
already described in the SOM DTS. Remove these duplicate entries.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
index 0875327..ac18ccf 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
@@ -39,10 +39,6 @@
 	};
 
 	usbphy {
-		compatible = "simple-bus";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
 		usbphy2: usbphy at 2 {
 			compatible = "usb-nop-xceiv";
 			reg = <0>;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/8] ARM: dts: imx27-phytec-phycore-som: Fix active level for FEC reset
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 3/8] ARM: dts: imx27-phytec-phycore-som: Disable PM pins for USB OTG Alexander Shiyan
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

FEC reset GPIO is active low. Fix this typo.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
index 32cc7dac9a..93482e9 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
@@ -182,7 +182,7 @@
 
 &fec {
 	phy-mode = "mii";
-	phy-reset-gpios = <&gpio3 30 GPIO_ACTIVE_HIGH>;
+	phy-reset-gpios = <&gpio3 30 GPIO_ACTIVE_LOW>;
 	phy-supply = <&reg_3v3>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec1>;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 3/8] ARM: dts: imx27-phytec-phycore-som: Disable PM pins for USB OTG
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 2/8] ARM: dts: imx27-phytec-phycore-som: Fix active level for FEC reset Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 4/8] ARM: dts: imx: Remove excess entries for PMIC Alexander Shiyan
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

USB PWR and OC pins are used as GPIOs for different purposes,
so add "disable-over-current" property for OTG node to indicate this.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
index 93482e9..b81796c 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
@@ -323,6 +323,7 @@
 	phy_type = "ulpi";
 	fsl,usbphy = <&usbphy0>;
 	vbus-supply = <&sw3_reg>;
+	disable-over-current;
 	status = "okay";
 };
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 4/8] ARM: dts: imx: Remove excess entries for PMIC
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 2/8] ARM: dts: imx27-phytec-phycore-som: Fix active level for FEC reset Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 3/8] ARM: dts: imx27-phytec-phycore-som: Disable PM pins for USB OTG Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 5/8] ARM: dts: imx27-phytec-phycore-rdk: Add CSI enable switch Alexander Shiyan
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

This patch removes excess "#address-cells" and "#size-cells" entries
for PMIC, since these entries is not used.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-pdk.dts                 | 2 --
 arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi | 2 --
 arch/arm/boot/dts/imx51-babbage.dts             | 2 --
 3 files changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts
index 764cf79..4c31771 100644
--- a/arch/arm/boot/dts/imx27-pdk.dts
+++ b/arch/arm/boot/dts/imx27-pdk.dts
@@ -42,8 +42,6 @@
 	status = "okay";
 
 	pmic: mc13783 at 0 {
-		#address-cells = <1>;
-		#size-cells = <0>;
 		compatible = "fsl,mc13783";
 		reg = <0>;
 		spi-cs-high;
diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
index b81796c..31e9f70 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
@@ -80,8 +80,6 @@
 	status = "okay";
 
 	pmic: mc13783 at 0 {
-		#address-cells = <1>;
-		#size-cells = <0>;
 		compatible = "fsl,mc13783";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
index e9ce0c0..89470bf 100644
--- a/arch/arm/boot/dts/imx51-babbage.dts
+++ b/arch/arm/boot/dts/imx51-babbage.dts
@@ -191,8 +191,6 @@
 	status = "okay";
 
 	pmic: mc13892 at 0 {
-		#address-cells = <1>;
-		#size-cells = <0>;
 		compatible = "fsl,mc13892";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 5/8] ARM: dts: imx27-phytec-phycore-rdk: Add CSI enable switch
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
                   ` (2 preceding siblings ...)
  2014-04-26  4:52 ` [PATCH 4/8] ARM: dts: imx: Remove excess entries for PMIC Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 6/8] ARM: dts: imx27-phytec-phycore-rdk: Fix "reg" property for USBH2 PHY Alexander Shiyan
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds a GPIO fixed regulator which used on RDK to
enable CSI bus.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
index ac18ccf..72c773e 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
@@ -38,6 +38,20 @@
 		};
 	};
 
+	regulators {
+		regulator at 2 {
+			compatible = "regulator-fixed";
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_csien>;
+			reg = <2>;
+			regulator-name = "CSI_EN";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio2 24 GPIO_ACTIVE_LOW>;
+			regulator-always-on;
+		};
+	};
+
 	usbphy {
 		usbphy2: usbphy at 2 {
 			compatible = "usb-nop-xceiv";
@@ -83,6 +97,12 @@
 
 &iomuxc {
 	imx27_phycore_rdk {
+		pinctrl_csien: csiengrp {
+			fsl,pins = <
+				MX27_PAD_USB_OC_B__GPIO2_24 0x0
+			>;
+		};
+
 		pinctrl_cspi1cs1: cspi1cs1grp {
 			fsl,pins = <
 				MX27_PAD_CSPI1_SS1__GPIO4_27 0x0
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 6/8] ARM: dts: imx27-phytec-phycore-rdk: Fix "reg" property for USBH2 PHY
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
                   ` (3 preceding siblings ...)
  2014-04-26  4:52 ` [PATCH 5/8] ARM: dts: imx27-phytec-phycore-rdk: Add CSI enable switch Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26  4:52 ` [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC Alexander Shiyan
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
index 72c773e..d0b693f 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
@@ -55,7 +55,7 @@
 	usbphy {
 		usbphy2: usbphy at 2 {
 			compatible = "usb-nop-xceiv";
-			reg = <0>;
+			reg = <2>;
 			vcc-supply = <&reg_5v0>;
 			clocks = <&clks 0>;
 			clock-names = "main_clk";
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
                   ` (4 preceding siblings ...)
  2014-04-26  4:52 ` [PATCH 6/8] ARM: dts: imx27-phytec-phycore-rdk: Fix "reg" property for USBH2 PHY Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26 16:32   ` Sergei Shtylyov
  2014-04-26  4:52 ` [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file Alexander Shiyan
  2014-04-29  6:08 ` [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Shawn Guo
  7 siblings, 1 reply; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

This patch reduce node name for FEC. Otherwise, the name for PHY
is composed incorrectly.

Before:
fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1)

After:
fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1)

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index a75555c..377339e 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -497,7 +497,7 @@
 				clocks = <&clks 38>;
 			};
 
-			fec: ethernet at 1002b000 {
+			fec: fec at 1002b000 {
 				compatible = "fsl,imx27-fec";
 				reg = <0x1002b000 0x4000>;
 				interrupts = <50>;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
                   ` (5 preceding siblings ...)
  2014-04-26  4:52 ` [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC Alexander Shiyan
@ 2014-04-26  4:52 ` Alexander Shiyan
  2014-04-26 19:09   ` Sascha Hauer
  2014-04-29  6:06   ` Shawn Guo
  2014-04-29  6:08 ` [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Shawn Guo
  7 siblings, 2 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26  4:52 UTC (permalink / raw)
  To: linux-arm-kernel

This patch moves "iomux" node to the bottom of file.
No functional changes.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts  | 234 ++++++++++++------------
 arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi | 176 +++++++++---------
 2 files changed, 205 insertions(+), 205 deletions(-)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
index d0b693f..07de457 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
@@ -95,123 +95,6 @@
 	};
 };
 
-&iomuxc {
-	imx27_phycore_rdk {
-		pinctrl_csien: csiengrp {
-			fsl,pins = <
-				MX27_PAD_USB_OC_B__GPIO2_24 0x0
-			>;
-		};
-
-		pinctrl_cspi1cs1: cspi1cs1grp {
-			fsl,pins = <
-				MX27_PAD_CSPI1_SS1__GPIO4_27 0x0
-			>;
-		};
-
-		pinctrl_imxfb1: imxfbgrp {
-			fsl,pins = <
-				MX27_PAD_LD0__LD0 0x0
-				MX27_PAD_LD1__LD1 0x0
-				MX27_PAD_LD2__LD2 0x0
-				MX27_PAD_LD3__LD3 0x0
-				MX27_PAD_LD4__LD4 0x0
-				MX27_PAD_LD5__LD5 0x0
-				MX27_PAD_LD6__LD6 0x0
-				MX27_PAD_LD7__LD7 0x0
-				MX27_PAD_LD8__LD8 0x0
-				MX27_PAD_LD9__LD9 0x0
-				MX27_PAD_LD10__LD10 0x0
-				MX27_PAD_LD11__LD11 0x0
-				MX27_PAD_LD12__LD12 0x0
-				MX27_PAD_LD13__LD13 0x0
-				MX27_PAD_LD14__LD14 0x0
-				MX27_PAD_LD15__LD15 0x0
-				MX27_PAD_LD16__LD16 0x0
-				MX27_PAD_LD17__LD17 0x0
-				MX27_PAD_CLS__CLS 0x0
-				MX27_PAD_CONTRAST__CONTRAST 0x0
-				MX27_PAD_LSCLK__LSCLK 0x0
-				MX27_PAD_OE_ACD__OE_ACD 0x0
-				MX27_PAD_PS__PS 0x0
-				MX27_PAD_REV__REV 0x0
-				MX27_PAD_SPL_SPR__SPL_SPR 0x0
-				MX27_PAD_HSYNC__HSYNC 0x0
-				MX27_PAD_VSYNC__VSYNC 0x0
-			>;
-		};
-
-		pinctrl_i2c1: i2c1grp {
-			/* Add pullup to DATA line */
-			fsl,pins = <
-				MX27_PAD_I2C_DATA__I2C_DATA	0x1
-				MX27_PAD_I2C_CLK__I2C_CLK	0x0
-			>;
-		};
-
-		pinctrl_owire1: owire1grp {
-			fsl,pins = <
-				MX27_PAD_RTCK__OWIRE 0x0
-			>;
-		};
-
-		pinctrl_sdhc2: sdhc2grp {
-			fsl,pins = <
-				MX27_PAD_SD2_CLK__SD2_CLK 0x0
-				MX27_PAD_SD2_CMD__SD2_CMD 0x0
-				MX27_PAD_SD2_D0__SD2_D0 0x0
-				MX27_PAD_SD2_D1__SD2_D1 0x0
-				MX27_PAD_SD2_D2__SD2_D2 0x0
-				MX27_PAD_SD2_D3__SD2_D3 0x0
-				MX27_PAD_SSI3_FS__GPIO3_28	0x0 /* WP */
-				MX27_PAD_SSI3_RXDAT__GPIO3_29	0x0 /* CD */
-			>;
-		};
-
-		pinctrl_uart1: uart1grp {
-			fsl,pins = <
-				MX27_PAD_UART1_TXD__UART1_TXD 0x0
-				MX27_PAD_UART1_RXD__UART1_RXD 0x0
-				MX27_PAD_UART1_CTS__UART1_CTS 0x0
-				MX27_PAD_UART1_RTS__UART1_RTS 0x0
-			>;
-		};
-
-		pinctrl_uart2: uart2grp {
-			fsl,pins = <
-				MX27_PAD_UART2_TXD__UART2_TXD 0x0
-				MX27_PAD_UART2_RXD__UART2_RXD 0x0
-				MX27_PAD_UART2_CTS__UART2_CTS 0x0
-				MX27_PAD_UART2_RTS__UART2_RTS 0x0
-			>;
-		};
-
-		pinctrl_usbh2: usbh2grp {
-			fsl,pins = <
-				MX27_PAD_USBH2_CLK__USBH2_CLK 0x0
-				MX27_PAD_USBH2_DIR__USBH2_DIR 0x0
-				MX27_PAD_USBH2_NXT__USBH2_NXT 0x0
-				MX27_PAD_USBH2_STP__USBH2_STP 0x0
-				MX27_PAD_CSPI2_SCLK__USBH2_DATA0 0x0
-				MX27_PAD_CSPI2_MOSI__USBH2_DATA1 0x0
-				MX27_PAD_CSPI2_MISO__USBH2_DATA2 0x0
-				MX27_PAD_CSPI2_SS1__USBH2_DATA3 0x0
-				MX27_PAD_CSPI2_SS2__USBH2_DATA4 0x0
-				MX27_PAD_CSPI1_SS2__USBH2_DATA5 0x0
-				MX27_PAD_CSPI2_SS0__USBH2_DATA6 0x0
-				MX27_PAD_USBH2_DATA7__USBH2_DATA7 0x0
-			>;
-		};
-
-		pinctrl_weim: weimgrp {
-			fsl,pins = <
-				MX27_PAD_CS4_B__CS4_B		0x0 /* CS4 */
-				MX27_PAD_SD1_D1__GPIO5_19	0x0 /* CAN IRQ */
-			>;
-		};
-	};
-};
-
 &owire {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_owire1>;
@@ -318,3 +201,120 @@
 		fsl,weim-cs-timing = <0x0000dcf6 0x444a0301 0x44443302>;
 	};
 };
+
+&iomuxc {
+	imx27_phycore_rdk {
+		pinctrl_csien: csiengrp {
+			fsl,pins = <
+				MX27_PAD_USB_OC_B__GPIO2_24		0x0
+			>;
+		};
+
+		pinctrl_cspi1cs1: cspi1cs1grp {
+			fsl,pins = <
+				MX27_PAD_CSPI1_SS1__GPIO4_27		0x0
+			>;
+		};
+
+		pinctrl_imxfb1: imxfbgrp {
+			fsl,pins = <
+				MX27_PAD_LD0__LD0			0x0
+				MX27_PAD_LD1__LD1			0x0
+				MX27_PAD_LD2__LD2			0x0
+				MX27_PAD_LD3__LD3			0x0
+				MX27_PAD_LD4__LD4			0x0
+				MX27_PAD_LD5__LD5			0x0
+				MX27_PAD_LD6__LD6			0x0
+				MX27_PAD_LD7__LD7			0x0
+				MX27_PAD_LD8__LD8			0x0
+				MX27_PAD_LD9__LD9			0x0
+				MX27_PAD_LD10__LD10			0x0
+				MX27_PAD_LD11__LD11			0x0
+				MX27_PAD_LD12__LD12			0x0
+				MX27_PAD_LD13__LD13			0x0
+				MX27_PAD_LD14__LD14			0x0
+				MX27_PAD_LD15__LD15			0x0
+				MX27_PAD_LD16__LD16			0x0
+				MX27_PAD_LD17__LD17			0x0
+				MX27_PAD_CLS__CLS			0x0
+				MX27_PAD_CONTRAST__CONTRAST		0x0
+				MX27_PAD_LSCLK__LSCLK			0x0
+				MX27_PAD_OE_ACD__OE_ACD			0x0
+				MX27_PAD_PS__PS				0x0
+				MX27_PAD_REV__REV			0x0
+				MX27_PAD_SPL_SPR__SPL_SPR		0x0
+				MX27_PAD_HSYNC__HSYNC			0x0
+				MX27_PAD_VSYNC__VSYNC			0x0
+			>;
+		};
+
+		pinctrl_i2c1: i2c1grp {
+			/* Use pullup for DATA line */
+			fsl,pins = <
+				MX27_PAD_I2C_DATA__I2C_DATA		0x1
+				MX27_PAD_I2C_CLK__I2C_CLK		0x0
+			>;
+		};
+
+		pinctrl_owire1: owire1grp {
+			fsl,pins = <
+				MX27_PAD_RTCK__OWIRE			0x0
+			>;
+		};
+
+		pinctrl_sdhc2: sdhc2grp {
+			fsl,pins = <
+				MX27_PAD_SD2_CLK__SD2_CLK		0x0
+				MX27_PAD_SD2_CMD__SD2_CMD		0x0
+				MX27_PAD_SD2_D0__SD2_D0			0x0
+				MX27_PAD_SD2_D1__SD2_D1			0x0
+				MX27_PAD_SD2_D2__SD2_D2			0x0
+				MX27_PAD_SD2_D3__SD2_D3			0x0
+				MX27_PAD_SSI3_FS__GPIO3_28		0x0 /* WP */
+				MX27_PAD_SSI3_RXDAT__GPIO3_29		0x0 /* CD */
+			>;
+		};
+
+		pinctrl_uart1: uart1grp {
+			fsl,pins = <
+				MX27_PAD_UART1_TXD__UART1_TXD		0x0
+				MX27_PAD_UART1_RXD__UART1_RXD		0x0
+				MX27_PAD_UART1_CTS__UART1_CTS		0x0
+				MX27_PAD_UART1_RTS__UART1_RTS		0x0
+			>;
+		};
+
+		pinctrl_uart2: uart2grp {
+			fsl,pins = <
+				MX27_PAD_UART2_TXD__UART2_TXD		0x0
+				MX27_PAD_UART2_RXD__UART2_RXD		0x0
+				MX27_PAD_UART2_CTS__UART2_CTS		0x0
+				MX27_PAD_UART2_RTS__UART2_RTS		0x0
+			>;
+		};
+
+		pinctrl_usbh2: usbh2grp {
+			fsl,pins = <
+				MX27_PAD_USBH2_CLK__USBH2_CLK		0x0
+				MX27_PAD_USBH2_DIR__USBH2_DIR		0x0
+				MX27_PAD_USBH2_NXT__USBH2_NXT		0x0
+				MX27_PAD_USBH2_STP__USBH2_STP		0x0
+				MX27_PAD_CSPI2_SCLK__USBH2_DATA0	0x0
+				MX27_PAD_CSPI2_MOSI__USBH2_DATA1	0x0
+				MX27_PAD_CSPI2_MISO__USBH2_DATA2	0x0
+				MX27_PAD_CSPI2_SS1__USBH2_DATA3		0x0
+				MX27_PAD_CSPI2_SS2__USBH2_DATA4		0x0
+				MX27_PAD_CSPI1_SS2__USBH2_DATA5		0x0
+				MX27_PAD_CSPI2_SS0__USBH2_DATA6		0x0
+				MX27_PAD_USBH2_DATA7__USBH2_DATA7	0x0
+			>;
+		};
+
+		pinctrl_weim: weimgrp {
+			fsl,pins = <
+				MX27_PAD_CS4_B__CS4_B			0x0 /* CS4 */
+				MX27_PAD_SD1_D1__GPIO5_19		0x0 /* CAN IRQ */
+			>;
+		};
+	};
+};
diff --git a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
index 31e9f70..1509f00 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi
@@ -210,94 +210,6 @@
 	};
 };
 
-&iomuxc {
-	imx27_phycore_som {
-		pinctrl_cspi1: cspi1grp {
-			fsl,pins = <
-				MX27_PAD_CSPI1_MISO__CSPI1_MISO 0x0
-				MX27_PAD_CSPI1_MOSI__CSPI1_MOSI 0x0
-				MX27_PAD_CSPI1_SCLK__CSPI1_SCLK 0x0
-				MX27_PAD_CSPI1_SS0__GPIO4_28	0x0 /* SPI1 CS0 */
-			>;
-		};
-
-		pinctrl_fec1: fec1grp {
-			fsl,pins = <
-				MX27_PAD_SD3_CMD__FEC_TXD0 0x0
-				MX27_PAD_SD3_CLK__FEC_TXD1 0x0
-				MX27_PAD_ATA_DATA0__FEC_TXD2 0x0
-				MX27_PAD_ATA_DATA1__FEC_TXD3 0x0
-				MX27_PAD_ATA_DATA2__FEC_RX_ER 0x0
-				MX27_PAD_ATA_DATA3__FEC_RXD1 0x0
-				MX27_PAD_ATA_DATA4__FEC_RXD2 0x0
-				MX27_PAD_ATA_DATA5__FEC_RXD3 0x0
-				MX27_PAD_ATA_DATA6__FEC_MDIO 0x0
-				MX27_PAD_ATA_DATA7__FEC_MDC 0x0
-				MX27_PAD_ATA_DATA8__FEC_CRS 0x0
-				MX27_PAD_ATA_DATA9__FEC_TX_CLK 0x0
-				MX27_PAD_ATA_DATA10__FEC_RXD0 0x0
-				MX27_PAD_ATA_DATA11__FEC_RX_DV 0x0
-				MX27_PAD_ATA_DATA12__FEC_RX_CLK 0x0
-				MX27_PAD_ATA_DATA13__FEC_COL 0x0
-				MX27_PAD_ATA_DATA14__FEC_TX_ER 0x0
-				MX27_PAD_ATA_DATA15__FEC_TX_EN 0x0
-				MX27_PAD_SSI3_TXDAT__GPIO3_30	0x0 /* FEC RST */
-			>;
-		};
-
-		pinctrl_i2c2: i2c2grp {
-			fsl,pins = <
-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
-			>;
-		};
-
-		pinctrl_nfc: nfcgrp {
-			fsl,pins = <
-				MX27_PAD_NFRB__NFRB 0x0
-				MX27_PAD_NFCLE__NFCLE 0x0
-				MX27_PAD_NFWP_B__NFWP_B 0x0
-				MX27_PAD_NFCE_B__NFCE_B 0x0
-				MX27_PAD_NFALE__NFALE 0x0
-				MX27_PAD_NFRE_B__NFRE_B 0x0
-				MX27_PAD_NFWE_B__NFWE_B 0x0
-			>;
-		};
-
-		pinctrl_pmic: pmicgrp {
-			fsl,pins = <
-				MX27_PAD_USB_PWR__GPIO2_23	0x0 /* PMIC IRQ */
-			>;
-		};
-
-		pinctrl_ssi1: ssi1grp {
-			fsl,pins = <
-				MX27_PAD_SSI1_FS__SSI1_FS 0x0
-				MX27_PAD_SSI1_RXDAT__SSI1_RXDAT 0x0
-				MX27_PAD_SSI1_TXDAT__SSI1_TXDAT 0x0
-				MX27_PAD_SSI1_CLK__SSI1_CLK 0x0
-			>;
-		};
-
-		pinctrl_usbotg: usbotggrp {
-			fsl,pins = <
-				MX27_PAD_USBOTG_CLK__USBOTG_CLK 0x0
-				MX27_PAD_USBOTG_DIR__USBOTG_DIR 0x0
-				MX27_PAD_USBOTG_NXT__USBOTG_NXT 0x0
-				MX27_PAD_USBOTG_STP__USBOTG_STP 0x0
-				MX27_PAD_USBOTG_DATA0__USBOTG_DATA0 0x0
-				MX27_PAD_USBOTG_DATA1__USBOTG_DATA1 0x0
-				MX27_PAD_USBOTG_DATA2__USBOTG_DATA2 0x0
-				MX27_PAD_USBOTG_DATA3__USBOTG_DATA3 0x0
-				MX27_PAD_USBOTG_DATA4__USBOTG_DATA4 0x0
-				MX27_PAD_USBOTG_DATA5__USBOTG_DATA5 0x0
-				MX27_PAD_USBOTG_DATA6__USBOTG_DATA6 0x0
-				MX27_PAD_USBOTG_DATA7__USBOTG_DATA7 0x0
-			>;
-		};
-	};
-};
-
 &nfc {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_nfc>;
@@ -348,3 +260,91 @@
 		#size-cells = <1>;
 	};
 };
+
+&iomuxc {
+	imx27_phycore_som {
+		pinctrl_cspi1: cspi1grp {
+			fsl,pins = <
+				MX27_PAD_CSPI1_MISO__CSPI1_MISO		0x0
+				MX27_PAD_CSPI1_MOSI__CSPI1_MOSI		0x0
+				MX27_PAD_CSPI1_SCLK__CSPI1_SCLK		0x0
+				MX27_PAD_CSPI1_SS0__GPIO4_28		0x0 /* SPI1 CS0 */
+			>;
+		};
+
+		pinctrl_fec1: fec1grp {
+			fsl,pins = <
+				MX27_PAD_SD3_CMD__FEC_TXD0		0x0
+				MX27_PAD_SD3_CLK__FEC_TXD1		0x0
+				MX27_PAD_ATA_DATA0__FEC_TXD2		0x0
+				MX27_PAD_ATA_DATA1__FEC_TXD3		0x0
+				MX27_PAD_ATA_DATA2__FEC_RX_ER		0x0
+				MX27_PAD_ATA_DATA3__FEC_RXD1		0x0
+				MX27_PAD_ATA_DATA4__FEC_RXD2		0x0
+				MX27_PAD_ATA_DATA5__FEC_RXD3		0x0
+				MX27_PAD_ATA_DATA6__FEC_MDIO		0x0
+				MX27_PAD_ATA_DATA7__FEC_MDC		0x0
+				MX27_PAD_ATA_DATA8__FEC_CRS		0x0
+				MX27_PAD_ATA_DATA9__FEC_TX_CLK		0x0
+				MX27_PAD_ATA_DATA10__FEC_RXD0		0x0
+				MX27_PAD_ATA_DATA11__FEC_RX_DV		0x0
+				MX27_PAD_ATA_DATA12__FEC_RX_CLK		0x0
+				MX27_PAD_ATA_DATA13__FEC_COL		0x0
+				MX27_PAD_ATA_DATA14__FEC_TX_ER		0x0
+				MX27_PAD_ATA_DATA15__FEC_TX_EN		0x0
+				MX27_PAD_SSI3_TXDAT__GPIO3_30		0x0 /* FEC RST */
+			>;
+		};
+
+		pinctrl_i2c2: i2c2grp {
+			fsl,pins = <
+				MX27_PAD_I2C2_SDA__I2C2_SDA		0x0
+				MX27_PAD_I2C2_SCL__I2C2_SCL		0x0
+			>;
+		};
+
+		pinctrl_nfc: nfcgrp {
+			fsl,pins = <
+				MX27_PAD_NFRB__NFRB			0x0
+				MX27_PAD_NFCLE__NFCLE			0x0
+				MX27_PAD_NFWP_B__NFWP_B			0x0
+				MX27_PAD_NFCE_B__NFCE_B			0x0
+				MX27_PAD_NFALE__NFALE			0x0
+				MX27_PAD_NFRE_B__NFRE_B			0x0
+				MX27_PAD_NFWE_B__NFWE_B			0x0
+			>;
+		};
+
+		pinctrl_pmic: pmicgrp {
+			fsl,pins = <
+				MX27_PAD_USB_PWR__GPIO2_23		0x0 /* PMIC IRQ */
+			>;
+		};
+
+		pinctrl_ssi1: ssi1grp {
+			fsl,pins = <
+				MX27_PAD_SSI1_FS__SSI1_FS		0x0
+				MX27_PAD_SSI1_RXDAT__SSI1_RXDAT		0x0
+				MX27_PAD_SSI1_TXDAT__SSI1_TXDAT		0x0
+				MX27_PAD_SSI1_CLK__SSI1_CLK		0x0
+			>;
+		};
+
+		pinctrl_usbotg: usbotggrp {
+			fsl,pins = <
+				MX27_PAD_USBOTG_CLK__USBOTG_CLK		0x0
+				MX27_PAD_USBOTG_DIR__USBOTG_DIR		0x0
+				MX27_PAD_USBOTG_NXT__USBOTG_NXT		0x0
+				MX27_PAD_USBOTG_STP__USBOTG_STP		0x0
+				MX27_PAD_USBOTG_DATA0__USBOTG_DATA0	0x0
+				MX27_PAD_USBOTG_DATA1__USBOTG_DATA1	0x0
+				MX27_PAD_USBOTG_DATA2__USBOTG_DATA2	0x0
+				MX27_PAD_USBOTG_DATA3__USBOTG_DATA3	0x0
+				MX27_PAD_USBOTG_DATA4__USBOTG_DATA4	0x0
+				MX27_PAD_USBOTG_DATA5__USBOTG_DATA5	0x0
+				MX27_PAD_USBOTG_DATA6__USBOTG_DATA6	0x0
+				MX27_PAD_USBOTG_DATA7__USBOTG_DATA7	0x0
+			>;
+		};
+	};
+};
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC
  2014-04-26  4:52 ` [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC Alexander Shiyan
@ 2014-04-26 16:32   ` Sergei Shtylyov
  2014-04-26 16:39     ` Alexander Shiyan
  0 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2014-04-26 16:32 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 26-04-2014 8:52, Alexander Shiyan wrote:

> This patch reduce node name for FEC. Otherwise, the name for PHY
> is composed incorrectly.

> Before:
> fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1)

> After:
> fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1)

> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>   arch/arm/boot/dts/imx27.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index a75555c..377339e 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -497,7 +497,7 @@
>   				clocks = <&clks 38>;
>   			};
>
> -			fec: ethernet at 1002b000 {
> +			fec: fec at 1002b000 {

    The "ethernet" name complies to the ePAPR standard. Don't change it, please.

WBR, Sergei

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC
  2014-04-26 16:32   ` Sergei Shtylyov
@ 2014-04-26 16:39     ` Alexander Shiyan
  2014-04-26 16:54       ` Sergei Shtylyov
  0 siblings, 1 reply; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26 16:39 UTC (permalink / raw)
  To: linux-arm-kernel

Sat, 26 Apr 2014 20:32:18 +0400 ?? Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
> Hello.
> 
> On 26-04-2014 8:52, Alexander Shiyan wrote:
> 
> > This patch reduce node name for FEC. Otherwise, the name for PHY
> > is composed incorrectly.
> 
> > Before:
> > fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1)
> 
> > After:
> > fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1)
> 
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >   arch/arm/boot/dts/imx27.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index a75555c..377339e 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -497,7 +497,7 @@
> >   				clocks = <&clks 38>;
> >   			};
> >
> > -			fec: ethernet at 1002b000 {
> > +			fec: fec at 1002b000 {
> 
>     The "ethernet" name complies to the ePAPR standard. Don't change it, please.

So this is ok?
mii_bus:phy_addr=1002b000.etherne:00

---

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC
  2014-04-26 16:39     ` Alexander Shiyan
@ 2014-04-26 16:54       ` Sergei Shtylyov
  2014-04-26 17:04         ` Alexander Shiyan
  0 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2014-04-26 16:54 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 26-04-2014 20:39, Alexander Shiyan wrote:

>>> This patch reduce node name for FEC. Otherwise, the name for PHY
>>> is composed incorrectly.

>>> Before:
>>> fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1)

>>> After:
>>> fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1)

>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>> ---
>>>    arch/arm/boot/dts/imx27.dtsi | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)

>>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
>>> index a75555c..377339e 100644
>>> --- a/arch/arm/boot/dts/imx27.dtsi
>>> +++ b/arch/arm/boot/dts/imx27.dtsi
>>> @@ -497,7 +497,7 @@
>>>    				clocks = <&clks 38>;
>>>    			};
>>>
>>> -			fec: ethernet at 1002b000 {
>>> +			fec: fec at 1002b000 {

>>      The "ethernet" name complies to the ePAPR standard. Don't change it, please.

> So this is ok?
> mii_bus:phy_addr=1002b000.etherne:00

    Why not? :-)

WBR, Sergei

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC
  2014-04-26 16:54       ` Sergei Shtylyov
@ 2014-04-26 17:04         ` Alexander Shiyan
  0 siblings, 0 replies; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26 17:04 UTC (permalink / raw)
  To: linux-arm-kernel

Sat, 26 Apr 2014 20:54:11 +0400 ?? Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
> Hello.
> 
> On 26-04-2014 20:39, Alexander Shiyan wrote:
> 
> >>> This patch reduce node name for FEC. Otherwise, the name for PHY
> >>> is composed incorrectly.
> 
> >>> Before:
> >>> fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1)
> 
> >>> After:
> >>> fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1)
> 
> >>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> >>> ---
> >>>    arch/arm/boot/dts/imx27.dtsi | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> >>> index a75555c..377339e 100644
> >>> --- a/arch/arm/boot/dts/imx27.dtsi
> >>> +++ b/arch/arm/boot/dts/imx27.dtsi
> >>> @@ -497,7 +497,7 @@
> >>>    				clocks = <&clks 38>;
> >>>    			};
> >>>
> >>> -			fec: ethernet at 1002b000 {
> >>> +			fec: fec at 1002b000 {
> 
> >>      The "ethernet" name complies to the ePAPR standard. Don't change it, please.
> 
> > So this is ok?
> > mii_bus:phy_addr=1002b000.etherne:00
> 
>     Why not? :-)

OK if so. Shawn, please skip this one patch if all other looks OK.

---

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file
  2014-04-26  4:52 ` [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file Alexander Shiyan
@ 2014-04-26 19:09   ` Sascha Hauer
  2014-04-26 19:15     ` Alexander Shiyan
  2014-04-29  6:06   ` Shawn Guo
  1 sibling, 1 reply; 17+ messages in thread
From: Sascha Hauer @ 2014-04-26 19:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Apr 26, 2014 at 08:52:13AM +0400, Alexander Shiyan wrote:
> This patch moves "iomux" node to the bottom of file.
> No functional changes.

Why? The nodes are (at least should be) sorted alphabetically.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file
  2014-04-26 19:09   ` Sascha Hauer
@ 2014-04-26 19:15     ` Alexander Shiyan
  2014-04-27  6:53       ` Sascha Hauer
  0 siblings, 1 reply; 17+ messages in thread
From: Alexander Shiyan @ 2014-04-26 19:15 UTC (permalink / raw)
  To: linux-arm-kernel

Sat, 26 Apr 2014 21:09:35 +0200 ?? Sascha Hauer <s.hauer@pengutronix.de>:
> On Sat, Apr 26, 2014 at 08:52:13AM +0400, Alexander Shiyan wrote:
> > This patch moves "iomux" node to the bottom of file.
> > No functional changes.
> 
> Why? The nodes are (at least should be) sorted alphabetically.

Pin definitions look better in one place, at the bottom.
As far as I know, Shawn supported this position.

---

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file
  2014-04-26 19:15     ` Alexander Shiyan
@ 2014-04-27  6:53       ` Sascha Hauer
  0 siblings, 0 replies; 17+ messages in thread
From: Sascha Hauer @ 2014-04-27  6:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Apr 26, 2014 at 11:15:10PM +0400, Alexander Shiyan wrote:
> Sat, 26 Apr 2014 21:09:35 +0200 ?? Sascha Hauer <s.hauer@pengutronix.de>:
> > On Sat, Apr 26, 2014 at 08:52:13AM +0400, Alexander Shiyan wrote:
> > > This patch moves "iomux" node to the bottom of file.
> > > No functional changes.
> > 
> > Why? The nodes are (at least should be) sorted alphabetically.
> 
> Pin definitions look better in one place, at the bottom.
> As far as I know, Shawn supported this position.

If that's the way we want to go then ok. I wasn't aware of this.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file
  2014-04-26  4:52 ` [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file Alexander Shiyan
  2014-04-26 19:09   ` Sascha Hauer
@ 2014-04-29  6:06   ` Shawn Guo
  1 sibling, 0 replies; 17+ messages in thread
From: Shawn Guo @ 2014-04-29  6:06 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Apr 26, 2014 at 08:52:13AM +0400, Alexander Shiyan wrote:
> This patch moves "iomux" node to the bottom of file.

Let's only do this for new files, and save the churn on the existing
files.

Shawn

> No functional changes.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts  | 234 ++++++++++++------------
>  arch/arm/boot/dts/imx27-phytec-phycore-som.dtsi | 176 +++++++++---------
>  2 files changed, 205 insertions(+), 205 deletions(-)

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY
  2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
                   ` (6 preceding siblings ...)
  2014-04-26  4:52 ` [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file Alexander Shiyan
@ 2014-04-29  6:08 ` Shawn Guo
  7 siblings, 0 replies; 17+ messages in thread
From: Shawn Guo @ 2014-04-29  6:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Apr 26, 2014 at 08:52:06AM +0400, Alexander Shiyan wrote:
> "compatible", "#address-cells" and "#size-cells" for USB PHY are
> already described in the SOM DTS. Remove these duplicate entries.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Applied 1 ~ 6, thanks.

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2014-04-29  6:08 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-26  4:52 [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Alexander Shiyan
2014-04-26  4:52 ` [PATCH 2/8] ARM: dts: imx27-phytec-phycore-som: Fix active level for FEC reset Alexander Shiyan
2014-04-26  4:52 ` [PATCH 3/8] ARM: dts: imx27-phytec-phycore-som: Disable PM pins for USB OTG Alexander Shiyan
2014-04-26  4:52 ` [PATCH 4/8] ARM: dts: imx: Remove excess entries for PMIC Alexander Shiyan
2014-04-26  4:52 ` [PATCH 5/8] ARM: dts: imx27-phytec-phycore-rdk: Add CSI enable switch Alexander Shiyan
2014-04-26  4:52 ` [PATCH 6/8] ARM: dts: imx27-phytec-phycore-rdk: Fix "reg" property for USBH2 PHY Alexander Shiyan
2014-04-26  4:52 ` [PATCH 7/8] ARM: dts: imx27: Trim node name for FEC Alexander Shiyan
2014-04-26 16:32   ` Sergei Shtylyov
2014-04-26 16:39     ` Alexander Shiyan
2014-04-26 16:54       ` Sergei Shtylyov
2014-04-26 17:04         ` Alexander Shiyan
2014-04-26  4:52 ` [PATCH 8/8] ARM: dts: imx27-phytec-phycore-*: Move "iomux" node to the bottom of file Alexander Shiyan
2014-04-26 19:09   ` Sascha Hauer
2014-04-26 19:15     ` Alexander Shiyan
2014-04-27  6:53       ` Sascha Hauer
2014-04-29  6:06   ` Shawn Guo
2014-04-29  6:08 ` [PATCH 1/8] ARM: dts: imx27-phytec-phycore-rdk: Remove duplicate entries for USB PHY Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.