All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	tim@xen.org, Xiantao Zhang <xiantao.zhang@intel.com>,
	stefano.stabellini@citrix.com
Subject: Re: [PATCH v4 15/21] xen/passthrough: Introduce IOMMU ARM architecture
Date: Mon, 28 Apr 2014 15:04:55 +0100	[thread overview]
Message-ID: <1398693895.29700.123.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1398172475-27873-16-git-send-email-julien.grall@linaro.org>

On Tue, 2014-04-22 at 14:14 +0100, Julien Grall wrote:
>      kinfo.unassigned_mem = dom0_mem;
>  
>      rc = kernel_probe(&kinfo);
> +

Please drop this new blank line.

>      if ( rc < 0 )
>          return rc;
>  

> diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
> new file mode 100644
> index 0000000..5d27b35
> --- /dev/null
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -0,0 +1,72 @@
> +/*
> + * xen/drivers/passthrough/arm/iommu.c

At least the path is right this time, but IMHO all these can be dropped.

> +void __init iommu_set_ops(const struct iommu_ops *ops)
> +{
> +    BUG_ON(ops == NULL);
> +
> +    if ( iommu_ops && iommu_ops != ops )
> +        printk("WARNING: IOMMU ops already set to a different value\n");

"WARNING: Cannot set IOMMU ops, already set to a different value" ?

Other than those nits: Acked-by: Ian Campbell <ian.campbell@citrix.com>

  reply	other threads:[~2014-04-28 14:05 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 13:14 [PATCH v4 00/21] IOMMU support for ARM Julien Grall
2014-04-22 13:14 ` [PATCH v4 01/21] xen/arm: map_device: Don't hardcode dom0 in print message Julien Grall
2014-04-28 13:49   ` Ian Campbell
2014-04-22 13:14 ` [PATCH v4 02/21] xen/arm: Constify address pointer for cache helpers Julien Grall
2014-04-28 13:52   ` Ian Campbell
2014-04-22 13:14 ` [PATCH v4 03/21] xen/arm: p2m: Move comment that was misplaced Julien Grall
2014-04-28 13:52   ` Ian Campbell
2014-04-22 13:14 ` [PATCH v4 04/21] xen/arm: p2m: apply_p2m_changes: Only load domain P2M when we flush TLBs Julien Grall
2014-04-28 13:54   ` Ian Campbell
2014-04-28 13:57     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 05/21] xen/common: grant-table: only call IOMMU if paging mode translate is disabled Julien Grall
2014-04-22 13:14 ` [PATCH v4 06/21] xen/passthrough: amd: Remove domain_id from hvm_iommu Julien Grall
2014-04-28 16:38   ` Julien Grall
2014-04-29  7:43     ` Jan Beulich
2014-04-30  4:02       ` Suravee Suthikulpanit
2014-04-30  3:56   ` Suravee Suthikulpanit
2014-04-30 11:32     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 07/21] xen/passthrough: amd: rename iommu_has_feature into amd_iommu_has_feature Julien Grall
2014-04-28 13:56   ` Ian Campbell
2014-04-28 16:38   ` Julien Grall
2014-05-02 13:11     ` Julien Grall
2014-05-02 16:35       ` Aravind Gopalakrishnan
2014-04-22 13:14 ` [PATCH v4 08/21] xen/passthrough: vtd: iommu_set_hwdom_mapping is VTD specific Julien Grall
2014-04-22 13:41   ` Jan Beulich
2014-04-22 14:47     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 09/21] xen/dts: Add dt_property_read_bool Julien Grall
2014-04-22 13:14 ` [PATCH v4 10/21] xen/dts: Add dt_parse_phandle_with_args and dt_parse_phandle Julien Grall
2014-04-22 13:14 ` [PATCH v4 11/21] xen/passthrough: rework hwdom_pvh_reqs to use it also on ARM Julien Grall
2014-04-28 13:57   ` Ian Campbell
2014-04-22 13:14 ` [PATCH v4 12/21] xen/passthrough: iommu: Split generic IOMMU code Julien Grall
2014-04-22 13:48   ` Jan Beulich
2014-04-22 13:52     ` Jan Beulich
2014-04-22 14:58     ` Julien Grall
2014-04-22 16:33       ` Jan Beulich
2014-04-22 16:45         ` Julien Grall
2014-04-22 16:59           ` Jan Beulich
2014-04-22 18:02             ` Julien Grall
2014-04-23  8:43               ` Jan Beulich
2014-04-23 12:42                 ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 13/21] xen/passthrough: iommu: Introduce arch specific code Julien Grall
2014-04-28 16:39   ` Julien Grall
     [not found]   ` <CAAAAutDRYoqdSBdDsETqtzVDdXmy6jq1Jnm1ck8c5eTqbkMUFw@mail.gmail.com>
2014-05-05 21:12     ` Fwd: " Aravind Gopalakrishnan
2014-04-22 13:14 ` [PATCH v4 14/21] xen/passthrough: iommu: Basic support of device tree assignment Julien Grall
2014-04-28 14:01   ` Ian Campbell
2014-04-28 14:12     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 15/21] xen/passthrough: Introduce IOMMU ARM architecture Julien Grall
2014-04-28 14:04   ` Ian Campbell [this message]
2014-04-28 14:21     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 16/21] MAINTAINERS: Add drivers/passthrough/arm Julien Grall
2014-04-22 13:50   ` Jan Beulich
2014-04-22 15:02     ` Julien Grall
2014-04-22 16:35       ` Jan Beulich
2014-04-22 18:02         ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 17/21] xen/arm: Don't give IOMMU devices to dom0 when iommu is disabled Julien Grall
2014-04-22 13:14 ` [PATCH v4 18/21] xen/arm: p2m: Clean cache PT when the IOMMU doesn't support coherent walk Julien Grall
2014-04-28 14:09   ` Ian Campbell
2014-04-28 14:46     ` Julien Grall
2014-04-28 16:34   ` Julien Grall
2014-04-29  7:40   ` Jan Beulich
2014-05-02 15:15     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 19/21] xen/arm: grant: Add another entry to map MFN 1:1 in dom0 p2m Julien Grall
2014-04-28 14:11   ` Ian Campbell
2014-04-28 14:47     ` Julien Grall
2014-04-22 13:14 ` [PATCH v4 20/21] drivers/passthrough: arm: Add support for SMMU drivers Julien Grall
2014-04-28 14:13   ` Ian Campbell
2014-04-22 13:14 ` [PATCH v4 21/21] xen/arm: Add the property "protected-devices" in the hypervisor node Julien Grall
2014-05-02 12:54 ` [PATCH v4 00/21] IOMMU support for ARM Ian Campbell
2014-05-02 13:09   ` Julien Grall
2014-05-02 13:15   ` Julien Grall
2014-05-02 13:25     ` Ian Campbell
2014-05-02 13:29       ` Julien Grall
2014-05-02 14:20         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398693895.29700.123.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.