Re: [PATCH v4 14/21] xen/passthrough: iommu: Basic support of device tree assignment

[Julien Grall <julien.grall@linaro.org>]

On 04/28/2014 03:01 PM, Ian Campbell wrote:
> On Tue, 2014-04-22 at 14:14 +0100, Julien Grall wrote:
>> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c
>> new file mode 100644
>> index 0000000..ae05b19
>> --- /dev/null
>> +++ b/xen/drivers/passthrough/device_tree.c
>> @@ -0,0 +1,111 @@
>> +/*
>> + * xen/drivers/passthrough/arm/device_tree.c
> 
> Mismatches the actual path. Please just drop this line.
> 
>> + *
>> + * Code to passthrough device tree node to a guest
> 
>                          ^a
> 
>> + * TODO: This contains only necessary code to protected device with
>                               ^the                         devices passed to 
> 
>> + * dom0. It will need some updates when device passthrough will be
> 
> s/will be/is.
> 
>> @@ -111,6 +112,9 @@ struct dt_device_node {
>>      struct dt_device_node *next; /* TODO: Remove it. Only use to know the last children */
>>      struct dt_device_node *allnext;
>>  
>> +    /* IOMMU specific fields */
>> +    bool is_protected; /* Tell if the device is protected by an IOMMU */
> 
> The second comment is a bit redundant given the first command and the
> filed name but if you want to keep it then either s/Tell/Tells us/ or
> s/Tell/True/.

I will drop it in the next version.

> Apart from those nits: Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks!

-- 
Julien Grall