* [PATCH v1.0 10/16] arcmsr: clear outbound doorbell buffer
@ 2014-04-30 11:19 ching
2014-05-02 8:51 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: ching @ 2014-04-30 11:19 UTC (permalink / raw)
To: jbottomley, dan.carpenter, thenzl, linux-scsi, linux-kernel
From: Ching<ching2048@areca.com.tw>
Clearing outbound doorbell buffer completely for adapter type C.
Signed-off-by: Ching<ching2048@areca.com.tw>
---
diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
--- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-04-30 15:12:36.000000000 +0800
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-04-30 15:13:30.000000000 +0800
@@ -2934,11 +2934,23 @@ static void arcmsr_clear_doorbell_queue_
break;
case ACB_ADAPTER_TYPE_C: {
struct MessageUnit_C *reg = (struct MessageUnit_C *)acb->pmuC;
- uint32_t outbound_doorbell;
+ uint32_t outbound_doorbell, i;
/* empty doorbell Qbuffer if door bell ringed */
outbound_doorbell = readl(®->outbound_doorbell);
writel(outbound_doorbell, ®->outbound_doorbell_clear);
writel(ARCMSR_HBCMU_DRV2IOP_DATA_READ_OK, ®->inbound_doorbell);
+ for (i = 0; i < 200; i++) {
+ msleep(20);
+ outbound_doorbell = readl(®->outbound_doorbell);
+ if (outbound_doorbell &
+ ARCMSR_HBCMU_IOP2DRV_DATA_WRITE_OK) {
+ writel(outbound_doorbell,
+ ®->outbound_doorbell_clear);
+ writel(ARCMSR_HBCMU_DRV2IOP_DATA_READ_OK,
+ ®->inbound_doorbell);
+ } else
+ break;
+ }
}
}
}
@@ -3166,9 +3178,7 @@ sleep:
arcmsr_get_firmware_spec(acb);
arcmsr_start_adapter_bgrb(acb);
/* clear Qbuffer if door bell ringed */
- outbound_doorbell = readl(®->outbound_doorbell);
- writel(outbound_doorbell, ®->outbound_doorbell_clear); /*clear interrupt */
- writel(ARCMSR_HBCMU_DRV2IOP_DATA_READ_OK, ®->inbound_doorbell);
+ arcmsr_clear_doorbell_queue_buffer(acb);
/* enable outbound Post Queue,outbound doorbell Interrupt */
arcmsr_enable_outbound_ints(acb, intmask_org);
atomic_set(&acb->rq_map_token, 16);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1.0 10/16] arcmsr: clear outbound doorbell buffer
2014-04-30 11:19 [PATCH v1.0 10/16] arcmsr: clear outbound doorbell buffer ching
@ 2014-05-02 8:51 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-05-02 8:51 UTC (permalink / raw)
To: ching; +Cc: jbottomley, thenzl, linux-scsi, linux-kernel
On Wed, Apr 30, 2014 at 07:19:25PM +0800, ching wrote:
> From: Ching<ching2048@areca.com.tw>
>
> Clearing outbound doorbell buffer completely for adapter type C.
>
What are the user visible effects of this bug?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-02 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-30 11:19 [PATCH v1.0 10/16] arcmsr: clear outbound doorbell buffer ching
2014-05-02 8:51 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.