[Qemu-devel] [PATCH] readline: Sort completions before printing them.

[Qemu-devel] [PATCH] readline: Sort completions before printing them.

[Hani Benhabiles]

Signed-off-by: Hani Benhabiles <hani@linux.com>
---
 util/readline.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/util/readline.c b/util/readline.c
index 8441be4..8d2a0d3 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -272,6 +272,11 @@ void readline_set_completion_index(ReadLineState *rs, int index)
     rs->completion_index = index;
 }
 
+static int completion_comp(const void *a, const void *b)
+{
+    return strcmp(*(const char **) a, *(const char **) b);
+}
+
 static void readline_completion(ReadLineState *rs)
 {
     int len, i, j, max_width, nb_cols, max_prefix;
@@ -297,6 +302,8 @@ static void readline_completion(ReadLineState *rs)
         if (len > 0 && rs->completions[0][len - 1] != '/')
             readline_insert_char(rs, ' ');
     } else {
+        qsort(rs->completions, rs->nb_completions, sizeof(char *),
+              completion_comp);
         rs->printf_func(rs->opaque, "\n");
         max_width = 0;
         max_prefix = 0;	
-- 
1.8.3.2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] readline: Sort completions before printing them.

[Michael Tokarev]

Applied to -trivial, thank you!

/mjt