All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot@nvidia.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: gnurou@gmail.com, nouveau@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v4 1/9] drm/nouveau/bar: only ioremap BAR3 if it exists
Date: Fri, 2 May 2014 18:32:34 +0900	[thread overview]
Message-ID: <1399023162-13159-2-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1399023162-13159-1-git-send-email-acourbot@nvidia.com>

Some chips that use system memory exclusively (e.g. GK20A) do not
expose 2 BAR regions. For them only BAR1 exists, and it should be used
for USERD mapping. Do not map BAR3 if its resource does not exist.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/nouveau/core/subdev/bar/base.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
index bdf594116f3f..73b1ed20c8d5 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
@@ -118,8 +118,10 @@ nouveau_bar_create_(struct nouveau_object *parent,
 	if (ret)
 		return ret;
 
-	bar->iomem = ioremap(nv_device_resource_start(device, 3),
-			     nv_device_resource_len(device, 3));
+	if (nv_device_resource_len(device, 3) != 0)
+		bar->iomem = ioremap(nv_device_resource_start(device, 3),
+				     nv_device_resource_len(device, 3));
+
 	return 0;
 }
 
-- 
1.9.2

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	<nouveau@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <gnurou@gmail.com>,
	Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v4 1/9] drm/nouveau/bar: only ioremap BAR3 if it exists
Date: Fri, 2 May 2014 18:32:34 +0900	[thread overview]
Message-ID: <1399023162-13159-2-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1399023162-13159-1-git-send-email-acourbot@nvidia.com>

Some chips that use system memory exclusively (e.g. GK20A) do not
expose 2 BAR regions. For them only BAR1 exists, and it should be used
for USERD mapping. Do not map BAR3 if its resource does not exist.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/nouveau/core/subdev/bar/base.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
index bdf594116f3f..73b1ed20c8d5 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
@@ -118,8 +118,10 @@ nouveau_bar_create_(struct nouveau_object *parent,
 	if (ret)
 		return ret;
 
-	bar->iomem = ioremap(nv_device_resource_start(device, 3),
-			     nv_device_resource_len(device, 3));
+	if (nv_device_resource_len(device, 3) != 0)
+		bar->iomem = ioremap(nv_device_resource_start(device, 3),
+				     nv_device_resource_len(device, 3));
+
 	return 0;
 }
 
-- 
1.9.2


  reply	other threads:[~2014-05-02  9:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02  9:32 [PATCH v4 0/9] drm/nouveau: support for GK20A, cont'd Alexandre Courbot
2014-05-02  9:32 ` Alexandre Courbot
2014-05-02  9:32 ` Alexandre Courbot [this message]
2014-05-02  9:32   ` [PATCH v4 1/9] drm/nouveau/bar: only ioremap BAR3 if it exists Alexandre Courbot
2014-05-02  9:32 ` [PATCH v4 3/9] drm/nouveau/ibus: add GK20A support Alexandre Courbot
2014-05-02  9:32   ` Alexandre Courbot
2014-05-02  9:32 ` [PATCH v4 4/9] drm/nouveau/fb: " Alexandre Courbot
2014-05-02  9:32   ` Alexandre Courbot
2014-05-02  9:32 ` [PATCH v4 5/9] drm/nouveau/fifo: " Alexandre Courbot
2014-05-02  9:32   ` Alexandre Courbot
     [not found] ` <1399023162-13159-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-02  9:32   ` [PATCH v4 2/9] drm/nouveau/bar/nvc0: support chips without BAR3 Alexandre Courbot
2014-05-02  9:32     ` Alexandre Courbot
2014-05-02  9:32   ` [PATCH v4 6/9] drm/nouveau/graph: enable when using external fw Alexandre Courbot
2014-05-02  9:32     ` Alexandre Courbot
2014-05-02  9:32   ` [PATCH v4 7/9] drm/nouveau/graph: pad firmware code at load time Alexandre Courbot
2014-05-02  9:32     ` Alexandre Courbot
2014-05-06  0:11   ` [Nouveau] [PATCH v4 0/9] drm/nouveau: support for GK20A, cont'd Ben Skeggs
2014-05-06  0:11     ` Ben Skeggs
2014-05-02  9:32 ` [PATCH v4 8/9] drm/nouveau/graph: add GK20A support Alexandre Courbot
2014-05-02  9:32   ` Alexandre Courbot
2014-05-02  9:32 ` [PATCH v4 9/9] drm/nouveau: support for probing GK20A Alexandre Courbot
2014-05-02  9:32   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399023162-13159-2-git-send-email-acourbot@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.