All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 15/34] sparc64: fix sparse warnings in signal_64.c
@ 2014-05-03 22:52 Sam Ravnborg
  2014-05-16 21:25 ` [PATCH 15/34] sparc64: fix sparse warning in process_64.c Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2014-05-03 22:52 UTC (permalink / raw)
  To: sparclinux

Fix following warnings:
kernel/signal_64.c:292:16: warning: incorrect type in assignment (different address spaces)
kernel/signal_64.c:378:24: warning: cast removes address space of expression
kernel/signal_64.c:386:24: warning: cast removes address space of expression

rwin_save declared __user - because is points to user data.
Drop cast of pointer to u64 in calls to __put_user.
Pointers are 64 bits and __put_user supports pointers too.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 arch/sparc/kernel/signal_64.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/sparc/kernel/signal_64.c b/arch/sparc/kernel/signal_64.c
index cd91d01..015ac1d 100644
--- a/arch/sparc/kernel/signal_64.c
+++ b/arch/sparc/kernel/signal_64.c
@@ -240,7 +240,7 @@ struct rt_signal_frame {
 	__siginfo_fpu_t __user	*fpu_save;
 	stack_t			stack;
 	sigset_t		mask;
-	__siginfo_rwin_t	*rwin_save;
+	__siginfo_rwin_t __user	*rwin_save;
 };
 
 void do_rt_sigreturn(struct pt_regs *regs)
@@ -375,7 +375,7 @@ setup_rt_frame(struct ksignal *ksig, struct pt_regs *regs)
 		__siginfo_fpu_t __user *fpu_save = tail;
 		tail += sizeof(__siginfo_fpu_t);
 		err |= save_fpu_state(regs, fpu_save);
-		err |= __put_user((u64)fpu_save, &sf->fpu_save);
+		err |= __put_user(fpu_save, &sf->fpu_save);
 	} else {
 		err |= __put_user(0, &sf->fpu_save);
 	}
@@ -383,7 +383,7 @@ setup_rt_frame(struct ksignal *ksig, struct pt_regs *regs)
 		__siginfo_rwin_t __user *rwin_save = tail;
 		tail += sizeof(__siginfo_rwin_t);
 		err |= save_rwin_state(wsaved, rwin_save);
-		err |= __put_user((u64)rwin_save, &sf->rwin_save);
+		err |= __put_user(rwin_save, &sf->rwin_save);
 		set_thread_wsaved(0);
 	} else {
 		err |= __put_user(0, &sf->rwin_save);
-- 
1.9.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 15/34] sparc64: fix sparse warning in process_64.c
  2014-05-03 22:52 [PATCH 15/34] sparc64: fix sparse warnings in signal_64.c Sam Ravnborg
@ 2014-05-16 21:25 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2014-05-16 21:25 UTC (permalink / raw)
  To: sparclinux

Fix following warning:
process_64.c:91:25: warning: non-ANSI function declaration of function 'arch_cpu_idle_dead'

Add proper (void) to function definition

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 arch/sparc/kernel/process_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/process_64.c b/arch/sparc/kernel/process_64.c
index d7b4967..b2988f2 100644
--- a/arch/sparc/kernel/process_64.c
+++ b/arch/sparc/kernel/process_64.c
@@ -88,7 +88,7 @@ void arch_cpu_idle(void)
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
-void arch_cpu_idle_dead()
+void arch_cpu_idle_dead(void)
 {
 	sched_preempt_enable_no_resched();
 	cpu_play_dead();
-- 
1.9.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-16 21:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-03 22:52 [PATCH 15/34] sparc64: fix sparse warnings in signal_64.c Sam Ravnborg
2014-05-16 21:25 ` [PATCH 15/34] sparc64: fix sparse warning in process_64.c Sam Ravnborg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.