[Qemu-devel] [PATCH] linux-user: Return correct errno for unsupported netlink socket

[Qemu-devel] [PATCH] linux-user: Return correct errno for unsupported netlink socket

[Ed Swierk]

This fixes "Cannot open audit interface - aborting." when the
EAFNOSUPPORT errno differs between the target and host
architectures (e.g. mips target and x86_64 host).

Signed-off-by: Ed Swierk <eswierk@skyportsystems.com>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9864813..271d28a 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1861,7 +1861,7 @@ static abi_long do_socket(int domain, int type, int protocol)
     }
 
     if (domain == PF_NETLINK)
-        return -EAFNOSUPPORT; /* do not NETLINK socket connections possible */
+        return -TARGET_EAFNOSUPPORT;
     ret = get_errno(socket(domain, type, protocol));
     if (ret >= 0) {
         ret = sock_flags_fixup(ret, target_type);
-- 
1.8.3.2

Re: [Qemu-devel] [PATCH] linux-user: Return correct errno for unsupported netlink socket

[Riku Voipio]

Hi,

On Mon, May 05, 2014 at 08:04:45PM -0700, Ed Swierk wrote:
> This fixes "Cannot open audit interface - aborting." when the
> EAFNOSUPPORT errno differs between the target and host
> architectures (e.g. mips target and x86_64 host).

Thanks, looks good - applied to linux-user tree.

> Signed-off-by: Ed Swierk <eswierk@skyportsystems.com>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9864813..271d28a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1861,7 +1861,7 @@ static abi_long do_socket(int domain, int type, int protocol)
>      }
>  
>      if (domain == PF_NETLINK)
> -        return -EAFNOSUPPORT; /* do not NETLINK socket connections possible */
> +        return -TARGET_EAFNOSUPPORT;
>      ret = get_errno(socket(domain, type, protocol));
>      if (ret >= 0) {
>          ret = sock_flags_fixup(ret, target_type);
> -- 
> 1.8.3.2
>