* [PATCH] nv50/ir/gk110: fix set with f32 dest
@ 2014-05-06 23:57 Ilia Mirkin
2014-05-07 23:57 ` [Nouveau] " Ben Skeggs
0 siblings, 1 reply; 2+ messages in thread
From: Ilia Mirkin @ 2014-05-06 23:57 UTC (permalink / raw)
To: mesa-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Ben Skeggs
Should fix SGE/SSG instructions, which were previously getting integer
0/-1 values.
Signed-off-by: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
---
src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
index 5992c54..b8d0d3e 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
@@ -915,6 +915,9 @@ CodeEmitterGK110::emitSET(const CmpInstruction *i)
modNegAbsF32_3b(i, 1);
}
FTZ_(3a);
+
+ if (i->dType == TYPE_F32)
+ code[1] |= 1 << 23;
}
if (i->sType == TYPE_S32)
code[1] |= 1 << 19;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH] nv50/ir/gk110: fix set with f32 dest
2014-05-06 23:57 [PATCH] nv50/ir/gk110: fix set with f32 dest Ilia Mirkin
@ 2014-05-07 23:57 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2014-05-07 23:57 UTC (permalink / raw)
To: Ilia Mirkin; +Cc: mesa-dev, Ben Skeggs, nouveau
On Wed, May 7, 2014 at 9:57 AM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> Should fix SGE/SSG instructions, which were previously getting integer
> 0/-1 values.
I hit the same issue on Maxwell. Soo...
>
> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> index 5992c54..b8d0d3e 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> @@ -915,6 +915,9 @@ CodeEmitterGK110::emitSET(const CmpInstruction *i)
> modNegAbsF32_3b(i, 1);
> }
> FTZ_(3a);
> +
> + if (i->dType == TYPE_F32)
> + code[1] |= 1 << 23;
> }
> if (i->sType == TYPE_S32)
> code[1] |= 1 << 19;
> --
> 1.8.3.2
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-07 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-06 23:57 [PATCH] nv50/ir/gk110: fix set with f32 dest Ilia Mirkin
2014-05-07 23:57 ` [Nouveau] " Ben Skeggs
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.