[PATCH v2 0/5] ARM: dts: enable display for peach-pit and snow boards

[PATCH v2 0/5] ARM: dts: enable display for peach-pit and snow boards

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Add nodes for fimd and dp controller for exynos5250 based snow
and exynos5420 based peach-pit board.

This series is based on Kukjin Kims, for-next branch.

V2:
1) Rebase on Peach-pit dependent patches.

It is dependent on
1) Andrew Bresticker's patch for hpd gpio addition, avilable at
http://www.spinics.net/lists/linux-samsung-soc/msg28827.html [Patch is 'ACK'ed.]
2) Arun's patch for adding peach-pit board dts file at
http://www.spinics.net/lists/linux-samsung-soc/msg30103.html. [Patch is 'ACK'ed.]

Rahul Sharma (5):
  ARM: dts: move dp hpd line to the board file for exynos5420
  ARM: dts: enable fimd for exynos5250 based snow board
  ARM: dts: enable dp-controller for exynos5250 based snow board
  ARM: dts: enable fimd for exynos5420 based peach-pit board
  ARM: dts: enable dp-controller for exynos5420 based peach-pit board

 arch/arm/boot/dts/exynos5250-snow.dts      |   33 +++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
 arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
 4 files changed, 79 insertions(+), 7 deletions(-)

-- 
1.7.9.5

[PATCH v2 0/5] ARM: dts: enable display for peach-pit and snow boards

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Add nodes for fimd and dp controller for exynos5250 based snow
and exynos5420 based peach-pit board.

This series is based on Kukjin Kims, for-next branch.

V2:
1) Rebase on Peach-pit dependent patches.

It is dependent on
1) Andrew Bresticker's patch for hpd gpio addition, avilable at
http://www.spinics.net/lists/linux-samsung-soc/msg28827.html [Patch is 'ACK'ed.]
2) Arun's patch for adding peach-pit board dts file at
http://www.spinics.net/lists/linux-samsung-soc/msg30103.html. [Patch is 'ACK'ed.]

Rahul Sharma (5):
  ARM: dts: move dp hpd line to the board file for exynos5420
  ARM: dts: enable fimd for exynos5250 based snow board
  ARM: dts: enable dp-controller for exynos5250 based snow board
  ARM: dts: enable fimd for exynos5420 based peach-pit board
  ARM: dts: enable dp-controller for exynos5420 based peach-pit board

 arch/arm/boot/dts/exynos5250-snow.dts      |   33 +++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
 arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
 4 files changed, 79 insertions(+), 7 deletions(-)

-- 
1.7.9.5

[PATCH v2 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Display controller HPD Gpio line is board specific. This patch
is moving the pinctrl for hpd gpio line to the respective board
file.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index ba686e4..7e4ac17 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -59,13 +59,6 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
-
-		dp_hpd: dp_hpd {
-			samsung,pins = "gpx0-7";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
 	};
 
 	pinctrl@13410000 {
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..62d38c8 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -138,6 +138,13 @@
 			samsung,pin-pud = <1>;
 			samsung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx0-7";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	hdmi@14530000 {
-- 
1.7.9.5

[PATCH v2 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Display controller HPD Gpio line is board specific. This patch
is moving the pinctrl for hpd gpio line to the respective board
file.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index ba686e4..7e4ac17 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -59,13 +59,6 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
-
-		dp_hpd: dp_hpd {
-			samsung,pins = "gpx0-7";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
 	};
 
 	pinctrl at 13410000 {
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..62d38c8 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -138,6 +138,13 @@
 			samsung,pin-pud = <1>;
 			samsung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx0-7";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	hdmi at 14530000 {
-- 
1.7.9.5

[PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd node for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 1ce1088..796954c 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -206,4 +206,10 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	fimd@14400000 {
+		status = "okay";
+		samsung,invert-vclk;
+	};
+
 };
-- 
1.7.9.5

[PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd node for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 1ce1088..796954c 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -206,4 +206,10 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	fimd at 14400000 {
+		status = "okay";
+		samsung,invert-vclk;
+	};
+
 };
-- 
1.7.9.5

[PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable dp-controller for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 796954c..28a755f 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -207,6 +207,33 @@
 		};
 	};
 
+	dp-controller@145B0000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x0a>;
+		samsung,lane-count = <2>;
+		samsung,hpd-gpio = <&gpx0 7 0>;
+		display-timings {
+			native-mode = <&timing1>;
+			timing1: timing@1 {
+				clock-frequency = <70589280>;
+				hactive = <1366>;
+				vactive = <768>;
+				hfront-porch = <40>;
+				hback-porch = <40>;
+				hsync-len = <32>;
+				vback-porch = <10>;
+				vfront-porch = <12>;
+				vsync-len = <6>;
+			};
+		};
+	};
+
 	fimd@14400000 {
 		status = "okay";
 		samsung,invert-vclk;
-- 
1.7.9.5

[PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable dp-controller for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 796954c..28a755f 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -207,6 +207,33 @@
 		};
 	};
 
+	dp-controller at 145B0000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x0a>;
+		samsung,lane-count = <2>;
+		samsung,hpd-gpio = <&gpx0 7 0>;
+		display-timings {
+			native-mode = <&timing1>;
+			timing1: timing at 1 {
+				clock-frequency = <70589280>;
+				hactive = <1366>;
+				vactive = <768>;
+				hfront-porch = <40>;
+				hback-porch = <40>;
+				hsync-len = <32>;
+				vback-porch = <10>;
+				vfront-porch = <12>;
+				vsync-len = <6>;
+			};
+		};
+	};
+
 	fimd at 14400000 {
 		status = "okay";
 		samsung,invert-vclk;
-- 
1.7.9.5

[PATCH v2 4/5] ARM: dts: enable fimd for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index fae33dd..f75da5b 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -145,3 +145,8 @@
 &watchdog {
 	timeout-sec = <32>;
 };
+
+&fimd {
+	status = "okay";
+	samsung,invert-vclk;
+};
-- 
1.7.9.5

[PATCH v2 4/5] ARM: dts: enable fimd for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index fae33dd..f75da5b 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -145,3 +145,8 @@
 &watchdog {
 	timeout-sec = <32>;
 };
+
+&fimd {
+	status = "okay";
+	samsung,invert-vclk;
+};
-- 
1.7.9.5

[PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable dp-controller for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index f75da5b..ed76f33 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -74,6 +74,13 @@
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
+
+	dp_hpd: dp_hpd {
+		samsung,pins = "gpx2-6";
+		samsung,pin-function = <0>;
+		samsung,pin-pud = <3>;
+		samsung,pin-drv = <0>;
+	};
 };
 
 &rtc {
@@ -150,3 +157,30 @@
 	status = "okay";
 	samsung,invert-vclk;
 };
+
+&dp {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&dp_hpd>;
+	samsung,color-space = <0>;
+	samsung,dynamic-range = <0>;
+	samsung,ycbcr-coeff = <0>;
+	samsung,color-depth = <1>;
+	samsung,link-rate = <0x06>;
+	samsung,lane-count = <2>;
+	samsung,hpd-gpio = <&gpx2 6 0>;
+	display-timings {
+		native-mode = <&timing1>;
+		timing1: timing@1 {
+			clock-frequency = <70589280>;
+			hactive = <1366>;
+			vactive = <768>;
+			hfront-porch = <40>;
+			hback-porch = <40>;
+			hsync-len = <32>;
+			vback-porch = <10>;
+			vfront-porch = <12>;
+			vsync-len = <6>;
+		};
+	};
+};
-- 
1.7.9.5

[PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable dp-controller for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index f75da5b..ed76f33 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -74,6 +74,13 @@
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
+
+	dp_hpd: dp_hpd {
+		samsung,pins = "gpx2-6";
+		samsung,pin-function = <0>;
+		samsung,pin-pud = <3>;
+		samsung,pin-drv = <0>;
+	};
 };
 
 &rtc {
@@ -150,3 +157,30 @@
 	status = "okay";
 	samsung,invert-vclk;
 };
+
+&dp {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&dp_hpd>;
+	samsung,color-space = <0>;
+	samsung,dynamic-range = <0>;
+	samsung,ycbcr-coeff = <0>;
+	samsung,color-depth = <1>;
+	samsung,link-rate = <0x06>;
+	samsung,lane-count = <2>;
+	samsung,hpd-gpio = <&gpx2 6 0>;
+	display-timings {
+		native-mode = <&timing1>;
+		timing1: timing at 1 {
+			clock-frequency = <70589280>;
+			hactive = <1366>;
+			vactive = <768>;
+			hfront-porch = <40>;
+			hback-porch = <40>;
+			hsync-len = <32>;
+			vback-porch = <10>;
+			vfront-porch = <12>;
+			vsync-len = <6>;
+		};
+	};
+};
-- 
1.7.9.5

Re: [PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Jingoo Han]

On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable fimd node for snow board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 1ce1088..796954c 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -206,4 +206,10 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +
> +	fimd@14400000 {
> +		status = "okay";

(+cc Sachin Kamat, Tomasz Figa)

For readability, how about moving 'status' to the last entry of
the node? The same comment applies to other patches, too.

Best regards,
Jingoo Han

> +		samsung,invert-vclk;
> +	};
> +
>  };
> --
> 1.7.9.5

[PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Jingoo Han]

On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable fimd node for snow board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 1ce1088..796954c 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -206,4 +206,10 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +
> +	fimd at 14400000 {
> +		status = "okay";

(+cc Sachin Kamat, Tomasz Figa)

For readability, how about moving 'status' to the last entry of
the node? The same comment applies to other patches, too.

Best regards,
Jingoo Han

> +		samsung,invert-vclk;
> +	};
> +
>  };
> --
> 1.7.9.5

Re: [PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Jingoo Han]

On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable dp-controller for snow board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 796954c..28a755f 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -207,6 +207,33 @@
>  		};
>  	};
> 
> +	dp-controller@145B0000 {
> +		status = "okay";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dp_hpd>;
> +		samsung,color-space = <0>;
> +		samsung,dynamic-range = <0>;
> +		samsung,ycbcr-coeff = <0>;
> +		samsung,color-depth = <1>;
> +		samsung,link-rate = <0x0a>;
> +		samsung,lane-count = <2>;
> +		samsung,hpd-gpio = <&gpx0 7 0>;
> +		display-timings {

For readability, please insert one line as below.

+		samsung,hpd-gpio = <&gpx0 7 0>;
+
+		display-timings {

The same comment applies to the 5th patch.
([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420
based peach-pit board)

Best regards,
Jingoo Han

> +			native-mode = <&timing1>;
> +			timing1: timing@1 {
> +				clock-frequency = <70589280>;
> +				hactive = <1366>;
> +				vactive = <768>;
> +				hfront-porch = <40>;
> +				hback-porch = <40>;
> +				hsync-len = <32>;
> +				vback-porch = <10>;
> +				vfront-porch = <12>;
> +				vsync-len = <6>;
> +			};
> +		};
> +	};
> +
>  	fimd@14400000 {
>  		status = "okay";
>  		samsung,invert-vclk;
> --
> 1.7.9.5

[PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Jingoo Han]

On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Enable dp-controller for snow board.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 796954c..28a755f 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -207,6 +207,33 @@
>  		};
>  	};
> 
> +	dp-controller at 145B0000 {
> +		status = "okay";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dp_hpd>;
> +		samsung,color-space = <0>;
> +		samsung,dynamic-range = <0>;
> +		samsung,ycbcr-coeff = <0>;
> +		samsung,color-depth = <1>;
> +		samsung,link-rate = <0x0a>;
> +		samsung,lane-count = <2>;
> +		samsung,hpd-gpio = <&gpx0 7 0>;
> +		display-timings {

For readability, please insert one line as below.

+		samsung,hpd-gpio = <&gpx0 7 0>;
+
+		display-timings {

The same comment applies to the 5th patch.
([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420
based peach-pit board)

Best regards,
Jingoo Han

> +			native-mode = <&timing1>;
> +			timing1: timing at 1 {
> +				clock-frequency = <70589280>;
> +				hactive = <1366>;
> +				vactive = <768>;
> +				hfront-porch = <40>;
> +				hback-porch = <40>;
> +				hsync-len = <32>;
> +				vback-porch = <10>;
> +				vfront-porch = <12>;
> +				vsync-len = <6>;
> +			};
> +		};
> +	};
> +
>  	fimd at 14400000 {
>  		status = "okay";
>  		samsung,invert-vclk;
> --
> 1.7.9.5

Re: [PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Rahul Sharma]

On 8 May 2014 12:50, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable fimd node for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 1ce1088..796954c 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -206,4 +206,10 @@
>>                       clock-frequency = <24000000>;
>>               };
>>       };
>> +
>> +     fimd@14400000 {
>> +             status = "okay";
>
> (+cc Sachin Kamat, Tomasz Figa)
>
> For readability, how about moving 'status' to the last entry of
> the node? The same comment applies to other patches, too.
>

I just followed the nodes in rest of the file for peach and snow. This
looks consistent to me. But let me know if you want me to change
this.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>> +             samsung,invert-vclk;
>> +     };
>> +
>>  };
>> --
>> 1.7.9.5
>
>

[PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Rahul Sharma]

On 8 May 2014 12:50, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable fimd node for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 1ce1088..796954c 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -206,4 +206,10 @@
>>                       clock-frequency = <24000000>;
>>               };
>>       };
>> +
>> +     fimd at 14400000 {
>> +             status = "okay";
>
> (+cc Sachin Kamat, Tomasz Figa)
>
> For readability, how about moving 'status' to the last entry of
> the node? The same comment applies to other patches, too.
>

I just followed the nodes in rest of the file for peach and snow. This
looks consistent to me. But let me know if you want me to change
this.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>> +             samsung,invert-vclk;
>> +     };
>> +
>>  };
>> --
>> 1.7.9.5
>
>

Re: [PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

On 8 May 2014 13:12, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable dp-controller for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 796954c..28a755f 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -207,6 +207,33 @@
>>               };
>>       };
>>
>> +     dp-controller@145B0000 {
>> +             status = "okay";
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&dp_hpd>;
>> +             samsung,color-space = <0>;
>> +             samsung,dynamic-range = <0>;
>> +             samsung,ycbcr-coeff = <0>;
>> +             samsung,color-depth = <1>;
>> +             samsung,link-rate = <0x0a>;
>> +             samsung,lane-count = <2>;
>> +             samsung,hpd-gpio = <&gpx0 7 0>;
>> +             display-timings {
>
> For readability, please insert one line as below.
>
> +               samsung,hpd-gpio = <&gpx0 7 0>;
> +
> +               display-timings {
>
> The same comment applies to the 5th patch.
> ([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420
> based peach-pit board)
>

Ok. Will do that.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>> +                     native-mode = <&timing1>;
>> +                     timing1: timing@1 {
>> +                             clock-frequency = <70589280>;
>> +                             hactive = <1366>;
>> +                             vactive = <768>;
>> +                             hfront-porch = <40>;
>> +                             hback-porch = <40>;
>> +                             hsync-len = <32>;
>> +                             vback-porch = <10>;
>> +                             vfront-porch = <12>;
>> +                             vsync-len = <6>;
>> +                     };
>> +             };
>> +     };
>> +
>>       fimd@14400000 {
>>               status = "okay";
>>               samsung,invert-vclk;
>> --
>> 1.7.9.5
>

[PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

On 8 May 2014 13:12, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable dp-controller for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 796954c..28a755f 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -207,6 +207,33 @@
>>               };
>>       };
>>
>> +     dp-controller at 145B0000 {
>> +             status = "okay";
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&dp_hpd>;
>> +             samsung,color-space = <0>;
>> +             samsung,dynamic-range = <0>;
>> +             samsung,ycbcr-coeff = <0>;
>> +             samsung,color-depth = <1>;
>> +             samsung,link-rate = <0x0a>;
>> +             samsung,lane-count = <2>;
>> +             samsung,hpd-gpio = <&gpx0 7 0>;
>> +             display-timings {
>
> For readability, please insert one line as below.
>
> +               samsung,hpd-gpio = <&gpx0 7 0>;
> +
> +               display-timings {
>
> The same comment applies to the 5th patch.
> ([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420
> based peach-pit board)
>

Ok. Will do that.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>> +                     native-mode = <&timing1>;
>> +                     timing1: timing at 1 {
>> +                             clock-frequency = <70589280>;
>> +                             hactive = <1366>;
>> +                             vactive = <768>;
>> +                             hfront-porch = <40>;
>> +                             hback-porch = <40>;
>> +                             hsync-len = <32>;
>> +                             vback-porch = <10>;
>> +                             vfront-porch = <12>;
>> +                             vsync-len = <6>;
>> +                     };
>> +             };
>> +     };
>> +
>>       fimd at 14400000 {
>>               status = "okay";
>>               samsung,invert-vclk;
>> --
>> 1.7.9.5
>

Re: [PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Sachin Kamat]

On 8 May 2014 12:50, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable fimd node for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 1ce1088..796954c 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -206,4 +206,10 @@
>>                       clock-frequency = <24000000>;
>>               };
>>       };
>> +
>> +     fimd@14400000 {
>> +             status = "okay";
>
> (+cc Sachin Kamat, Tomasz Figa)
>
> For readability, how about moving 'status' to the last entry of
> the node? The same comment applies to other patches, too.

Either at the top or bottom is fine rather than somewhere in between.
However no need to re-spin the patch just for this change.

-- 
With warm regards,
Sachin

[PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Sachin Kamat]

On 8 May 2014 12:50, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Enable fimd node for snow board.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts |    6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 1ce1088..796954c 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -206,4 +206,10 @@
>>                       clock-frequency = <24000000>;
>>               };
>>       };
>> +
>> +     fimd at 14400000 {
>> +             status = "okay";
>
> (+cc Sachin Kamat, Tomasz Figa)
>
> For readability, how about moving 'status' to the last entry of
> the node? The same comment applies to other patches, too.

Either at the top or bottom is fine rather than somewhere in between.
However no need to re-spin the patch just for this change.

-- 
With warm regards,
Sachin