All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: rt5645: Fix a serious typo
@ 2014-05-08  7:42 Oder Chiou
  2014-05-08  7:42 ` [PATCH 2/2] ASoC: rt5645: fix coccinelle warnings Oder Chiou
  2014-05-08  8:01 ` [PATCH 1/2] ASoC: rt5645: Fix a serious typo Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Oder Chiou @ 2014-05-08  7:42 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: oder_chiou, bardliao, alsa-devel, flove

The patch corrects a serious typo in struct reg_default.

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/codecs/rt5645.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 6db6f81..30410eb 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -50,10 +50,10 @@ static const struct regmap_range_cfg rt5645_ranges[] = {
 
 static const struct reg_default init_list[] = {
 	{RT5645_PR_BASE + 0x3d,	0x3600},
-	{RT5645_PR_BASE + 0x1c, 0xfd20);
-	{RT5645_PR_BASE + 0x20, 0x611f);
-	{RT5645_PR_BASE + 0x21, 0x4040);
-	{RT5645_PR_BASE + 0x23, 0x0004);
+	{RT5645_PR_BASE + 0x1c,	0xfd20},
+	{RT5645_PR_BASE + 0x20,	0x611f},
+	{RT5645_PR_BASE + 0x21,	0x4040},
+	{RT5645_PR_BASE + 0x23,	0x0004},
 };
 #define RT5645_INIT_REG_LEN ARRAY_SIZE(init_list)
 
-- 
1.8.1.1.439.g50a6b54

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: rt5645: fix coccinelle warnings
  2014-05-08  7:42 [PATCH 1/2] ASoC: rt5645: Fix a serious typo Oder Chiou
@ 2014-05-08  7:42 ` Oder Chiou
  2014-05-08  8:01 ` [PATCH 1/2] ASoC: rt5645: Fix a serious typo Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Oder Chiou @ 2014-05-08  7:42 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: oder_chiou, bardliao, alsa-devel, flove

Return statements in functions returning bool should use
true/false instead of 1/0.

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/codecs/rt5645.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 30410eb..68923ec 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -242,9 +242,9 @@ static bool rt5645_volatile_register(struct device *dev, unsigned int reg)
 	case RT5645_VENDOR_ID:
 	case RT5645_VENDOR_ID1:
 	case RT5645_VENDOR_ID2:
-		return 1;
+		return true;
 	default:
-		return 0;
+		return false;
 	}
 }
 
@@ -391,9 +391,9 @@ static bool rt5645_readable_register(struct device *dev, unsigned int reg)
 	case RT5645_VENDOR_ID:
 	case RT5645_VENDOR_ID1:
 	case RT5645_VENDOR_ID2:
-		return 1;
+		return true;
 	default:
-		return 0;
+		return false;
 	}
 }
 
-- 
1.8.1.1.439.g50a6b54

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: rt5645: Fix a serious typo
  2014-05-08  7:42 [PATCH 1/2] ASoC: rt5645: Fix a serious typo Oder Chiou
  2014-05-08  7:42 ` [PATCH 2/2] ASoC: rt5645: fix coccinelle warnings Oder Chiou
@ 2014-05-08  8:01 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-08  8:01 UTC (permalink / raw)
  To: Oder Chiou; +Cc: bardliao, alsa-devel, lgirdwood, flove


[-- Attachment #1.1: Type: text/plain, Size: 142 bytes --]

On Thu, May 08, 2014 at 03:42:36PM +0800, Oder Chiou wrote:
> The patch corrects a serious typo in struct reg_default.

Applied both, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-08  8:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-08  7:42 [PATCH 1/2] ASoC: rt5645: Fix a serious typo Oder Chiou
2014-05-08  7:42 ` [PATCH 2/2] ASoC: rt5645: fix coccinelle warnings Oder Chiou
2014-05-08  8:01 ` [PATCH 1/2] ASoC: rt5645: Fix a serious typo Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.