* [PATCH] staging: rtl8723bs: Change rtw_ndev_notifier_call message to dbg
@ 2022-03-23 15:42 Chris Morgan
2022-03-23 15:49 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Chris Morgan @ 2022-03-23 15:42 UTC (permalink / raw)
To: linux-staging
Cc: gregkh, fabioaiuto83, hdegoede, kuba, saurav.girepunje, Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
The message received in the kernel log for the state of the notifier
call doesn't seem to be of much help to end users. Changing the message
type from info to dbg to hide the message unless you are debugging
the kernel or the network subsystem.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 05482341eefe..bc58bd8c38b2 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -389,7 +389,7 @@ static int rtw_ndev_notifier_call(struct notifier_block *nb, unsigned long state
if (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl)
return NOTIFY_DONE;
- netdev_info(dev, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev),
+ netdev_dbg(dev, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev),
state);
return NOTIFY_DONE;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: Change rtw_ndev_notifier_call message to dbg
2022-03-23 15:42 [PATCH] staging: rtl8723bs: Change rtw_ndev_notifier_call message to dbg Chris Morgan
@ 2022-03-23 15:49 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-03-23 15:49 UTC (permalink / raw)
To: Chris Morgan, linux-staging
Cc: gregkh, fabioaiuto83, kuba, saurav.girepunje, Chris Morgan
Hi,
On 3/23/22 16:42, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The message received in the kernel log for the state of the notifier
> call doesn't seem to be of much help to end users. Changing the message
> type from info to dbg to hide the message unless you are debugging
> the kernel or the network subsystem.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 05482341eefe..bc58bd8c38b2 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -389,7 +389,7 @@ static int rtw_ndev_notifier_call(struct notifier_block *nb, unsigned long state
> if (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl)
> return NOTIFY_DONE;
>
> - netdev_info(dev, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev),
> + netdev_dbg(dev, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev),
> state);
>
> return NOTIFY_DONE;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 15:42 [PATCH] staging: rtl8723bs: Change rtw_ndev_notifier_call message to dbg Chris Morgan
2022-03-23 15:49 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.