All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Niestroj <m.niestroj@grinn-global.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ARM: am335x: Add support for chiliSOM
Date: Mon, 23 Jan 2017 17:27:09 +0100	[thread overview]
Message-ID: <13be25e3-2760-9815-9382-fc28e655f919@grinn-global.com> (raw)
In-Reply-To: <20170123155636.GO10853@bill-the-cat>

Hi,
Thanks for review! See my comment below.

On 23.01.2017 16:56, Tom Rini wrote:
> On Mon, Jan 23, 2017 at 02:39:15PM +0100, Marcin Niestroj wrote:
>
>> chiliSOM is a System On Module (http://http://grinn-global.com/chilisom/).
>> It can't exists on its own, but will be used as part of other boards.
>>
>> Hardware specification:
>>  * TI AM335x processor
>>  * 128M, 256M or 512M DDR3 memory
>>  * up to 256M NAND
>>
>> Here we treat SOM similar to SOC, so we place it inside arch/arm/mach-*
>> directory and make it possible to reuse initialization code (i.e. DDR,
>> NAND init) for all boards that use it. This approach is similar as for
>> liteSOM module.
>>
>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>> ---
>>  arch/arm/Kconfig                               |   2 +
>>  arch/arm/Makefile                              |   1 +
>>  arch/arm/mach-chilisom/Kconfig                 |   4 +
>>  arch/arm/mach-chilisom/Makefile                |   6 +
>>  arch/arm/mach-chilisom/chilisom.c              | 185 +++++++++++++++++++++++++
>>  arch/arm/mach-chilisom/include/mach/chilisom.h |  15 ++
>>  6 files changed, 213 insertions(+)
>
> These don't belong in a new mach directory, this should end up in
> board/grinn/common/ instead, thanks!
>

This will work for all grinn boards. But the idea is that some other
vendor can make a board that will use chilisom as it's base. And in
that case sources from board/grinn/common/ directory won't compile.
Do you have any idea how to bypass this restriction?

-- 
Marcin Niestroj

  reply	other threads:[~2017-01-23 16:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 13:39 [U-Boot] [PATCH 0/3] ARM: am335x: Support chiliSOM and chiliBoard Marcin Niestroj
2017-01-23 13:39 ` [U-Boot] [PATCH 1/3] ARM: Makefile: Fix config.mk inclusion for multiple mach-* dirs Marcin Niestroj
2017-01-23 13:39 ` [U-Boot] [PATCH 2/3] ARM: am335x: Add support for chiliSOM Marcin Niestroj
2017-01-23 15:56   ` Tom Rini
2017-01-23 16:27     ` Marcin Niestroj [this message]
2017-01-23 17:07       ` Tom Rini
2017-01-24 16:27         ` Marcin Niestroj
2017-01-24 16:29           ` Tom Rini
2017-01-23 13:39 ` [U-Boot] [PATCH 3/3] board/chiliboard: Add support for chiliBoard Marcin Niestroj
2017-01-23 15:56   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13be25e3-2760-9815-9382-fc28e655f919@grinn-global.com \
    --to=m.niestroj@grinn-global.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.