* [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
@ 2022-04-26 14:15 ` Fabien Parent
0 siblings, 0 replies; 10+ messages in thread
From: Fabien Parent @ 2022-04-26 14:15 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Hermes Wu, Allen Chen, AngeloGioacchino Del Regno
Cc: Fabien Parent, dri-devel, linux-kernel
The IT6505 is using functions provided by the DRM_DP_HELPER driver.
In order to avoid having the bridge enabled but the helper disabled,
let's add a select in order to be sure that the DP helper functions are
always available.
Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 007e5a282f67..2145b08f9534 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -78,6 +78,7 @@ config DRM_ITE_IT6505
tristate "ITE IT6505 DisplayPort bridge"
depends on OF
select DRM_KMS_HELPER
+ select DRM_DP_HELPER
select EXTCON
help
ITE IT6505 DisplayPort bridge chip driver.
--
2.36.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
@ 2022-04-26 14:15 ` Fabien Parent
0 siblings, 0 replies; 10+ messages in thread
From: Fabien Parent @ 2022-04-26 14:15 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Hermes Wu, Allen Chen, AngeloGioacchino Del Regno
Cc: Fabien Parent, linux-kernel, dri-devel
The IT6505 is using functions provided by the DRM_DP_HELPER driver.
In order to avoid having the bridge enabled but the helper disabled,
let's add a select in order to be sure that the DP helper functions are
always available.
Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 007e5a282f67..2145b08f9534 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -78,6 +78,7 @@ config DRM_ITE_IT6505
tristate "ITE IT6505 DisplayPort bridge"
depends on OF
select DRM_KMS_HELPER
+ select DRM_DP_HELPER
select EXTCON
help
ITE IT6505 DisplayPort bridge chip driver.
--
2.36.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
2022-04-26 14:15 ` Fabien Parent
@ 2022-04-26 15:29 ` Neil Armstrong
-1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2022-04-26 15:29 UTC (permalink / raw)
To: Fabien Parent, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Hermes Wu, Allen Chen, AngeloGioacchino Del Regno
Cc: dri-devel, linux-kernel
On 26/04/2022 16:15, Fabien Parent wrote:
> The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> In order to avoid having the bridge enabled but the helper disabled,
> let's add a select in order to be sure that the DP helper functions are
> always available.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 007e5a282f67..2145b08f9534 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
> tristate "ITE IT6505 DisplayPort bridge"
> depends on OF
> select DRM_KMS_HELPER
> + select DRM_DP_HELPER
> select EXTCON
> help
> ITE IT6505 DisplayPort bridge chip driver.
http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org also select DRM_DP_AUX_BUS,
can you check if this is really neaded ?
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
@ 2022-04-26 15:29 ` Neil Armstrong
0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2022-04-26 15:29 UTC (permalink / raw)
To: Fabien Parent, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Hermes Wu, Allen Chen, AngeloGioacchino Del Regno
Cc: linux-kernel, dri-devel
On 26/04/2022 16:15, Fabien Parent wrote:
> The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> In order to avoid having the bridge enabled but the helper disabled,
> let's add a select in order to be sure that the DP helper functions are
> always available.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 007e5a282f67..2145b08f9534 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
> tristate "ITE IT6505 DisplayPort bridge"
> depends on OF
> select DRM_KMS_HELPER
> + select DRM_DP_HELPER
> select EXTCON
> help
> ITE IT6505 DisplayPort bridge chip driver.
http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org also select DRM_DP_AUX_BUS,
can you check if this is really neaded ?
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
2022-04-26 15:29 ` Neil Armstrong
@ 2022-04-26 15:39 ` Fabien Parent
-1 siblings, 0 replies; 10+ messages in thread
From: Fabien Parent @ 2022-04-26 15:39 UTC (permalink / raw)
To: Neil Armstrong
Cc: Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Hermes Wu,
Allen Chen, AngeloGioacchino Del Regno, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
On Tue, Apr 26, 2022 at 05:29:31PM +0200, Neil Armstrong wrote:
> On 26/04/2022 16:15, Fabien Parent wrote:
> > The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> > In order to avoid having the bridge enabled but the helper disabled,
> > let's add a select in order to be sure that the DP helper functions are
> > always available.
> >
> > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> > drivers/gpu/drm/bridge/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 007e5a282f67..2145b08f9534 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
> > tristate "ITE IT6505 DisplayPort bridge"
> > depends on OF
> > select DRM_KMS_HELPER
> > + select DRM_DP_HELPER
> > select EXTCON
> > help
> > ITE IT6505 DisplayPort bridge chip driver.
>
> http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org also select DRM_DP_AUX_BUS,
> can you check if this is really neaded ?
Oops, I didn't notice that patch.
Anyway I can successfully link with the following config:
CONFIG_DRM_ITE_IT6505=y
CONFIG_DRM_DP_AUX_BUS=m
CONFIG_DRM_DP_HELPER=y
But I cannot with the following config:
CONFIG_DRM_ITE_IT6505=y
CONFIG_DRM_DP_AUX_BUS=m
CONFIG_DRM_DP_HELPER=m
This suggest that DRM_DP_AUX_BUS is not required for that driver.
Fabien
>
> Neil
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
@ 2022-04-26 15:39 ` Fabien Parent
0 siblings, 0 replies; 10+ messages in thread
From: Fabien Parent @ 2022-04-26 15:39 UTC (permalink / raw)
To: Neil Armstrong
Cc: Jonas Karlman, David Airlie, Allen Chen, dri-devel, linux-kernel,
Jernej Skrabec, Hermes Wu, Robert Foss, Andrzej Hajda,
AngeloGioacchino Del Regno, Laurent Pinchart
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
On Tue, Apr 26, 2022 at 05:29:31PM +0200, Neil Armstrong wrote:
> On 26/04/2022 16:15, Fabien Parent wrote:
> > The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> > In order to avoid having the bridge enabled but the helper disabled,
> > let's add a select in order to be sure that the DP helper functions are
> > always available.
> >
> > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> > drivers/gpu/drm/bridge/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 007e5a282f67..2145b08f9534 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
> > tristate "ITE IT6505 DisplayPort bridge"
> > depends on OF
> > select DRM_KMS_HELPER
> > + select DRM_DP_HELPER
> > select EXTCON
> > help
> > ITE IT6505 DisplayPort bridge chip driver.
>
> http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org also select DRM_DP_AUX_BUS,
> can you check if this is really neaded ?
Oops, I didn't notice that patch.
Anyway I can successfully link with the following config:
CONFIG_DRM_ITE_IT6505=y
CONFIG_DRM_DP_AUX_BUS=m
CONFIG_DRM_DP_HELPER=y
But I cannot with the following config:
CONFIG_DRM_ITE_IT6505=y
CONFIG_DRM_DP_AUX_BUS=m
CONFIG_DRM_DP_HELPER=m
This suggest that DRM_DP_AUX_BUS is not required for that driver.
Fabien
>
> Neil
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
2022-04-26 15:39 ` Fabien Parent
@ 2022-04-26 15:59 ` Neil Armstrong
-1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2022-04-26 15:59 UTC (permalink / raw)
To: Fabien Parent
Cc: Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Hermes Wu,
Allen Chen, AngeloGioacchino Del Regno, dri-devel, linux-kernel
Hi,
On 26/04/2022 17:39, Fabien Parent wrote:
> On Tue, Apr 26, 2022 at 05:29:31PM +0200, Neil Armstrong wrote:
>> On 26/04/2022 16:15, Fabien Parent wrote:
>>> The IT6505 is using functions provided by the DRM_DP_HELPER driver.
>>> In order to avoid having the bridge enabled but the helper disabled,
>>> let's add a select in order to be sure that the DP helper functions are
>>> always available.
>>>
>>> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
>>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>>> ---
>>> drivers/gpu/drm/bridge/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>>> index 007e5a282f67..2145b08f9534 100644
>>> --- a/drivers/gpu/drm/bridge/Kconfig
>>> +++ b/drivers/gpu/drm/bridge/Kconfig
>>> @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
>>> tristate "ITE IT6505 DisplayPort bridge"
>>> depends on OF
>>> select DRM_KMS_HELPER
>>> + select DRM_DP_HELPER
>>> select EXTCON
>>> help
>>> ITE IT6505 DisplayPort bridge chip driver.
>>
>> http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org also select DRM_DP_AUX_BUS,
>> can you check if this is really neaded ?
>
> Oops, I didn't notice that patch.
>
> Anyway I can successfully link with the following config:
> CONFIG_DRM_ITE_IT6505=y
> CONFIG_DRM_DP_AUX_BUS=m
> CONFIG_DRM_DP_HELPER=y
>
> But I cannot with the following config:
> CONFIG_DRM_ITE_IT6505=y
> CONFIG_DRM_DP_AUX_BUS=m
> CONFIG_DRM_DP_HELPER=m
>
> This suggest that DRM_DP_AUX_BUS is not required for that driver.
Thanks for confirming:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Fabien
>
>>
>> Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
@ 2022-04-26 15:59 ` Neil Armstrong
0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2022-04-26 15:59 UTC (permalink / raw)
To: Fabien Parent
Cc: Jonas Karlman, David Airlie, Allen Chen, dri-devel, linux-kernel,
Jernej Skrabec, Hermes Wu, Robert Foss, Andrzej Hajda,
AngeloGioacchino Del Regno, Laurent Pinchart
Hi,
On 26/04/2022 17:39, Fabien Parent wrote:
> On Tue, Apr 26, 2022 at 05:29:31PM +0200, Neil Armstrong wrote:
>> On 26/04/2022 16:15, Fabien Parent wrote:
>>> The IT6505 is using functions provided by the DRM_DP_HELPER driver.
>>> In order to avoid having the bridge enabled but the helper disabled,
>>> let's add a select in order to be sure that the DP helper functions are
>>> always available.
>>>
>>> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
>>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>>> ---
>>> drivers/gpu/drm/bridge/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>>> index 007e5a282f67..2145b08f9534 100644
>>> --- a/drivers/gpu/drm/bridge/Kconfig
>>> +++ b/drivers/gpu/drm/bridge/Kconfig
>>> @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
>>> tristate "ITE IT6505 DisplayPort bridge"
>>> depends on OF
>>> select DRM_KMS_HELPER
>>> + select DRM_DP_HELPER
>>> select EXTCON
>>> help
>>> ITE IT6505 DisplayPort bridge chip driver.
>>
>> http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org also select DRM_DP_AUX_BUS,
>> can you check if this is really neaded ?
>
> Oops, I didn't notice that patch.
>
> Anyway I can successfully link with the following config:
> CONFIG_DRM_ITE_IT6505=y
> CONFIG_DRM_DP_AUX_BUS=m
> CONFIG_DRM_DP_HELPER=y
>
> But I cannot with the following config:
> CONFIG_DRM_ITE_IT6505=y
> CONFIG_DRM_DP_AUX_BUS=m
> CONFIG_DRM_DP_HELPER=m
>
> This suggest that DRM_DP_AUX_BUS is not required for that driver.
Thanks for confirming:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Fabien
>
>>
>> Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
2022-04-26 14:15 ` Fabien Parent
@ 2022-05-04 8:15 ` Neil Armstrong
-1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2022-05-04 8:15 UTC (permalink / raw)
To: Robert Foss, Andrzej Hajda, Daniel Vetter, David Airlie,
Fabien Parent, Hermes Wu, Allen Chen, AngeloGioacchino Del Regno,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec
Cc: linux-kernel, dri-devel, Neil Armstrong
Hi,
On Tue, 26 Apr 2022 16:15:36 +0200, Fabien Parent wrote:
> The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> In order to avoid having the bridge enabled but the helper disabled,
> let's add a select in order to be sure that the DP helper functions are
> always available.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)
[1/1] drm/bridge: ite-it6505: add missing Kconfig option select
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=841e512ffb64898db6322c0619f6bbc41266d86f
--
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
@ 2022-05-04 8:15 ` Neil Armstrong
0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2022-05-04 8:15 UTC (permalink / raw)
To: Robert Foss, Andrzej Hajda, Daniel Vetter, David Airlie,
Fabien Parent, Hermes Wu, Allen Chen, AngeloGioacchino Del Regno,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec
Cc: Neil Armstrong, linux-kernel, dri-devel
Hi,
On Tue, 26 Apr 2022 16:15:36 +0200, Fabien Parent wrote:
> The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> In order to avoid having the bridge enabled but the helper disabled,
> let's add a select in order to be sure that the DP helper functions are
> always available.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)
[1/1] drm/bridge: ite-it6505: add missing Kconfig option select
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=841e512ffb64898db6322c0619f6bbc41266d86f
--
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-04 8:16 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 14:15 [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select Fabien Parent
2022-04-26 14:15 ` Fabien Parent
2022-04-26 15:29 ` Neil Armstrong
2022-04-26 15:29 ` Neil Armstrong
2022-04-26 15:39 ` Fabien Parent
2022-04-26 15:39 ` Fabien Parent
2022-04-26 15:59 ` Neil Armstrong
2022-04-26 15:59 ` Neil Armstrong
2022-05-04 8:15 ` Neil Armstrong
2022-05-04 8:15 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.