* [Buildroot] [PATCH] toolchain-external: clarify external toolchain description
@ 2015-02-17 11:48 Baruch Siach
2015-02-19 20:36 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2015-02-17 11:48 UTC (permalink / raw)
To: buildroot
External toolchain can also have been generated by Buildroot previously, as
the list that follows demonstrates. Add the word 'locally' at the right place
to make the point clearer.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
toolchain/toolchain-external/toolchain-external.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index 5a69eb88958e..4376c8ddbf1f 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -6,9 +6,9 @@
#
# This package implements the support for external toolchains, i.e
-# toolchains that have not been produced by Buildroot itself and that
-# Buildroot can download from the Web or that are already available on
-# the system on which Buildroot runs. So far, we have tested this
+# toolchains that have not been produced locally by Buildroot itself and
+# that Buildroot can download from the Web or that are already available
+# on the system on which Buildroot runs. So far, we have tested this
# with:
#
# * Toolchains generated by Crosstool-NG
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain-external: clarify external toolchain description
2015-02-17 11:48 [Buildroot] [PATCH] toolchain-external: clarify external toolchain description Baruch Siach
@ 2015-02-19 20:36 ` Thomas Petazzoni
2015-02-20 6:37 ` Baruch Siach
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-02-19 20:36 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Tue, 17 Feb 2015 13:48:05 +0200, Baruch Siach wrote:
> # This package implements the support for external toolchains, i.e
> -# toolchains that have not been produced by Buildroot itself and that
> -# Buildroot can download from the Web or that are already available on
> -# the system on which Buildroot runs. So far, we have tested this
> +# toolchains that have not been produced locally by Buildroot itself and
I am not sure adding "locally" makes the thing clearer: you can very
well produce a toolchain with Buildroot "locally", and then re-use it
in a later Buildroot build as an external toolchain on the same machine.
Maybe we should simply rephrase this as:
This package implements the support for external toolchains, i.e
toolchains that are available pre-built, ready to use. Such toolchain
me either be readily available on the Web (Linaro, Sourcery
CodeBench, from processor vendors) or may be built with tools like
Crosstool-NG or Buildroot itself.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain-external: clarify external toolchain description
2015-02-19 20:36 ` Thomas Petazzoni
@ 2015-02-20 6:37 ` Baruch Siach
2015-02-20 8:02 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2015-02-20 6:37 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Thu, Feb 19, 2015 at 09:36:18PM +0100, Thomas Petazzoni wrote:
> On Tue, 17 Feb 2015 13:48:05 +0200, Baruch Siach wrote:
> > # This package implements the support for external toolchains, i.e
> > -# toolchains that have not been produced by Buildroot itself and that
> > -# Buildroot can download from the Web or that are already available on
> > -# the system on which Buildroot runs. So far, we have tested this
> > +# toolchains that have not been produced locally by Buildroot itself and
>
> I am not sure adding "locally" makes the thing clearer: you can very
> well produce a toolchain with Buildroot "locally", and then re-use it
> in a later Buildroot build as an external toolchain on the same machine.
>
> Maybe we should simply rephrase this as:
>
> This package implements the support for external toolchains, i.e
> toolchains that are available pre-built, ready to use. Such toolchain
> me either be readily available on the Web (Linaro, Sourcery
s/me/may/
> CodeBench, from processor vendors) or may be built with tools like
> Crosstool-NG or Buildroot itself.
Looks good to me. Would you like me to send a patch?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-20 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 11:48 [Buildroot] [PATCH] toolchain-external: clarify external toolchain description Baruch Siach
2015-02-19 20:36 ` Thomas Petazzoni
2015-02-20 6:37 ` Baruch Siach
2015-02-20 8:02 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.