From: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tom St Denis <tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx mailing list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] Autodetect libdrm path (v2)
Date: Tue, 7 Feb 2017 06:30:44 -0500 [thread overview]
Message-ID: <13f9479c-1a5c-8887-858e-dadf819a7140@amd.com> (raw)
In-Reply-To: <CACvgo537ciLvg=Q6enktu6ndMSEuSCM+RpmniJdgYNgZDQjUeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 07/02/17 06:02 AM, Emil Velikov wrote:
> On 6 February 2017 at 22:39, StDenis, Tom <Tom.StDenis@amd.com> wrote:
>>
>> Apparently I missed the bottom of your reply (all of the clients I have outlook/gmail do top post only ...)
> Both Outlook and Gmail can do inline replies and plain text. There
> might be some magic required for the former though :-\
> I would kindly suggest using inline/text when possible.
You'll be pleased to note I discovered (at some point) that AMD has
re-enabled imap support and I can now use a more sensible client...
:-)
>> Ironically, I had the pkg_check originally but was told that's a faux-pas.
>>
> It's a common misconception, influenced by the sheer volume of copy/paste :-)
>
>>
>> Unless this is breaking for actual users though it's not really a priority to bikeshed the build system of a 30 file project that is meant to work only on developer machines who are likely building for themselves
>>
> Up-to you really. FWIW using cmake/autoconf/etc. is a huge overkill.
> The original makefile was missing a few things* worth 10-20 lines of
> code while being noticeably smaller, quicker and easier to read ;-)
To be honest unless the cmake system gets in the way I'm happy if it
makes others happy. It's not easy to say the project is "open" if we
NAK any and all harmless commits that the users advocate for.
The official stance from AMD (specifically the team I work for) is if
cmake gets in the way of AMD work we will nuke the cmake system and go
back to gmake (with pkg-config shell calls to get paths).
Personally I'm not a big fan of overly complicated config/build systems
but since I don't do package building/etc for a living I'll defer to the
opinions of others within reason.
>> Also umr can read/write registers via pci access without amdgpu loaded (handy if amdgpu fails to init properly).
>>
> Must have missed this part. Thanks for the correction.
Yup, you can force device + direct access, e.g.
umr -O use_pci -f fiji -r *.uvd5.mmFOO
Which is handy like I said if the module init fails. Developers also
use it in NPI bringup to poke things.
Cheers,
Tom
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-02-07 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 22:24 [PATCH] Autodetect libdrm path (v2) Tom St Denis
[not found] ` <20170205222447.19945-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2017-02-05 22:28 ` Andres Rodriguez
[not found] ` <62ec2a45-ea86-a643-f7fd-3e5e5054540b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-05 22:42 ` StDenis, Tom
2017-02-06 20:18 ` Emil Velikov
[not found] ` <CACvgo5230Use5sk8dm5jBbLqiJeSkgB6cDikz-N4omx-4Jgy9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-06 21:33 ` StDenis, Tom
[not found] ` <CY4PR12MB17689AEC15DEF9662A16DEA3F7400-rpdhrqHFk06yjjPBNVDk/QdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-02-06 22:39 ` StDenis, Tom
[not found] ` <CY4PR12MB1768AED537A0253EB70B1E4BF7400-rpdhrqHFk06yjjPBNVDk/QdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-02-07 11:02 ` Emil Velikov
[not found] ` <CACvgo537ciLvg=Q6enktu6ndMSEuSCM+RpmniJdgYNgZDQjUeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-07 11:30 ` Tom St Denis [this message]
[not found] ` <13f9479c-1a5c-8887-858e-dadf819a7140-5C7GfCeVMHo@public.gmane.org>
2017-02-07 12:41 ` Emil Velikov
2017-02-08 0:48 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13f9479c-1a5c-8887-858e-dadf819a7140@amd.com \
--to=tom.stdenis-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.